xdp: ensure initialization of txq in xdp_buff
Subsystems (3)
PATCH 1/1 xdp: ensure initialization of txq in xdp_buff
xdp->txq was uninitialized and could be used from within a bpf program.
https://syzkaller.appspot.com/bug?id=a6e53f8e9044ea456ea1636be970518ae6ba7f62
Signed-off-by Paul Hollinsky <[email protected]>
--- net/core/dev.c | 2 ++ 1 file changed, 2 insertions(+)
net/core/dev.c +2 -0
@@ -4649,6 +4649,8 @@ static u32 netif_receive_generic_xdp(struct sk_buff *skb, rxqueue =netif_get_rxqueue (skb); xdp->rxq = &rxqueue->xdp_rxq; + xdp->txq =NULL ; + act =bpf_prog_run_xdp (xdp_prog, xdp);/* check if bpf_xdp_adjust_head was used */
Signature · 1 line
2.25.1
Quoted 1 line · Paul Hollinsky
xdp->txqwas uninitialized and could be used from within a bpf program.
The verifier prevents access to txq except by programs of type BPF_XDP_DEVMAP and those can not be run via xdp generic. ie., generic can not access txq.
Quoted 22 lines
https://syzkaller.appspot.com/bug?id=a6e53f8e9044ea456ea1636be970518ae6ba7f62
Signed-off-by Paul Hollinsky <[email protected]>--- net/core/dev.c | 2 ++ 1 file changed, 2 insertions(+)net/core/dev.c +2
-0@@ -4649,6 +4649,8 @@ static u32 netif_receive_generic_xdp(struct sk_buff *skb, rxqueue =netif_get_rxqueue (skb); xdp->rxq = &rxqueue->xdp_rxq; + xdp->txq =NULL ; + act =bpf_prog_run_xdp (xdp_prog, xdp);/* check if bpf_xdp_adjust_head was used */