Skip to contentSkip to conversation

scsi: qla2xxx: replace ternary operator with max()

PATCH New [email protected] 1 participant 1 message Oct 29, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: replace ternary operator with max()

Fix the following coccicheck warning:

drivers/scsi/qla2xxx/qla_dbg.c:689: WARNING opportunity for max()

---
 drivers/scsi/qla2xxx/qla_dbg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/qla2xxx/qla_dbg.c +1 -2
index d7e8454304ce..68ce440bd6cf 100644
@@ -686,8 +686,7 @@ qla25xx_copy_mq(struct qla_hw_data *ha, void *ptr, __be32 **last_chain)
 	mq->type = htonl(DUMP_CHAIN_MQ);
 	mq->chain_size = htonl(sizeof(struct qla2xxx_mq_chain));
 
-	que_cnt = ha->max_req_queues > ha->max_rsp_queues ?
-		ha->max_req_queues : ha->max_rsp_queues;
+	que_cnt = max(ha->max_req_queues, ha->max_rsp_queues);
 	mq->count = htonl(que_cnt);
 	for (cnt = 0; cnt < que_cnt; cnt++) {
 		reg = ISP_QUE_REG(ha, cnt);
Signature · 1 line
2.25.1