Skip to contentSkip to conversation

ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

PATCH In review Daniel Abrecht 2 participants 5 messages Jan 17, 2024 – Jan 22, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ASoC: soc-core.c: Add "Unknown" and "Unknown Product" to dmi_blacklist

In U-Boot, the default for DMI vendor / product if not set is "Unknown" and "Unknown Product". See https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272

This patch adds them to the dmi_blacklist.

---
 sound/soc/soc-core.c | 2 ++
 1 file changed, 2 insertions(+)
sound/soc/soc-core.c +2 -0
index f8524b5bfb33..aa1a31abbe3a 100644
@@ -1804,6 +1804,8 @@ static const char * const dmi_blacklist[] = {
 	"Board Manufacturer",
 	"Board Vendor Name",
 	"Board Product Name",
+	"Unknown",
+	"Unknown Product",
 	NULL,	/* terminator */
 };
 
Signature · 1 line
2.39.2
maintainer
#1 lore raw
Quoted 2 lines · Daniel Abrecht

In U-Boot, the default for DMI vendor / product if not set is "Unknown" and "Unknown Product".

This doesn't apply against current code, please check and resend.

#4 lore raw

Am 2024-01-22 16:30, schrieb Mark Brown:

Quoted 7 lines · Daniel Abrecht
Quoted 3 lines

In U-Boot, the default for DMI vendor / product if not set is "Unknown" and "Unknown Product".
See https://source.denx.de/u-boot/u-boot/-/blob/v2023.10/lib/smbios.c?ref_type=tags#L272

This is still corrupted according to git am unfortunately. I can't immediately spot the issue.

The v3 I sent applies just fine with "git am" as far as I can tell. I just tested it again with the mail form the list. I think the v3 patch is fine, but this time, the v3 message ended up with the same message ID as the v2 message. Because of this, some mail clients may get confused, and the threading in mail clients is going to be broken.