Skip to contentSkip to conversation

soc: mediatek: Add deprecated compatible to mmsys

PATCH In review [email protected] 4 participants 9 messages Nov 11, 2022 – Dec 16, 2022 Arm MediaTek

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 soc: mediatek: Add deprecated compatible to mmsys

From: Matthias Brugger <[email protected]>

For backward compatibility we add the deprecated compatible.

---
Changes since v1:
- fix drive data pointer

 drivers/soc/mediatek/mtk-mmsys.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/soc/mediatek/mtk-mmsys.c +4 -0
index ba2e79b26993b..f3431448e8431 100644
@@ -303,6 +303,10 @@ static const struct of_device_id of_match_mtk_mmsys[] = {
 		.compatible = "mediatek,mt8192-mmsys",
 		.data = &mt8192_mmsys_driver_data,
 	},
+	{	/* deprecated compatible */
+		.compatible = "mediatek,mt8195-mmsys",
+		.data = &mt8195_vdosys0_driver_data,
+	},
 	{
 		.compatible = "mediatek,mt8195-vdosys0",
 		.data = &mt8195_vdosys0_driver_data,
Signature · 1 line
2.38.0
#3 lore raw
In reply to AngeloGioacchino Del Regno
Quoted 11 lines · AngeloGioacchino Del Regno

Il 11/11/22 09:29, [email protected] ha scritto:

Quoted 5 lines

From: Matthias Brugger <[email protected]>

For backward compatibility we add the deprecated compatible.

...And tested on MT8195 Cherry Chromebook.

This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and vdosys1) that both currently use the -mmsys compatible, which in the driver maps to vdosys0. So not only do we have vdosys1 incorrectly probing as vdosys0, we also have duplicate clks being registered and duplicate DRM pipelines. On my device vdosys1 ends up winning the duplicate clock race.

I suggest just reverting this. The display stuff won't be useful unless the drivers are able to distinguish themselves from one another.

Regards
ChenYu

#4 lore raw
Quoted 15 lines · Chen-Yu Tsai
Quoted 11 lines · AngeloGioacchino Del Regno

Il 11/11/22 09:29, [email protected] ha scritto:

Quoted 5 lines

From: Matthias Brugger <[email protected]>

For backward compatibility we add the deprecated compatible.

...And tested on MT8195 Cherry Chromebook.

Quoted 8 lines

This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and vdosys1) that both currently use the -mmsys compatible, which in the driver maps to vdosys0. So not only do we have vdosys1 incorrectly probing as vdosys0, we also have duplicate clks being registered and duplicate DRM pipelines. On my device vdosys1 ends up winning the duplicate clock race.

I suggest just reverting this. The display stuff won't be useful unless the drivers are able to distinguish themselves from one another.

That and try to fix the vdosys0 node ASAP.

Quoted 2 lines

Regards
ChenYu

maintainer
#5 lore raw
Quoted 22 lines · Chen-Yu Tsai
Quoted 21 lines · Chen-Yu Tsai
Quoted 11 lines · AngeloGioacchino Del Regno

Il 11/11/22 09:29, [email protected] ha scritto:

Quoted 5 lines

From: Matthias Brugger <[email protected]>

For backward compatibility we add the deprecated compatible.

...And tested on MT8195 Cherry Chromebook.

This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and vdosys1) that both currently use the -mmsys compatible, which in the driver maps to vdosys0. So not only do we have vdosys1 incorrectly probing as vdosys0, we also have duplicate clks being registered and duplicate DRM pipelines. On my device vdosys1 ends up winning the duplicate clock race.

Quoted 4 lines
Quoted 2 lines

I suggest just reverting this. The display stuff won't be useful unless the drivers are able to distinguish themselves from one another.

That and try to fix the vdosys0 node ASAP.

I'm not sure what you mean? If there are any patches that are in my queue that needs attention, please let me know.

Regards,
Matthias

#6 lore raw
Quoted 26 lines · Matthias Brugger
Quoted 22 lines · Chen-Yu Tsai
Quoted 21 lines · Chen-Yu Tsai
Quoted 11 lines · AngeloGioacchino Del Regno

Il 11/11/22 09:29, [email protected] ha scritto:

Quoted 5 lines

From: Matthias Brugger <[email protected]>

For backward compatibility we add the deprecated compatible.

...And tested on MT8195 Cherry Chromebook.

This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and vdosys1) that both currently use the -mmsys compatible, which in the driver maps to vdosys0. So not only do we have vdosys1 incorrectly probing as vdosys0, we also have duplicate clks being registered and duplicate DRM pipelines. On my device vdosys1 ends up winning the duplicate clock race.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

I suggest just reverting this. The display stuff won't be useful unless the drivers are able to distinguish themselves from one another.

That and try to fix the vdosys0 node ASAP.

I'm not sure what you mean? If there are any patches that are in my queue that needs attention, please let me know.

It was more of a P.S. note.

maintainer
#7 lore raw
In reply to Chen-Yu Tsai
Quoted 12 lines · Chen-Yu Tsai
Quoted 10 lines · AngeloGioacchino Del Regno

Il 11/11/22 09:29, [email protected] ha scritto:

Quoted 5 lines

From: Matthias Brugger <[email protected]>

For backward compatibility we add the deprecated compatible.

Quoted 8 lines
Quoted 1 line

...And tested on MT8195 Cherry Chromebook.

This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and vdosys1) that both currently use the -mmsys compatible, which in the driver maps to vdosys0. So not only do we have vdosys1 incorrectly probing as vdosys0, we also have duplicate clks being registered and duplicate DRM pipelines. On my device vdosys1 ends up winning the duplicate clock race.

That's true, we should fix the DTS deleting vdosys1 node as it's not implemented. While at it we should also fix the compatible for vdosys0 as "mediatek,mt8195-mmsys" is now deprecated.

Would you mind to send a patch?

Regards,
Matthias

Quoted 3 lines

I suggest just reverting this. The display stuff won't be useful unless the drivers are able to distinguish themselves from one another.

#8 lore raw
Quoted 25 lines · Matthias Brugger
Quoted 12 lines · Chen-Yu Tsai
Quoted 10 lines · AngeloGioacchino Del Regno

Il 11/11/22 09:29, [email protected] ha scritto:

Quoted 5 lines

From: Matthias Brugger <[email protected]>

For backward compatibility we add the deprecated compatible.

Quoted 8 lines
Quoted 1 line

...And tested on MT8195 Cherry Chromebook.

This now seems like a bad idea. In the dtsi we have two nodes (vdosys0 and vdosys1) that both currently use the -mmsys compatible, which in the driver maps to vdosys0. So not only do we have vdosys1 incorrectly probing as vdosys0, we also have duplicate clks being registered and duplicate DRM pipelines. On my device vdosys1 ends up winning the duplicate clock race.

Quoted 5 lines

That's true, we should fix the DTS deleting vdosys1 node as it's not implemented. While at it we should also fix the compatible for vdosys0 as "mediatek,mt8195-mmsys" is now deprecated.

Would you mind to send a patch?

I'll be going on vacation shortly, and will be back after Christmas.

Reading the above, I assume you want two patches? One to drop the deprecated compatible, and another to delete the vdosys1 node? And both should be tag with fixes and backported?

I can take care of it after I get back. If someone wants to beat me to it, feel free to do it.

ChenYu