pcie: consistent names for function args
PATCH v2 1/1 pcie: consistent names for function args
The function declarations for pci_cap_slot_get and pci_cap_slot_write_config call the argument "slot_ctl", but the function definitions and all the call sites drop the 'o' and call it "slt_ctl". Let's be consistent.
Reported-by Peter Maydell <[email protected]>
Signed-off-by Michael S. Tsirkin <[email protected]>
---
Fix pcie_cap_slot_write_config too.
include/hw/pci/pcie.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/hw/pci/pcie.h +2 -2
@@ -107,9 +107,9 @@ void pcie_cap_lnkctl_reset(PCIDevice *dev);void pcie_cap_slot_init (PCIDevice *dev,uint16_t slot);void pcie_cap_slot_reset (PCIDevice *dev); -void pcie_cap_slot_get (PCIDevice *dev,uint16_t *slot_ctl,uint16_t *slt_sta); +void pcie_cap_slot_get (PCIDevice *dev,uint16_t *slt_ctl,uint16_t *slt_sta);void pcie_cap_slot_write_config (PCIDevice *dev, -uint16_t old_slot_ctl,uint16_t old_slt_sta, +uint16_t old_slt_ctl,uint16_t old_slt_sta,uint32_t addr,uint32_t val,int len);int pcie_cap_slot_post_load (void *opaque,int version_id);void pcie_cap_slot_push_attention_button (PCIDevice *dev);
Signature · 1 line
MST
Quoted 20 lines · Michael S. Tsirkin
The function declarations for
pci_cap_slot_getandpci_cap_slot_write_configcall the argument "slot_ctl", but the function definitions and all the call sites drop the 'o' and call it "slt_ctl". Let's be consistent.Reported-by Peter Maydell <[email protected]>Signed-off-by Michael S. Tsirkin <[email protected]>---
Fix
pcie_cap_slot_write_configtoo.include/hw/pci/pcie.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)include/hw/pci/pcie.h +0
-0@@ -107,9 +107,9 @@ void pcie_cap_lnkctl_reset(PCIDevice *dev);
include/hw/pci/pcie.h void pcie_cap_lnkctl_reset(PCIDevice *dev); · line 115
Quoted 10 lines
include/hw/pci/pcie.h +2
-2void pcie_cap_slot_init (PCIDevice *dev,uint16_t slot);void pcie_cap_slot_reset (PCIDevice *dev); -void pcie_cap_slot_get (PCIDevice *dev,uint16_t *slot_ctl,uint16_t *slt_sta); +void pcie_cap_slot_get (PCIDevice *dev,uint16_t *slt_ctl,uint16_t *slt_sta);void pcie_cap_slot_write_config (PCIDevice *dev, -uint16_t old_slot_ctl,uint16_t old_slt_sta, +uint16_t old_slt_ctl,uint16_t old_slt_sta,uint32_t addr,uint32_t val,int len);int pcie_cap_slot_post_load (void *opaque,int version_id);void pcie_cap_slot_push_attention_button (PCIDevice *dev);
Reviewed-by Marcel Apfelbaum <[email protected]>
Thanks,
Marcel