Skip to contentSkip to conversation

python3-bcrypt: enable native builds

PATCH In review Ross Burton 3 participants 4 messages Sep 16

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 python3-bcrypt: enable native builds

---
 meta/recipes-devtools/python/python3-bcrypt_5.0.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/python/python3-bcrypt_5.0.0.bb +2 -0
index 51b7edef8cf..909b5890844 100644
@@ -19,3 +19,5 @@ RDEPENDS:${PN}:class-target += "\
     python3-ctypes \
     python3-shell \
 "
+
+BBCLASSEXTEND = "native"
Signature · 1 line
2.43.0
#1 lore raw

PATCH 2/2 classes/python_pyo3: export fewer variables

These variables are already set in the pyo3.config that is written, so there is no need to also export them.

Apart from PYO3_PYTHON, so set "executable".

---
 meta/classes-recipe/python_pyo3.bbclass | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta/classes-recipe/python_pyo3.bbclass +1 -3
index d2aa188cf07..8854ed80d9b 100644
@@ -12,11 +12,8 @@
 inherit cargo python3-dir siteinfo
 
 export PYO3_CROSS = "1"
-export PYO3_CROSS_PYTHON_VERSION = "${PYTHON_BASEVERSION}"
-export PYO3_CROSS_LIB_DIR = "${STAGING_LIBDIR}"
 export CARGO_BUILD_TARGET = "${RUST_HOST_SYS}"
 export RUSTFLAGS
-export PYO3_PYTHON = "${PYTHON}"
 export PYO3_CONFIG_FILE = "${WORKDIR}/pyo3.config"
 
 python_pyo3_do_configure () {
@@ -25,6 +22,7 @@ implementation=CPython
 version=${PYTHON_BASEVERSION}
 shared=true
 abi3=false
+executable=${PYTHON}
 lib_name=${PYTHON_DIR}
 lib_dir=${STAGING_LIBDIR}
 pointer_width=${SITEINFO_BITS}
Signature · 1 line
2.43.0
#2 lore raw
In reply to Ross Burton
Quoted 13 lines · Ross Burton via lists.openembedded.org

---
 meta/recipes-devtools/python/python3-bcrypt_5.0.0.bb | 2 ++

 1 file changed, 2 insertions(+)
meta/recipes-devtools/python/python3-bcrypt_5.0.0.bb +0 -0
index 51b7edef8cf..909b5890844 100644
@@ -19,3 +19,5 @@ RDEPENDS:${PN}:class-target += "\
      python3-ctypes \
      python3-shell \

 "

meta/recipes-devtools/python/python3-bcrypt_5.0.0.bb RDEPENDS:${PN}:class-target += "\ · line 23

Quoted 2 lines
meta/recipes-devtools/python/python3-bcrypt_5.0.0.bb +2 -0
+
+BBCLASSEXTEND = "native"

Why?

Cheers,

Richard

#3 lore raw

Patchtest results for [PATCH 1/2] python3-bcrypt: enable native builds

In reply to Ross Burton

Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information:

---
Testing patch /home/patchtest/share/mboxes/1-2-python3-bcrypt-enable-native-builds.patch

FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)

PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test auh changelog truncation notice (test_mbox.TestMbox.test_auh_changelog_truncation_notice)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test CVE tag format: No new source patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new source patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new source patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!