Skip to contentSkip to conversation

r8169: add support for RTL8126A rev.b

PATCH Applied ChunHao Lin 3 participants 4 messages Aug 30, 2024 – Sep 3, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 r8169: add support for RTL8126A rev.b

Add support for RTL8126A rev.b. Its XID is 0x64a. It is basically based on the one with XID 0x649, but with different firmware file.

---
 drivers/net/ethernet/realtek/r8169.h          |  1 +
 drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
 .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
 3 files changed, 29 insertions(+), 15 deletions(-)
drivers/net/ethernet/realtek/r8169.h +1 -0
index 00882ffc7a02..e2db944e6fa8 100644
@@ -69,6 +69,7 @@ enum mac_version {
 	RTL_GIGA_MAC_VER_61,
 	RTL_GIGA_MAC_VER_63,
 	RTL_GIGA_MAC_VER_65,
+	RTL_GIGA_MAC_VER_66,
 	RTL_GIGA_MAC_NONE
 };
 
drivers/net/ethernet/realtek/r8169_main.c +27 -15

182 lines not on this page · raw message

drivers/net/ethernet/realtek/r8169_phy_config.c +1 -0
index 1f74317beb88..2c8845e08f86 100644
@@ -1159,6 +1159,7 @@ void r8169_hw_phy_config(struct rtl8169_private *tp, struct phy_device *phydev,
 		[RTL_GIGA_MAC_VER_61] = rtl8125a_2_hw_phy_config,
 		[RTL_GIGA_MAC_VER_63] = rtl8125b_hw_phy_config,
 		[RTL_GIGA_MAC_VER_65] = rtl8126a_hw_phy_config,
+		[RTL_GIGA_MAC_VER_66] = rtl8126a_hw_phy_config,
 	};
 
 	if (phy_configs[ver])
Signature · 1 line
2.43.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 27 lines · ChunHao Lin

Add support for RTL8126A rev.b. Its XID is 0x64a. It is basically based on the one with XID 0x649, but with different firmware file.

---
 drivers/net/ethernet/realtek/r8169.h          |  1 +
 drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
 .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
 3 files changed, 29 insertions(+), 15 deletions(-)
drivers/net/ethernet/realtek/r8169.h +1 -0
index 00882ffc7a02..e2db944e6fa8 100644
@@ -69,6 +69,7 @@ enum mac_version {
 	RTL_GIGA_MAC_VER_61,
 	RTL_GIGA_MAC_VER_63,
 	RTL_GIGA_MAC_VER_65,
+	RTL_GIGA_MAC_VER_66,
 	RTL_GIGA_MAC_NONE
 };
 
drivers/net/ethernet/realtek/r8169_main.c +0 -0
index 3507c2e28110..3cb1c4f5c91a 100644

drivers/net/ethernet/realtek/r8169_main.c line 60

Quoted 5 lines
drivers/net/ethernet/realtek/r8169_main.c +1 -0
@@ -56,6 +56,7 @@
 #define FIRMWARE_8125A_3	"rtl_nic/rtl8125a-3.fw"
 #define FIRMWARE_8125B_2	"rtl_nic/rtl8125b-2.fw"
 #define FIRMWARE_8126A_2	"rtl_nic/rtl8126a-2.fw"
+#define FIRMWARE_8126A_3	"rtl_nic/rtl8126a-3.fw"
 

I checked linux-firmware repo, the new firmware isn't available there yet. Are you going to submit the firmware file?

author
#2 lore raw
Quoted 40 lines

-----Original Message-----
From: Heiner Kallweit [mailto:[email protected]]
Sent: Friday, August 30, 2024 1:34 PM
To: Hau <[email protected]>; nic_swsd <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]
Cc: [email protected]; [email protected]
Subject: Re: [PATCH net-next] r8169: add support for RTL8126A rev.b

External mail.

Quoted 23 lines · ChunHao Lin

Add support for RTL8126A rev.b. Its XID is 0x64a. It is basically based on the one with XID 0x649, but with different firmware file.

---
 drivers/net/ethernet/realtek/r8169.h          |  1 +
 drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
 .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
 3 files changed, 29 insertions(+), 15 deletions(-)
drivers/net/ethernet/realtek/r8169.h +1 -0
index 00882ffc7a02..e2db944e6fa8 100644
@@ -69,6 +69,7 @@ enum mac_version {
      RTL_GIGA_MAC_VER_61,
      RTL_GIGA_MAC_VER_63,
      RTL_GIGA_MAC_VER_65,
+     RTL_GIGA_MAC_VER_66,
      RTL_GIGA_MAC_NONE
 };
 
Quoted 15 lines

drivers/net/ethernet/realtek/r8169_main.c line 60

Quoted 11 lines
drivers/net/ethernet/realtek/r8169_main.c +1 -0
index 3507c2e28110..3cb1c4f5c91a 100644
@@ -56,6 +56,7 @@
 #define FIRMWARE_8125A_3     "rtl_nic/rtl8125a-3.fw"
 #define FIRMWARE_8125B_2     "rtl_nic/rtl8125b-2.fw"
 #define FIRMWARE_8126A_2     "rtl_nic/rtl8126a-2.fw"
+#define FIRMWARE_8126A_3     "rtl_nic/rtl8126a-3.fw"
 

I checked linux-firmware repo, the new firmware isn't available there yet. Are you going to submit the firmware file?

I will submit the new firmware file.

Quoted 1 line
#3 lore raw
In reply to ChunHao Lin
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Fri, 30 Aug 2024 10:18:10 +0800 you wrote:

Add support for RTL8126A rev.b. Its XID is 0x64a. It is basically based on the one with XID 0x649, but with different firmware file.

---
 drivers/net/ethernet/realtek/r8169.h          |  1 +
 drivers/net/ethernet/realtek/r8169_main.c     | 42 ++++++++++++-------
 .../net/ethernet/realtek/r8169_phy_config.c   |  1 +
 3 files changed, 29 insertions(+), 15 deletions(-)

Here is the summary with links:
- [net-next] r8169: add support for RTL8126A rev.b

    https://git.kernel.org/netdev/net-next/c/69cb89981c7a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html