Skip to contentSkip to conversation

drm/i915: use i915_sg_dma_sizes() for internal backend

PATCH In review Matthew Auld 5 participants 6 messages Oct 20, 2022 – Oct 21, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: use i915_sg_dma_sizes() for internal backend

We rely on page_sizes.sg in setup_scratch_page() reporting the correct value if the underlying sgl is not contiguous, however in get_pages_internal() we are only looking at the layout of the created pages when calculating the sg_page_sizes, and not the final sgl, which could in theory be completely different. In such a situation we might incorrectly think we have a 64K scratch page, when it is actually only 4K or similar split over multiple non-contiguous entries, which could lead to broken behaviour when touching the scratch space within the padding of a 64K GTT page-table. Like we already do for other backends, switch over to calling i915_sg_dma_sizes() after mapping the pages.

---
 drivers/gpu/drm/i915/gem/i915_gem_internal.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_internal.c +1 -4
index c698f95af15f..301cfb127c4c 100644
@@ -36,7 +36,6 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 	struct drm_i915_private *i915 = to_i915(obj->base.dev);
 	struct sg_table *st;
 	struct scatterlist *sg;
-	unsigned int sg_page_sizes;
 	unsigned int npages;
 	int max_order;
 	gfp_t gfp;
@@ -75,7 +74,6 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 
 	sg = st->sgl;
 	st->nents = 0;
-	sg_page_sizes = 0;
 
 	do {
 		int order = min(fls(npages) - 1, max_order);
@@ -94,7 +92,6 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 		} while (1);
 
 		sg_set_page(sg, page, PAGE_SIZE << order, 0);
-		sg_page_sizes |= PAGE_SIZE << order;
 		st->nents++;
 
 		npages -= 1 << order;
@@ -116,7 +113,7 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 		goto err;
 	}
 
-	__i915_gem_object_set_pages(obj, st, sg_page_sizes);
+	__i915_gem_object_set_pages(obj, st, i915_sg_dma_sizes(st->sgl));
 
 	return 0;
 
Signature · 1 line
2.37.3
#1 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: use i915_sg_dma_sizes() for internal backend

== Series Details ==

== Series Details ==

Series: drm/i915: use i915_sg_dma_sizes() for internal backend
URL : https://patchwork.freedesktop.org/series/109960/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12267 -> Patchwork_109960v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/index.html

Participating hosts (46 -> 42)
------------------------------

Additional (1): bat-atsm-1
Missing (5): fi-hsw-4200u fi-icl-u2 fi-ctg-p8600 fi-hsw-4770 fi-bdw-samus

Known issues
------------

Here are the changes found in Patchwork_109960v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [PASS][1] -> [FAIL][2] ([i915#7229])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-pnv-d510/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/fi-pnv-d510/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- fi-apl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#7056])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-apl-guc/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/fi-apl-guc/igt@[email protected]

* igt@i915_selftest@live@gem_contexts:
- fi-cfl-8109u: [PASS][5] -> [DMESG-FAIL][6] ([i915#7270])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-cfl-8109u/igt@i915_selftest@live@gem_contexts.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/fi-cfl-8109u/igt@i915_selftest@live@gem_contexts.html

#### Possible fixes ####

* igt@i915_selftest@live@gem_contexts:
- fi-kbl-7567u: [DMESG-FAIL][7] ([i915#7270]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/fi-kbl-7567u/igt@i915_selftest@live@gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/fi-kbl-7567u/igt@i915_selftest@live@gem_contexts.html
- {bat-jsl-1}: [DMESG-FAIL][9] ([i915#7270]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/bat-jsl-1/igt@i915_selftest@live@gem_contexts.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5828]: https://gitlab.freedesktop.org/drm/intel/issues/5828
[i915#7029]: https://gitlab.freedesktop.org/drm/intel/issues/7029
[i915#7030]: https://gitlab.freedesktop.org/drm/intel/issues/7030
[i915#7056]: https://gitlab.freedesktop.org/drm/intel/issues/7056
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7270]: https://gitlab.freedesktop.org/drm/intel/issues/7270

Build changes
-------------

* Linux: CI_DRM_12267 -> Patchwork_109960v1

CI-20190529: 20190529
CI_DRM_12267: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7020: 05b7eaf9ade2216d17c069c89439015757ee25f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109960v1: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

9864929ed379 drm/i915: use i915_sg_dma_sizes() for internal backend

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/index.html

Reviewed-by on v1 1/1
#2 lore raw
In reply to Matthew Auld
Quoted 6 lines · Matthew Auld

We rely on page_sizes.sg in setup_scratch_page() reporting the correct
value if the underlying sgl is not contiguous, however in get_pages_internal() we are only looking at the layout of the created pages when calculating the sg_page_sizes, and not the final sgl, which

Quoted 8 lines

could in theory be completely different. In such a situation we might incorrectly think we have a 64K scratch page, when it is actually only
4K or similar split over multiple non-contiguous entries, which could lead to broken behaviour when touching the scratch space within the padding of a 64K GTT page-table. Like we already do for other backends,
switch over to calling i915_sg_dma_sizes() after mapping the pages.

Makes sense to me. Is there a bug tracking this though? If so please add here.

Otherwise:

Quoted 50 lines
---
 drivers/gpu/drm/i915/gem/i915_gem_internal.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_internal.c +0 -1
index c698f95af15f..301cfb127c4c 100644
@@ -36,7 +36,6 @@ static int
 i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 	struct drm_i915_private *i915 = to_i915(obj->base.dev);
 	struct sg_table *st;
 	struct scatterlist *sg;
-	unsigned int sg_page_sizes;
 	unsigned int npages;
 	int max_order;
drivers/gpu/drm/i915/gem/i915_gem_internal.c +0 -1
 	gfp_t gfp;
@@ -75,7 +74,6 @@ static int
 i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 
 	sg = st->sgl;
 	st->nents = 0;
-	sg_page_sizes = 0;
 
 	do {
drivers/gpu/drm/i915/gem/i915_gem_internal.c +0 -1
 		int order = min(fls(npages) - 1, max_order);
@@ -94,7 +92,6 @@ static int
 i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 		} while (1);
 
 		sg_set_page(sg, page, PAGE_SIZE << order, 0);
-		sg_page_sizes |= PAGE_SIZE << order;
 		st->nents++;
 
drivers/gpu/drm/i915/gem/i915_gem_internal.c +1 -1
 		npages -= 1 << order;
@@ -116,7 +113,7 @@ static int
 i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 		goto err;
 	}
 
-	__i915_gem_object_set_pages(obj, st, sg_page_sizes);
+	__i915_gem_object_set_pages(obj, st, i915_sg_dma_sizes(st-
 >sgl));
 

return 0;

#3 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: use i915_sg_dma_sizes() for internal backend

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: drm/i915: use i915_sg_dma_sizes() for internal backend
URL : https://patchwork.freedesktop.org/series/109960/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12267_full -> Patchwork_109960v1_full
====================================================

Summary
-------

**WARNING**

Minor unknown changes coming with Patchwork_109960v1_full need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_109960v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_109960v1_full:

### IGT changes ###

#### Warnings ####

* igt@gem_pread@exhaustion:
- shard-skl: [INCOMPLETE][1] ([i915#7244]) -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl2/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@perf@request:
- {shard-rkl}: NOTRUN -> [DMESG-FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-4/igt@i915_selftest@[email protected]

* igt@kms_cursor_legacy@single-move@all-pipes:
- {shard-rkl}: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@kms_cursor_legacy@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-1/igt@kms_cursor_legacy@[email protected]

Known issues
------------

Here are the changes found in Patchwork_109960v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [PASS][6] -> [SKIP][7] ([i915#4525]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb4/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb7/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk1/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-queues-priority:
- shard-iclb: [PASS][10] -> [INCOMPLETE][11] ([i915#6755])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb8/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb1/igt@[email protected]

* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl1/igt@[email protected]

* igt@gem_userptr_blits@readonly-unsync:
- shard-tglb: NOTRUN -> [SKIP][13] ([i915#3297])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-tglb8/igt@[email protected]

* igt@gem_workarounds@suspend-resume:
- shard-skl: [PASS][14] -> [INCOMPLETE][15] ([i915#7231] / [i915#7259])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl7/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl1/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-skl: [PASS][16] -> [WARN][17] ([i915#1804])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@i915_pm_rc6_residency@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl6/igt@i915_pm_rc6_residency@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [PASS][18] -> [DMESG-FAIL][19] ([i915#5334])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@i915_selftest@live@gt_heartbeat.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl6/igt@i915_selftest@live@gt_heartbeat.html

* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][20] ([i915#5286])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-tglb8/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-skl: NOTRUN -> [SKIP][21] ([fdo#109271]) +12 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl6/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglb: [PASS][22] -> [FAIL][23] ([i915#3743])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb5/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-tglb6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3886])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl7/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3886])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl7/igt@kms_ccs@pipe-c-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [fdo#111827]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl3/igt@[email protected]

* igt@kms_content_protection@legacy@pipe-a-dp-1:
- shard-apl: NOTRUN -> [INCOMPLETE][27] ([i915#1319] / [i915#7121] / [i915#7173])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl1/igt@kms_content_protection@[email protected]

* igt@kms_cursor_crc@cursor-sliding-32x32:
- shard-apl: NOTRUN -> [SKIP][28] ([fdo#109271]) +73 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl3/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][29] -> [INCOMPLETE][30] ([i915#180] / [i915#4939])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl3/igt@[email protected]

* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-tglb: NOTRUN -> [SKIP][31] ([fdo#109274] / [fdo#111825] / [i915#3637])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-tglb8/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [PASS][32] -> [FAIL][33] ([i915#79])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@kms_flip@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][34] -> [FAIL][35] ([i915#79])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@kms_flip@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][36] -> [DMESG-WARN][37] ([i915#180]) +3 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl7/igt@kms_flip@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl6/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][38] ([i915#2587] / [i915#2672]) +4 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb1/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][39] ([i915#3555])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][40] ([i915#2672]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#2672] / [i915#3555])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#6497])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html

* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: NOTRUN -> [DMESG-WARN][43] ([i915#180])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl3/igt@kms_hdr@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#658]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl3/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#658])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl6/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][46] -> [SKIP][47] ([fdo#109441])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb1/igt@kms_psr@psr2_no_drrs.html

* igt@kms_vblank@pipe-a-query-forked:
- shard-snb: [PASS][48] -> [SKIP][49] ([fdo#109271])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-snb4/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-snb7/igt@[email protected]

* igt@perf_pmu@module-unload:
- shard-skl: [PASS][50] -> [DMESG-WARN][51] ([i915#1982])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl6/igt@[email protected]

* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#2994]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl1/igt@[email protected]

* igt@sysfs_clients@fair-3:
- shard-skl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#2994])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl4/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][54] ([i915#2842]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb8/igt@gem_exec_fair@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-tglb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][56] ([i915#2842]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@gem_exec_fair@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][58] ([i915#2842]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk6/igt@gem_exec_fair@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-gtt-active:
- {shard-rkl}: [SKIP][60] ([i915#3281]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-5/igt@[email protected]

* igt@gem_pread@uncached:
- {shard-rkl}: [SKIP][62] ([i915#3282]) -> [PASS][63] +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-5/igt@[email protected]

* igt@gen9_exec_parse@bb-start-cmd:
- {shard-rkl}: [SKIP][64] ([i915#2527]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-5/igt@[email protected]

* igt@i915_pm_backlight@fade:
- {shard-rkl}: [SKIP][66] ([i915#3012]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-6/igt@[email protected]

* igt@i915_pm_rpm@fences-dpms:
- {shard-rkl}: [SKIP][68] ([i915#1849]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-6/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-rkl}: [SKIP][70] ([i915#1397]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-6/igt@[email protected]

* igt@i915_pm_rpm@pm-tiling:
- {shard-rkl}: [SKIP][72] ([fdo#109308]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-6/igt@[email protected]

* igt@i915_selftest@live@gem_contexts:
- shard-glk: [DMESG-FAIL][74] ([i915#7270]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk2/igt@i915_selftest@live@gem_contexts.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-glk8/igt@i915_selftest@live@gem_contexts.html

* igt@i915_suspend@fence-restore-untiled:
- {shard-rkl}: [FAIL][76] ([fdo#103375]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-4/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-1/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- {shard-rkl}: [SKIP][78] ([i915#1845] / [i915#4098]) -> [PASS][79] +10 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html

* igt@kms_cursor_crc@cursor-sliding-256x256@pipe-a-hdmi-a-1:
- shard-glk: [DMESG-WARN][80] ([i915#118]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk8/igt@kms_cursor_crc@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-glk2/igt@kms_cursor_crc@[email protected]

* igt@kms_cursor_crc@cursor-suspend@pipe-b-edp-1:
- shard-tglb: [INCOMPLETE][82] -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb1/igt@kms_cursor_crc@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-tglb8/igt@kms_cursor_crc@[email protected]

* igt@kms_cursor_legacy@short-flip-before-cursor@atomic-transitions-varying-size:
- shard-skl: [FAIL][84] ([i915#3927]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl9/igt@kms_cursor_legacy@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl9/igt@kms_cursor_legacy@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [FAIL][86] ([i915#79]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk2/igt@kms_flip@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-glk8/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][88] ([i915#79]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl1/igt@kms_flip@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-skl: [FAIL][90] ([i915#2122]) -> [PASS][91] +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-skl2/igt@kms_flip@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-skl6/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [DMESG-WARN][92] ([i915#180]) -> [PASS][93] +2 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-plflip-blt:
- {shard-rkl}: [SKIP][94] ([i915#1849] / [i915#4098]) -> [PASS][95] +6 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-6/igt@[email protected]

* igt@kms_plane@pixel-format@pipe-b-planes:
- {shard-rkl}: [SKIP][96] ([i915#1849] / [i915#3558]) -> [PASS][97] +1 similar issue
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-5/igt@kms_plane@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-6/igt@kms_plane@[email protected]

* igt@kms_plane_lowres@tiling-yf@pipe-a-hdmi-a-1:
- shard-glk: [FAIL][98] -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk6/igt@kms_plane_lowres@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-glk3/igt@kms_plane_lowres@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][100] ([i915#5235]) -> [PASS][101] +2 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb5/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][102] ([fdo#109441]) -> [PASS][103] +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb5/igt@kms_psr@psr2_primary_page_flip.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

* igt@perf@polling-parameterized:
- shard-tglb: [FAIL][104] ([i915#5639]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb3/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-tglb5/igt@[email protected]

* igt@prime_vgem@basic-read:
- {shard-rkl}: [SKIP][106] ([fdo#109295] / [i915#3291] / [i915#3708]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-rkl-1/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-rkl-5/igt@[email protected]

#### Warnings ####

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [FAIL][108] ([i915#6117]) -> [SKIP][109] ([i915#4525])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb5/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-apl: [WARN][110] ([i915#2658]) -> [INCOMPLETE][111] ([i915#7268])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl1/igt@[email protected]
- shard-glk: [INCOMPLETE][112] -> [WARN][113] ([i915#2658])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk9/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-glk5/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: [INCOMPLETE][114] ([i915#7248]) -> [WARN][115] ([i915#2658])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-tglb7/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-tglb2/igt@[email protected]
- shard-glk: [INCOMPLETE][116] -> [INCOMPLETE][117] ([i915#7296])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-glk3/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-glk9/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][118] ([i915#588]) -> [SKIP][119] ([i915#658])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb1/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][120] ([i915#658]) -> [SKIP][121] ([i915#2920])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb5/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][122] ([i915#2920]) -> [SKIP][123] ([fdo#111068] / [i915#658]) +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb2/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb5/igt@[email protected]

* igt@runner@aborted:
- shard-apl: ([FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142]) ([i915#180] / [i915#3002] / [i915#4312])
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl2/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl1/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl8/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-apl6/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl3/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl6/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl3/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl2/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl6/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl1/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl8/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl2/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl6/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-apl3/igt@[email protected]
- shard-iclb: ([FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149]) ([i915#3002] / [i915#4312] / [i915#7300]) -> ([FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156]) ([i915#3002] / [i915#4312])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb6/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb7/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb6/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb5/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb4/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb4/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12267/shard-iclb1/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb3/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb6/igt@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb2/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb4/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb6/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb2/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/shard-iclb2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3927]: https://gitlab.freedesktop.org/drm/intel/issues/3927
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7121]: https://gitlab.freedesktop.org/drm/intel/issues/7121
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7231]: https://gitlab.freedesktop.org/drm/intel/issues/7231
[i915#7244]: https://gitlab.freedesktop.org/drm/intel/issues/7244
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7259]: https://gitlab.freedesktop.org/drm/intel/issues/7259
[i915#7268]: https://gitlab.freedesktop.org/drm/intel/issues/7268
[i915#7270]: https://gitlab.freedesktop.org/drm/intel/issues/7270
[i915#7296]: https://gitlab.freedesktop.org/drm/intel/issues/7296
[i915#7300]: https://gitlab.freedesktop.org/drm/intel/issues/7300
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* Linux: CI_DRM_12267 -> Patchwork_109960v1

CI-20190529: 20190529
CI_DRM_12267: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7020: 05b7eaf9ade2216d17c069c89439015757ee25f7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109960v1: 1e08742713bca00944d4d38d1080a14dbfa649dc @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109960v1/index.html

#4 lore raw
In reply to Matthew Auld
Quoted 46 lines · Matthew Auld

We rely on page_sizes.sg in setup_scratch_page() reporting the correct value if the underlying sgl is not contiguous, however in get_pages_internal() we are only looking at the layout of the created pages when calculating the sg_page_sizes, and not the final sgl, which could in theory be completely different. In such a situation we might incorrectly think we have a 64K scratch page, when it is actually only 4K or similar split over multiple non-contiguous entries, which could lead to broken behaviour when touching the scratch space within the padding of a 64K GTT page-table. Like we already do for other backends, switch over to calling i915_sg_dma_sizes() after mapping the pages.

---
  drivers/gpu/drm/i915/gem/i915_gem_internal.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_internal.c +0 -3
index c698f95af15f..301cfb127c4c 100644
@@ -36,7 +36,6 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
  	struct drm_i915_private *i915 = to_i915(obj->base.dev);
  	struct sg_table *st;
  	struct scatterlist *sg;
-	unsigned int sg_page_sizes;
  	unsigned int npages;
  	int max_order;
  	gfp_t gfp;
@@ -75,7 +74,6 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 
  	sg = st->sgl;
  	st->nents = 0;
-	sg_page_sizes = 0;
 
  	do {
  		int order = min(fls(npages) - 1, max_order);
@@ -94,7 +92,6 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
  		} while (1);
 
  		sg_set_page(sg, page, PAGE_SIZE << order, 0);
-		sg_page_sizes |= PAGE_SIZE << order;
  		st->nents++;
 
  		npages -= 1 << order;

drivers/gpu/drm/i915/gem/i915_gem_internal.c static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj) · line 116

Quoted 5 lines
drivers/gpu/drm/i915/gem/i915_gem_internal.c +1 -1
@@ -116,7 +113,7 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
  		goto err;
  	}
 
-	__i915_gem_object_set_pages(obj, st, sg_page_sizes);
+	__i915_gem_object_set_pages(obj, st, i915_sg_dma_sizes(st->sgl));

Should __i915_gem_object_set_pages just do that internally? I mean are there callers which call it before DMA mapping and legitimately pass in st_page_sizes different from what i915_sg_dma_sizes() would find?

Regards,

Tvrtko

Quoted 3 lines
drivers/gpu/drm/i915/gem/i915_gem_internal.c +0 -0
  	return 0;
 
Reviewed-by on v1 1/1
#5 lore raw
In reply to Matthew Auld

Hi Matthew,

Quoted 11 lines · Matthew Auld

We rely on page_sizes.sg in setup_scratch_page() reporting the correct value if the underlying sgl is not contiguous, however in get_pages_internal() we are only looking at the layout of the created pages when calculating the sg_page_sizes, and not the final sgl, which could in theory be completely different. In such a situation we might incorrectly think we have a 64K scratch page, when it is actually only 4K or similar split over multiple non-contiguous entries, which could lead to broken behaviour when touching the scratch space within the padding of a 64K GTT page-table. Like we already do for other backends, switch over to calling i915_sg_dma_sizes() after mapping the pages.

Quoted 2 lines

The patch looks OK, but it still does not solve dmar errors in hugepages test [1]. [1]: https://gitlab.freedesktop.org/drm/intel/-/issues/5278

Anyway:

Regards
Andrzej

Quoted 41 lines
---
  drivers/gpu/drm/i915/gem/i915_gem_internal.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_internal.c +1 -4
index c698f95af15f..301cfb127c4c 100644
@@ -36,7 +36,6 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
  	struct drm_i915_private *i915 = to_i915(obj->base.dev);
  	struct sg_table *st;
  	struct scatterlist *sg;
-	unsigned int sg_page_sizes;
  	unsigned int npages;
  	int max_order;
  	gfp_t gfp;
@@ -75,7 +74,6 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
 
  	sg = st->sgl;
  	st->nents = 0;
-	sg_page_sizes = 0;
 
  	do {
  		int order = min(fls(npages) - 1, max_order);
@@ -94,7 +92,6 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
  		} while (1);
 
  		sg_set_page(sg, page, PAGE_SIZE << order, 0);
-		sg_page_sizes |= PAGE_SIZE << order;
  		st->nents++;
 
  		npages -= 1 << order;
@@ -116,7 +113,7 @@ static int i915_gem_object_get_pages_internal(struct drm_i915_gem_object *obj)
  		goto err;
  	}
 
-	__i915_gem_object_set_pages(obj, st, sg_page_sizes);
+	__i915_gem_object_set_pages(obj, st, i915_sg_dma_sizes(st->sgl));
 
  	return 0;