Skip to contentSkip to conversation

drm/nouveau/iccsense: do not use assignment in if condition

PATCH New [email protected] 1 participant 1 message Jul 10, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/nouveau/iccsense: do not use assignment in if condition

checkpatch.pl does not like assignment in if condition

---
 drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c +0 -0
index 8f0ccd3664eb..2428f3d6e477 100644
@@ -322,7 +322,8 @@ int
 nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type 

type, int inst,
struct nvkm_iccsense **iccsense)
{

-    if (!(*iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL)))
+    *iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL);
+    if (!*iccsense)
         return -ENOMEM;
     INIT_LIST_HEAD(&(*iccsense)->sensors);
     INIT_LIST_HEAD(&(*iccsense)->rails);