Skip to contentSkip to conversation

xperm_rules: add two notes

RFC PATCH In review Christian Göttsche 3 participants 3 messages Sep 4, 2020 – Sep 18, 2020 SELinux security module

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 xperm_rules: add two notes

---
I *hope* the note number 4 is actually correct!?

 src/xperm_rules.md | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
src/xperm_rules.md +7 -1
index 7f8744b..1e1dfff 100644
@@ -1,6 +1,6 @@
 # Extended Access Vector Rules
 
-There are three extended AV rules implemented from Policy version 30
+There are four extended AV rules implemented from Policy version 30
 with the target platform 'selinux' that expand the permission sets from
 a fixed 32 bits to permission sets in 256 bit increments: *allowxperm*,
 *dontauditxperm*, *auditallowxperm* and *neverallowxperm*.
@@ -127,6 +127,12 @@ Notes:
     class/permission is required.
 3.  To deny all ioctl requests for a specific source/target/class the
     *xperm_set* should be set to *0* or *0x0*.
+4.  From the 32-bit ioctl request parameter value only the least significant
+    16 bits are used. Thus *0x8927*, *0x00008927* and *0xabcd8927*
+    are the same extended permission.
+5.  To decode a numeric ioctl request parameter into the corresponding
+    textual identifier see
+    <https://www.kernel.org/doc/html/latest/userspace-api/ioctl/ioctl-decoding.html>
 
 <!-- %CUTHERE% -->
 
Signature · 1 line
2.28.0
#1 lore raw
Quoted 3 lines · Christian Göttsche

---
I *hope* the note number 4 is actually correct!?

It is correct as noted in [1]. checkpolicy allows 0x1234ABCD and just uses ABCD whereas CIL only allows 0xABCD.

[1]
https://lore.kernel.org/selinux/[email protected]/

src/xperm_rules.md line 3

Quoted 13 lines
 src/xperm_rules.md | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
src/xperm_rules.md +1 -1
index 7f8744b..1e1dfff 100644
@@ -1,6 +1,6 @@
 # Extended Access Vector Rules
 
-There are three extended AV rules implemented from Policy version 30
+There are four extended AV rules implemented from Policy version 30

Yes I think they all came under policy 30. It's just that neverallowxperm was added a few months later.

Quoted 23 lines
src/xperm_rules.md +0 -0
 with the target platform 'selinux' that expand the permission sets

from
a fixed 32 bits to permission sets in 256 bit increments:
*allowxperm*,
*dontauditxperm*, *auditallowxperm* and *neverallowxperm*.

src/xperm_rules.md +0 -0
@@ -127,6 +127,12 @@ Notes:
     class/permission is required.
 3.  To deny all ioctl requests for a specific source/target/class

the

     *xperm_set* should be set to *0* or *0x0*.

+4. From the 32-bit ioctl request parameter value only the least significant

src/xperm_rules.md +3 -0
+    16 bits are used. Thus *0x8927*, *0x00008927* and *0xabcd8927*
+    are the same extended permission.
+5.  To decode a numeric ioctl request parameter into the

corresponding

src/xperm_rules.md +2 -0
+    textual identifier see
+    <

https://www.kernel.org/doc/html/latest/userspace-api/ioctl/ioctl-decoding.html

Quoted 1 line

<!-- %CUTHERE% -->

maintainer
#2 lore raw
In reply to Christian Göttsche
Quoted 7 lines · Christian Göttsche

---
I *hope* the note number 4 is actually correct!?

 src/xperm_rules.md | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Hi Christian, I'm sorry for the delay but this fix is now merged. I did have to merge it by hand so please double check to make sure I didn't mess it up (it looked good to me in all three formats).

Quoted 27 lines
src/xperm_rules.md +7 -2
index 7f8744b..1e1dfff 100644
@@ -1,6 +1,6 @@
 # Extended Access Vector Rules
 
-There are three extended AV rules implemented from Policy version 30
+There are four extended AV rules implemented from Policy version 30
 with the target platform 'selinux' that expand the permission sets from
 a fixed 32 bits to permission sets in 256 bit increments: *allowxperm*,
 *dontauditxperm*, *auditallowxperm* and *neverallowxperm*.
@@ -127,6 +127,12 @@ Notes:
     class/permission is required.
 3.  To deny all ioctl requests for a specific source/target/class the
     *xperm_set* should be set to *0* or *0x0*.
+4.  From the 32-bit ioctl request parameter value only the least significant
+    16 bits are used. Thus *0x8927*, *0x00008927* and *0xabcd8927*
+    are the same extended permission.
+5.  To decode a numeric ioctl request parameter into the corresponding
+    textual identifier see
+    <https://www.kernel.org/doc/html/latest/userspace-api/ioctl/ioctl-decoding.html>
 
 <!-- %CUTHERE% -->
 
--

2.28.0

Signature · 2 lines
paul moore
www.paul-moore.com