Skip to contentSkip to conversation

TL16C752B DUART: MCR_OUT2 disables interrupts

DISCUSSION Shaun Jackman 2 participants 4 messages Jun 20, 2006

lore
Share & tools
lore
#0 lore raw

The datasheet I have for the TL16C752B labels the MCR_OUT1 bit as FIFO Rdy enable' and the MCR_OUT2 bit as IRQ enable'. The latter bit concerns me. The 8250.c driver sets MCR_OUT2 by default; however, if the user space clears MCR_OUT2 (through an ioctl TIOCMSET operation or similar), it seems to me that interrupts for that UART will stop working. Can someone confirm my suspicion?

I'd expect that clearing/setting the OUT1 and OUT2 pins from user space should be an innocuous operation. Disabling interrupts is a fairly nasty side effect.

Please cc me in your reply. Cheers,
Shaun

#1 lore raw
Quoted 10 lines · Shaun Jackman

The datasheet I have for the TL16C752B labels the MCR_OUT1 bit as FIFO Rdy enable' and the MCR_OUT2 bit as IRQ enable'. The latter bit concerns me. The 8250.c driver sets MCR_OUT2 by default; however, if the user space clears MCR_OUT2 (through an ioctl TIOCMSET operation or similar), it seems to me that interrupts for that UART will stop working. Can someone confirm my suspicion?

I'd expect that clearing/setting the OUT1 and OUT2 pins from user space should be an innocuous operation. Disabling interrupts is a fairly nasty side effect.

The old 16550 OUT2 output (MCR:3) used to be a truly independant control output that was commonly used with an external gate to connect/disconnect the interrupt request to the ISA bus.

Reading the TL16C752B datasheet, it seems pretty clear that this gating is performed internal to the device. MCR:3 is no longer an independant, general purpose I/O.

The result is the same though: If you dink around with MCR:3 you could disable interrupts in either case.

So I don't see this as more or less of a problem than other 16550 type devices.

Signature · 2 lines
Paul Fulghum
Microgate Systems, Ltd.
#2 lore raw

On 6/20/06, Paul Fulghum <[email protected]>

Quoted 9 lines

The old 16550 OUT2 output (MCR:3) used to be a truly independant control output that was commonly used with an external gate to connect/disconnect the interrupt request to the ISA bus.

Reading the TL16C752B datasheet, it seems pretty clear that this gating is performed internal to the device. MCR:3 is no longer an independant, general purpose I/O.

Quoted 5 lines

The result is the same though: If you dink around with MCR:3 you could disable interrupts in either case.

So I don't see this as more or less of a problem than other 16550 type devices.

I didn't know of this historic use of the OUT2 pin to disable interrupts. I'll put OUT2 on my list of things not to muck with. Is there any similar historic use of OUT1?

Cheers,
Shaun

#3 lore raw
Quoted 4 lines · Shaun Jackman

On 6/20/06, Paul Fulghum <[email protected]>
I didn't know of this historic use of the OUT2 pin to disable interrupts. I'll put OUT2 on my list of things not to muck with. Is there any similar historic use of OUT1?

Not that I'm aware of. All of the old designs I've seen left that signal unconnected.

Signature · 2 lines
Paul Fulghum
Microgate Systems, Ltd.