Skip to contentSkip to conversation

au0828: allow higher speeds

PATCH In review Oliver Neukum 2 participants 4 messages May 17, 2022 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 au0828: allow higher speeds

This should be taken as a minimum speed.

---
 drivers/media/usb/au0828/au0828-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/usb/au0828/au0828-core.c +1 -1
index caefac07af92..963ed0630121 100644
@@ -669,7 +669,7 @@ static int au0828_usb_probe(struct usb_interface *interface,
 	 * video stream wouldn't likely work, since 12 Mbps is generally
 	 * not enough even for most Digital TV streams.
 	 */
-	if (usbdev->speed != USB_SPEED_HIGH && disable_usb_speed_check == 0) {
+	if (usbdev->speed < USB_SPEED_HIGH && disable_usb_speed_check == 0) {
 		pr_err("au0828: Device initialization failed.\n");
 		pr_err("au0828: Device must be connected to a high-speed USB 2.0 port.\n");
 		return -ENODEV;
Signature · 1 line
2.35.3
#1 lore raw
Quoted 2 lines · Oliver Neukum

This should be taken as a minimum speed.

Did you find this by testing or by reviewing the code? What does this bug look like to the user?

Presumably there is a redit page webpage where someone discovered the bug and instead of reporting it to us they just told everyone to set the module parameter disable_usb_speed_check=1?

regards,
dan carpenter

#2 lore raw
Quoted 4 lines · Dan Carpenter
Quoted 2 lines · Oliver Neukum

This should be taken as a minimum speed.

Did you find this by testing or by reviewing the code? What does this

Review.

Quoted 1 line

bug look like to the user?

The device will refuse to work if you connect it via a USB 3.0 hub to XHCI

Quoted 4 lines

Presumably there is a redit page webpage where someone discovered the bug and instead of reporting it to us they just told everyone to set the module parameter disable_usb_speed_check=1?

Now, that you mention it, it isn't on reddit, but yes, someone's blog.

    Regards
        Oliver

#3 lore raw
Quoted 11 lines · Oliver Neukum
Quoted 4 lines · Dan Carpenter
Quoted 2 lines · Oliver Neukum

This should be taken as a minimum speed.

Did you find this by testing or by reviewing the code? What does this

Review.

Quoted 1 line

bug look like to the user?

The device will refuse to work if you connect it via a USB 3.0 hub to XHCI

Please add that to the commit message. It really does help.

regards,
dan carpenter