Skip to contentSkip to conversation

r8169: remove MAC workaround in rtl8168e_2_hw_phy_config

PATCH Applied Heiner Kallweit 2 participants 2 messages Dec 21, 2019 – Dec 25, 2019

Subsystems (3)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH 1/1 r8169: remove MAC workaround in rtl8168e_2_hw_phy_config

Due to recent changes we don't need the call to rtl_rar_exgmac_set() and longer at this place. It's called from rtl_rar_set() which is called in rtl_init_mac_address() and rtl8169_resume().

---
 drivers/net/ethernet/realtek/r8169_main.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/ethernet/realtek/r8169_main.c +0 -3
index c845a5850..38a09b5ee 100644
@@ -2961,9 +2961,6 @@ static void rtl8168e_2_hw_phy_config(struct rtl8169_private *tp)
 	rtl_writephy(tp, 0x1f, 0x0005);
 	rtl_w0w1_phy(tp, 0x01, 0x0100, 0x0000);
 	rtl_writephy(tp, 0x1f, 0x0000);
-
-	/* Broken BIOS workaround: feed GigaMAC registers with MAC address. */
-	rtl_rar_exgmac_set(tp, tp->dev->dev_addr);
 }
 
 static void rtl8168f_hw_phy_config(struct rtl8169_private *tp)
Signature · 1 line
2.24.1
maintainer Applied
#1 lore raw

From: Heiner Kallweit <[email protected]>
Date: Sat, 21 Dec 2019 14:11:08 +0100

Quoted 5 lines

Due to recent changes we don't need the call to rtl_rar_exgmac_set() and longer at this place. It's called from rtl_rar_set() which is called in rtl_init_mac_address() and rtl8169_resume().

Applied.