Skip to contentSkip to conversation

arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

PATCH New Nico Becker 4 participants 10 messages Jun 10, 2020 – Jun 15, 2020 3 messages not in the archive Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

arch/arm/dts/socfpga.dtsi +0 -1
index eda558f2fe..c2173416c7 100644
@@ -719,7 +719,6 @@
 ???? ??? ??? arm,data-latency = <2 1 1>;
 ???? ??? ??? prefetch-data = <1>;
 ???? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ???? ??? ??? arm,double-linefill = <1>;
 ???? ??? ??? arm,double-linefill-incr = <0>;
 ???? ??? ??? arm,double-linefill-wrap = <1>;
#1 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Quoted 16 lines · Nico Becker

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

arch/arm/dts/socfpga.dtsi +0 -0
index eda558f2fe..c2173416c7 100644

arch/arm/dts/socfpga.dtsi line 724

Quoted 7 lines
arch/arm/dts/socfpga.dtsi +0 -1
@@ -719,7 +719,6 @@
 ???? ??? ??? arm,data-latency = <2 1 1>;
 ???? ??? ??? prefetch-data = <1>;
 ???? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ???? ??? ??? arm,double-linefill = <1>;
 ???? ??? ??? arm,double-linefill-incr = <0>;
 ???? ??? ??? arm,double-linefill-wrap = <1>;

Do you use latest u-boot/master or some older version ? Which one?

#2 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Am 10.06.2020 um 15:19 schrieb Marek Vasut:

Quoted 11 lines · Nico Becker
Quoted 10 lines

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

Quoted 14 lines

arch/arm/dts/socfpga.dtsi line 724

Quoted 13 lines
arch/arm/dts/socfpga.dtsi +0 -1
index eda558f2fe..c2173416c7 100644
@@ -719,7 +719,6 @@
 ???? ??? ??? arm,data-latency = <2 1 1>;
 ???? ??? ??? prefetch-data = <1>;
 ???? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ???? ??? ??? arm,double-linefill = <1>;
 ???? ??? ??? arm,double-linefill-incr = <0>;
 ???? ??? ??? arm,double-linefill-wrap = <1>;

Do you use latest u-boot/master or some older version ? Which one?

sorry, i forget it.

i use v2020.01

#3 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Quoted 27 lines · Nico Becker

Am 10.06.2020 um 15:19 schrieb Marek Vasut:

Quoted 11 lines · Nico Becker
Quoted 10 lines

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

Quoted 14 lines

arch/arm/dts/socfpga.dtsi line 724

Quoted 13 lines
arch/arm/dts/socfpga.dtsi +0 -1
index eda558f2fe..c2173416c7 100644
@@ -719,7 +719,6 @@
 ????? ??? ??? arm,data-latency = <2 1 1>;
 ????? ??? ??? prefetch-data = <1>;
 ????? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ????? ??? ??? arm,double-linefill = <1>;
 ????? ??? ??? arm,double-linefill-incr = <0>;
 ????? ??? ??? arm,double-linefill-wrap = <1>;

Do you use latest u-boot/master or some older version ? Which one?

Quoted 3 lines

sorry, i forget it.

i use v2020.01

Should be OK I think. Hmmmmm, I suspect this is another fun with the ACTLR/CPACR registers, like 937db7188e3a5ab8f802eff9b57854189379667a . Ley, any ideas ?

#4 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Quoted 28 lines · Marek Vasut
Quoted 27 lines · Nico Becker

Am 10.06.2020 um 15:19 schrieb Marek Vasut:

Quoted 25 lines · Nico Becker
Quoted 16 lines

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

arch/arm/dts/socfpga.dtsi +0 -0
index eda558f2fe..c2173416c7 100644

arch/arm/dts/socfpga.dtsi line 724

Quoted 7 lines
arch/arm/dts/socfpga.dtsi +0 -1
@@ -719,7 +719,6 @@
 ????? ??? ??? arm,data-latency = <2 1 1>;
 ????? ??? ??? prefetch-data = <1>;
 ????? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ????? ??? ??? arm,double-linefill = <1>;
 ????? ??? ??? arm,double-linefill-incr = <0>;
 ????? ??? ??? arm,double-linefill-wrap = <1>;

Do you use latest u-boot/master or some older version ? Which one?

Quoted 8 lines
Quoted 3 lines

sorry, i forget it.

i use v2020.01

Should be OK I think. Hmmmmm, I suspect this is another fun with the ACTLR/CPACR registers, like 937db7188e3a5ab8f802eff9b57854189379667a . Ley, any ideas ?

I just tested with

2020.07-rc4-00022-gbe79009f3b along with linux v5.7,

and I no longer see the error.

Dinh

#5 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Quoted 50 lines

-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Thursday, June 11, 2020 2:55 AM
To: Marek Vasut <[email protected]>; Nico Becker <u-boot@ic- automation.de>; u-boot at lists.denx.de
Cc: simon.k.r.goldschmidt at gmail.com; Tan, Ley Foon <[email protected]>
Subject: Re: [PATCH] arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Quoted 28 lines · Marek Vasut
Quoted 27 lines · Nico Becker

Am 10.06.2020 um 15:19 schrieb Marek Vasut:

Quoted 25 lines · Nico Becker
Quoted 16 lines

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

arch/arm/dts/socfpga.dtsi +0 -0
index eda558f2fe..c2173416c7 100644

arch/arm/dts/socfpga.dtsi line 724

Quoted 7 lines
arch/arm/dts/socfpga.dtsi +0 -1
@@ -719,7 +719,6 @@
 ????? ??? ??? arm,data-latency = <2 1 1>;
 ????? ??? ??? prefetch-data = <1>;
 ????? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ????? ??? ??? arm,double-linefill = <1>;
 ????? ??? ??? arm,double-linefill-incr = <0>;
 ????? ??? ??? arm,double-linefill-wrap = <1>;

Do you use latest u-boot/master or some older version ? Which one?

Quoted 6 lines
Quoted 3 lines

sorry, i forget it.

i use v2020.01

Should be OK I think. Hmmmmm, I suspect this is another fun with the ACTLR/CPACR registers, like

937db7188e3a5ab8f802eff9b57854189379667a .

Quoted 9 lines
Quoted 2 lines

Ley, any ideas ?

I just tested with

2020.07-rc4-00022-gbe79009f3b along with linux v5.7,

and I no longer see the error.

Yes, I also just tested 2020.04 uboot and 5.4.23-lts kernel, also didn't see this error. What kernel version you are using?

Regards
Ley Foon

#6 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Am 11.06.2020 um 03:51 schrieb Tan, Ley Foon:

Quoted 53 lines
Quoted 53 lines

-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Thursday, June 11, 2020 2:55 AM
To: Marek Vasut <[email protected]>; Nico Becker <u-boot@ic- automation.de>; u-boot at lists.denx.de
Cc: simon.k.r.goldschmidt at gmail.com; Tan, Ley Foon <[email protected]>
Subject: Re: [PATCH] arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Quoted 27 lines · Marek Vasut
Quoted 26 lines · Nico Becker

Am 10.06.2020 um 15:19 schrieb Marek Vasut:

Quoted 25 lines · Nico Becker
Quoted 16 lines

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

arch/arm/dts/socfpga.dtsi +0 -0
index eda558f2fe..c2173416c7 100644

arch/arm/dts/socfpga.dtsi line 724

Quoted 7 lines
arch/arm/dts/socfpga.dtsi +0 -1
@@ -719,7 +719,6 @@
 ????? ??? ??? arm,data-latency = <2 1 1>;
 ????? ??? ??? prefetch-data = <1>;
 ????? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ????? ??? ??? arm,double-linefill = <1>;
 ????? ??? ??? arm,double-linefill-incr = <0>;
 ????? ??? ??? arm,double-linefill-wrap = <1>;

Do you use latest u-boot/master or some older version ? Which one?

Quoted 5 lines
Quoted 3 lines

sorry, i forget it.

i use v2020.01

Should be OK I think. Hmmmmm, I suspect this is another fun with the ACTLR/CPACR registers, like

937db7188e3a5ab8f802eff9b57854189379667a .

Quoted 2 lines

Ley, any ideas ?

I just tested with

2020.07-rc4-00022-gbe79009f3b along with linux v5.7,

Quoted 7 lines
Quoted 2 lines

and I no longer see the error.

Yes, I also just tested 2020.04 uboot and 5.4.23-lts kernel, also didn't see this error. What kernel version you are using?

Regards
Ley Foon

hello,
i use kernel 4.14.126-rt62-ltsi.

greetings

#7 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Am 12.06.2020 um 07:51 schrieb Nico Becker:

Quoted 61 lines

Am 11.06.2020 um 03:51 schrieb Tan, Ley Foon:

Quoted 60 lines
Quoted 47 lines

-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Thursday, June 11, 2020 2:55 AM
To: Marek Vasut <[email protected]>; Nico Becker <u-boot@ic- automation.de>; u-boot at lists.denx.de
Cc: simon.k.r.goldschmidt at gmail.com; Tan, Ley Foon <[email protected]>
Subject: Re: [PATCH] arm: dts: socfpga: l2c-310 full line of zeros error
@kernel boot

Quoted 27 lines · Marek Vasut
Quoted 26 lines · Nico Becker

Am 10.06.2020 um 15:19 schrieb Marek Vasut:

Quoted 25 lines · Nico Becker
Quoted 16 lines

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

arch/arm/dts/socfpga.dtsi +0 -0
index eda558f2fe..c2173416c7 100644

arch/arm/dts/socfpga.dtsi line 724

Quoted 7 lines
arch/arm/dts/socfpga.dtsi +0 -1
@@ -719,7 +719,6 @@
 ?????? ??? ??? arm,data-latency = <2 1 1>;
 ?????? ??? ??? prefetch-data = <1>;
 ?????? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ?????? ??? ??? arm,double-linefill = <1>;
 ?????? ??? ??? arm,double-linefill-incr = <0>;
 ?????? ??? ??? arm,double-linefill-wrap = <1>;

Do you use latest u-boot/master or some older version ? Which one?

Quoted 5 lines
Quoted 3 lines

sorry, i forget it.

i use v2020.01

Should be OK I think. Hmmmmm, I suspect this is another fun with the ACTLR/CPACR registers, like

Quoted 9 lines

937db7188e3a5ab8f802eff9b57854189379667a .

Quoted 2 lines

Ley, any ideas ?

I just tested with

2020.07-rc4-00022-gbe79009f3b along with linux v5.7,

and I no longer see the error.

Yes, I also just tested 2020.04 uboot and 5.4.23-lts kernel, also didn't see this error.
What kernel version you are using?

Quoted 8 lines
Quoted 2 lines

Regards
Ley Foon

hello,
i use kernel 4.14.126-rt62-ltsi.

greetings

i try the u-boot version v2020.07-rc4 without the patch, and everything seems okay, no error at boot.
i ve no idea why the error at boot time is gone with the 2020.07-rc4 version.
does anyone have any idea why?
thanks, greetings

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#11 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Am 12.06.2020 um 22:27 schrieb Dinh Nguyen:

Quoted 92 lines · Marek Vasut
Quoted 70 lines · Nico Becker
Quoted 69 lines

Am 12.06.2020 um 07:51 schrieb Nico Becker:

Quoted 68 lines

Am 11.06.2020 um 03:51 schrieb Tan, Ley Foon:

Quoted 53 lines
Quoted 53 lines

-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Thursday, June 11, 2020 2:55 AM
To: Marek Vasut <[email protected]>; Nico Becker <u-boot@ic- automation.de>; u-boot at lists.denx.de
Cc: simon.k.r.goldschmidt at gmail.com; Tan, Ley Foon <[email protected]>
Subject: Re: [PATCH] arm: dts: socfpga: l2c-310 full line of zeros error
@kernel boot

Quoted 27 lines · Marek Vasut
Quoted 26 lines · Nico Becker

Am 10.06.2020 um 15:19 schrieb Marek Vasut:

Quoted 25 lines · Nico Becker
Quoted 16 lines

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

arch/arm/dts/socfpga.dtsi +0 -0
index eda558f2fe..c2173416c7 100644

arch/arm/dts/socfpga.dtsi line 724

Quoted 7 lines
arch/arm/dts/socfpga.dtsi +0 -1
@@ -719,7 +719,6 @@
 ?????? ??? ??? arm,data-latency = <2 1 1>;
 ?????? ??? ??? prefetch-data = <1>;
 ?????? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ?????? ??? ??? arm,double-linefill = <1>;
 ?????? ??? ??? arm,double-linefill-incr = <0>;
 ?????? ??? ??? arm,double-linefill-wrap = <1>;

Do you use latest u-boot/master or some older version ? Which one?

Quoted 5 lines
Quoted 3 lines

sorry, i forget it.

i use v2020.01

Should be OK I think. Hmmmmm, I suspect this is another fun with the ACTLR/CPACR registers, like

937db7188e3a5ab8f802eff9b57854189379667a .

Quoted 2 lines

Ley, any ideas ?

I just tested with

2020.07-rc4-00022-gbe79009f3b along with linux v5.7,

Quoted 8 lines
Quoted 2 lines

and I no longer see the error.

Yes, I also just tested 2020.04 uboot and 5.4.23-lts kernel, also didn't see this error.
What kernel version you are using?

Regards
Ley Foon

hello,
i use kernel 4.14.126-rt62-ltsi.

greetings

Quoted 9 lines
Quoted 6 lines

i try the u-boot version v2020.07-rc4 without the patch, and everything seems okay, no error at boot.
i ve no idea why the error at boot time is gone with the 2020.07-rc4 version.
does anyone have any idea why?
thanks, greetings

You can try git bisect between the two versions to find out which patch caused this.

This is the patch that fixed it:

commit f62782fb2999dd8109a3ffe9ee0a51e54ab034ab

Author: Ley Foon Tan <[email protected]>
Date:   Fri Apr 17 14:45:35 2020 +0800

cache: l2x0: Fix write to incorrect shared-override bit

The existing code write bit-0 for shared attribute override enable bit. It should be bit-22 based on cache controller specification [1].

Quoted 7 lines

[1]
http://infocenter.arm.com/help/topic/com.arm.doc.ddi0246f/DDI0246F_l2c310_r3p2_trm.pdf

Dinh

hello,
thanks a lot!
i try the git bisect method, i was? 13 builds away. next time i check first the changelog greetings

#12 lore raw

PATCH 1/1 arm: dts: socfpga: l2c-310 full line of zeros error @kernel boot

Quoted 104 lines · Nico Becker

Am 12.06.2020 um 22:27 schrieb Dinh Nguyen:

Quoted 103 lines · Marek Vasut
Quoted 74 lines · Nico Becker
Quoted 73 lines

Am 12.06.2020 um 07:51 schrieb Nico Becker:

Quoted 72 lines

Am 11.06.2020 um 03:51 schrieb Tan, Ley Foon:

Quoted 57 lines
Quoted 57 lines

-----Original Message-----
From: Dinh Nguyen <[email protected]>
Sent: Thursday, June 11, 2020 2:55 AM
To: Marek Vasut <[email protected]>; Nico Becker <u-boot@ic- automation.de>; u-boot at lists.denx.de
Cc: simon.k.r.goldschmidt at gmail.com; Tan, Ley Foon <[email protected]>
Subject: Re: [PATCH] arm: dts: socfpga: l2c-310 full line of zeros error
@kernel boot

Quoted 30 lines · Marek Vasut
Quoted 29 lines · Nico Becker

Am 10.06.2020 um 15:19 schrieb Marek Vasut:

Quoted 28 lines · Nico Becker
Quoted 18 lines

if i remove the arm,shared-override option in the dts file, the kernel boot without an error.
With the option the kernel boots with the following error:
dmesg --level=err
L2C-310: enabling full line of zeros but not enabled in Cortex-A9

i ve no idea why the parameter have an effect on that. i try several kernels, allays the same behavior.

arch/arm/dts/socfpga.dtsi +0 -0
index eda558f2fe..c2173416c7 100644

arch/arm/dts/socfpga.dtsi line 724

Quoted 7 lines
arch/arm/dts/socfpga.dtsi +0 -1
@@ -719,7 +719,6 @@
 ??????? ??? ??? arm,data-latency = <2 1 1>;
 ??????? ??? ??? prefetch-data = <1>;
 ??????? ??? ??? prefetch-instr = <1>;
-??? ??? ??? arm,shared-override;
 ??????? ??? ??? arm,double-linefill = <1>;
 ??????? ??? ??? arm,double-linefill-incr = <0>;
 ??????? ??? ??? arm,double-linefill-wrap = <1>;

Do you use latest u-boot/master or some older version ? Which one?

Quoted 6 lines
Quoted 3 lines

sorry, i forget it.

i use v2020.01

Should be OK I think. Hmmmmm, I suspect this is another fun with the
ACTLR/CPACR registers, like

937db7188e3a5ab8f802eff9b57854189379667a .

Quoted 2 lines

Ley, any ideas ?

I just tested with

2020.07-rc4-00022-gbe79009f3b along with linux v5.7,

Quoted 8 lines
Quoted 2 lines

and I no longer see the error.

Yes, I also just tested 2020.04 uboot and 5.4.23-lts kernel, also didn't see this error.
What kernel version you are using?

Regards
Ley Foon

hello,
i use kernel 4.14.126-rt62-ltsi.

greetings

Quoted 9 lines
Quoted 6 lines

i try the u-boot version v2020.07-rc4 without the patch, and everything seems okay, no error at boot.
i ve no idea why the error at boot time is gone with the 2020.07-rc4 version.
does anyone have any idea why?
thanks, greetings

You can try git bisect between the two versions to find out which patch caused this.

This is the patch that fixed it:

commit f62782fb2999dd8109a3ffe9ee0a51e54ab034ab
Author: Ley Foon Tan <[email protected]>
Date:?? Fri Apr 17 14:45:35 2020 +0800

???? cache: l2x0: Fix write to incorrect shared-override bit

???? The existing code write bit-0 for shared attribute override enable bit.
???? It should be bit-22 based on cache controller specification [1].

???? [1]
http://infocenter.arm.com/help/topic/com.arm.doc.ddi0246f/DDI0246F_l2c310_r3p2_trm.pdf

???? Signed-off-by: Ley Foon Tan <[email protected]>

Quoted 7 lines
Quoted 2 lines

Dinh

hello,
thanks a lot!
i try the git bisect method, i was? 13 builds away. next time i check first the changelog greetings

May want to check your usage of git bisect, it took me less than 10 builds.

Dinh