libbpf: fix realloc usage in bpf_core_find_cands
Subsystems (4)
PATCH 1/1 libbpf: fix realloc usage in bpf_core_find_cands
Fix bug requesting invalid size of reallocated array when constructing CO-RE relocation candidate list. This can cause problems if there are many potential candidates and a very fine-grained memory allocator bucket sizes are used.
--- tools/lib/bpf/libbpf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/lib/bpf/libbpf.c +3 -1
@@ -3870,7 +3870,9 @@ static struct ids_vec *bpf_core_find_cands(const struct btf *local_btf,if (strncmp (local_name, targ_name, local_essent_len) ==0 ) {pr_debug ("[%d] %s: found candidate [%d] %s\n" , local_type_id, local_name, i, targ_name); - new_ids =realloc (cand_ids->data, cand_ids->len +1 ); + new_ids =reallocarray (cand_ids->data, + cand_ids->len +1 , +sizeof (*cand_ids->data));if (!new_ids) { err = -ENOMEM ; goto err_out;
Signature · 1 line
2.17.1
Quoted 7 lines · Andrii Nakryiko
Fix bug requesting invalid size of reallocated array when constructing CO-RE relocation candidate list. This can cause problems if there are many potential candidates and a very fine-grained memory allocator bucket sizes are used.
Fixes ddc7c3042614 ("libbpf: implement BPF CO-RE offset relocation algorithm")Reported-by William Smith <[email protected]>Signed-off-by Andrii Nakryiko <[email protected]>
Quoted 7 lines · Andrii Nakryiko
Fix bug requesting invalid size of reallocated array when constructing CO-RE relocation candidate list. This can cause problems if there are many potential candidates and a very fine-grained memory allocator bucket sizes are used.
Fixes ddc7c3042614 ("libbpf: implement BPF CO-RE offset relocation algorithm")Reported-by William Smith <[email protected]>Signed-off-by Andrii Nakryiko <[email protected]>
Applied, thanks!