Skip to contentSkip to conversation

hppa: Delete unused hppa_cpu_list() function

PATCH Superseded Eduardo Habkost 3 participants 3 messages Apr 18, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hppa: Delete unused hppa_cpu_list() function

hppa_cpu_list() is dead code and is never called. Delete it.

Cc Richard Henderson <[email protected]>
---
 target/hppa/cpu.c | 22 ----------------------
 1 file changed, 22 deletions(-)
target/hppa/cpu.c +0 -22
index 00bf444620..b3b1826209 100644
@@ -110,28 +110,6 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error **errp)
 #endif
 }
 
-static void hppa_cpu_list_entry(gpointer data, gpointer user_data)
-{
-    ObjectClass *oc = data;
-    CPUListState *s = user_data;
-
-    (*s->cpu_fprintf)(s->file, "  %s\n", object_class_get_name(oc));
-}
-
-void hppa_cpu_list(FILE *f, fprintf_function cpu_fprintf)
-{
-    CPUListState s = {
-        .file = f,
-        .cpu_fprintf = cpu_fprintf,
-    };
-    GSList *list;
-
-    list = object_class_get_list_sorted(TYPE_HPPA_CPU, false);
-    (*cpu_fprintf)(f, "Available CPUs:\n");
-    g_slist_foreach(list, hppa_cpu_list_entry, &s);
-    g_slist_free(list);
-}
-
 static void hppa_cpu_initfn(Object *obj)
 {
     CPUState *cs = CPU(obj);
Signature · 1 line
2.18.0.rc1.1.g3f1ff2140
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Thu, 18 Apr 2019 01:01:03 -0300 Eduardo Habkost <[email protected]> wrote:

hppa_cpu_list() is dead code and is never called. Delete it.

Cc Richard Henderson <[email protected]>
Quoted 37 lines
---
 target/hppa/cpu.c | 22 ----------------------
 1 file changed, 22 deletions(-)
target/hppa/cpu.c +0 -22
index 00bf444620..b3b1826209 100644
@@ -110,28 +110,6 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error **errp)
 #endif
 }
 
-static void hppa_cpu_list_entry(gpointer data, gpointer user_data)
-{
-    ObjectClass *oc = data;
-    CPUListState *s = user_data;
-
-    (*s->cpu_fprintf)(s->file, "  %s\n", object_class_get_name(oc));
-}
-
-void hppa_cpu_list(FILE *f, fprintf_function cpu_fprintf)
-{
-    CPUListState s = {
-        .file = f,
-        .cpu_fprintf = cpu_fprintf,
-    };
-    GSList *list;
-
-    list = object_class_get_list_sorted(TYPE_HPPA_CPU, false);
-    (*cpu_fprintf)(f, "Available CPUs:\n");
-    g_slist_foreach(list, hppa_cpu_list_entry, &s);
-    g_slist_free(list);
-}
-
 static void hppa_cpu_initfn(Object *obj)
 {
     CPUState *cs = CPU(obj);
Tested-by Reviewed-by on v1 1/1
#2 lore raw
In reply to Eduardo Habkost

Hi Eduardo,

Quoted 4 lines · Eduardo Habkost

hppa_cpu_list() is dead code and is never called. Delete it.

Cc Richard Henderson <[email protected]>
Quoted 11 lines
---
 target/hppa/cpu.c | 22 ----------------------
 1 file changed, 22 deletions(-)
target/hppa/cpu.c +0 -0
index 00bf444620..b3b1826209 100644
@@ -110,28 +110,6 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error **errp)
 #endif
 }

target/hppa/cpu.c static void hppa_cpu_realizefn(DeviceState *dev, Error **errp) · line 121

Quoted 10 lines
target/hppa/cpu.c +0 -9
 
-static void hppa_cpu_list_entry(gpointer data, gpointer user_data)
-{
-    ObjectClass *oc = data;
-    CPUListState *s = user_data;
-
-    (*s->cpu_fprintf)(s->file, "  %s\n", object_class_get_name(oc));
-}
-
-void hppa_cpu_list(FILE *f, fprintf_function cpu_fprintf)

You forgot to remove the declaration in "target/hppa/cpu.h".

With this header updated:

Quoted 17 lines
target/hppa/cpu.c +0 -13
-{
-    CPUListState s = {
-        .file = f,
-        .cpu_fprintf = cpu_fprintf,
-    };
-    GSList *list;
-
-    list = object_class_get_list_sorted(TYPE_HPPA_CPU, false);
-    (*cpu_fprintf)(f, "Available CPUs:\n");
-    g_slist_foreach(list, hppa_cpu_list_entry, &s);
-    g_slist_free(list);
-}
-
 static void hppa_cpu_initfn(Object *obj)
 {
     CPUState *cs = CPU(obj);