Skip to contentSkip to conversation

clk: meson: g12a: fix missing uart2 in regmap table

PATCH Applied Jerome Brunet 4 participants 5 messages Dec 13, 2019 – Dec 16, 2019

Subsystems (3)
lore
Share & tools
lore

Jerome Brunet

author maintainer
#0 lore raw

PATCH 1/1 clk: meson: g12a: fix missing uart2 in regmap table

UART2 peripheral is missing from the regmap fixup table of the g12a family clock controller. As it is, any access to this clock would Oops, which is not great.

Add the clock to the table to fix the problem.

Fixes 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
---
 drivers/clk/meson/g12a.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/meson/g12a.c +1 -0
index 66cf791bfc8c..cd1de3e004e4 100644
@@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = {
 	&g12a_bt656,
 	&g12a_usb1_to_ddr,
 	&g12a_mmc_pclk,
+	&g12a_uart2,
 	&g12a_vpu_intr,
 	&g12a_gic,
 	&g12a_sd_emmc_a_clk0,
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw
Quoted 20 lines · Jerome Brunet

UART2 peripheral is missing from the regmap fixup table of the g12a family clock controller. As it is, any access to this clock would Oops, which is not great.

Add the clock to the table to fix the problem.

Fixes 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
---
 drivers/clk/meson/g12a.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/meson/g12a.c +0 -0
index 66cf791bfc8c..cd1de3e004e4 100644

drivers/clk/meson/g12a.c static struct clk_regmap *const g12a_clk_regmaps[] = { · line 4698

Quoted 7 lines
drivers/clk/meson/g12a.c +1 -0
@@ -4692,6 +4692,7 @@ static struct clk_regmap *const g12a_clk_regmaps[] = {
 	&g12a_bt656,
 	&g12a_usb1_to_ddr,
 	&g12a_mmc_pclk,
+	&g12a_uart2,
 	&g12a_vpu_intr,
 	&g12a_gic,
 	&g12a_sd_emmc_a_clk0,
maintainer Tested-by on v1 1/1
#2 lore raw
In reply to Jerome Brunet
Quoted 10 lines · Jerome Brunet

UART2 peripheral is missing from the regmap fixup table of the g12a family clock controller. As it is, any access to this clock would Oops, which is not great.

Add the clock to the table to fix the problem.

Fixes 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")
author maintainer
#3 lore raw
Quoted 6 lines · Kevin Hilman
Quoted 4 lines · Jerome Brunet

UART2 peripheral is missing from the regmap fixup table of the g12a family clock controller. As it is, any access to this clock would Oops, which is not great.

Quoted 8 lines
Quoted 6 lines

Add the clock to the table to fix the problem.

Fixes 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")

Applied for fixes

#4 lore raw
In reply to Jerome Brunet
This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).

Hello:

This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).

Quoted 4 lines · On Fri, 13 Dec 2019 11:33:04 +0100 you wrote:

UART2 peripheral is missing from the regmap fixup table of the g12a family clock controller. As it is, any access to this clock would Oops, which is not great.

Quoted 8 lines

Add the clock to the table to fix the problem.

Fixes 085a4ea93d54 ("clk: meson: g12a: add peripheral clock controller")

[...]

Here is a summary with links:
- clk: meson: g12a: fix missing uart2 in regmap table

    https://git.kernel.org/khilman/linux-amlogic/c/b1b3f0622a9d52ac19a63619911823c89a4d85a4

You are awesome, thank you!

Signature · 7 lines
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic