Skip to contentSkip to conversation

clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED

PATCH Superseded Boris Brezillon 2 participants 2 messages Jun 16, 2015

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED

Fixes 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: add

missing CESA gate clk").
The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug in the BootROM code, requires the crypto clk to be up and running. Flag the the crypto clk as IGNORE_UNUSED until we add the proper infrastructure to define the crypto SRAM in the DT and reference the crypto clk in this SRAM node.

---
 drivers/clk/mvebu/armada-370.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/mvebu/armada-370.c +1 -1
index c19fd77..7c2a58c 100644
@@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = {
 	{ "pex1", "pex1_en", 9, 0 },
 	{ "sata0", NULL, 15, 0 },
 	{ "sdio", NULL, 17, 0 },
-	{ "crypto", NULL, 23, 0 },
+	{ "crypto", NULL, 23, CLK_IGNORE_UNUSED }
 	{ "tdm", NULL, 25, 0 },
 	{ "ddr", NULL, 28, CLK_IGNORE_UNUSED },
 	{ "sata1", NULL, 30, 0 },
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 clk: mvebu: flag the crypto clk as CLK_IGNORE_UNUSED

Quoted 2 lines · Boris Brezillon
Fixes 29e623475c50267ee3aaa49ebb6cbe107bce8d2a ("clk: mvebu: add

missing CESA gate clk").

Which was:

Quoted 18 lines

The crypto SRAM, used by the armada 370 cpuidle code to workaround a bug in the BootROM code, requires the crypto clk to be up and running. Flag the the crypto clk as IGNORE_UNUSED until we add the proper infrastructure to define the crypto SRAM in the DT and reference the crypto clk in this SRAM node.

---
 drivers/clk/mvebu/armada-370.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/mvebu/armada-370.c +0 -0
index c19fd77..7c2a58c 100644

drivers/clk/mvebu/armada-370.c static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { · line 166

Quoted 5 lines
drivers/clk/mvebu/armada-370.c +1 -1
@@ -163,7 +163,7 @@ static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = {
 	{ "pex1", "pex1_en", 9, 0 },
 	{ "sata0", NULL, 15, 0 },
 	{ "sdio", NULL, 17, 0 },
-	{ "crypto", NULL, 23, 0 },
+	{ "crypto", NULL, 23, CLK_IGNORE_UNUSED }

Doesn't compile. Needs trailing ','

drivers/clk/mvebu/armada-370.c static const struct clk_gating_soc_desc a370_gating_desc[] __initconst = { · line 169

Quoted 3 lines
drivers/clk/mvebu/armada-370.c +0 -0
 	{ "tdm", NULL, 25, 0 },
 	{ "ddr", NULL, 28, CLK_IGNORE_UNUSED },
 	{ "sata1", NULL, 30, 0 },

With that fixed, I tested this on top of next-20150615 where mirabox was previously broken and I confirm it's now working.

Kevin