Skip to contentSkip to conversation

enable the SAR ADC for all boards based on P23x and Q20x

PATCH New Martin Blumenstingl 3 participants 4 messages Jun 23, 2018 – Jun 29, 2018

Subsystems (2)
Device tree bindings Arm/Amlogic Meson SoC support
lore
Share & tools
lore

Martin Blumenstingl

author reviewer
#0 lore raw

cover enable the SAR ADC for all boards based on P23x and Q20x

This is compile-tested only - the goal is to remove some duplicate code between the P230 and Q200 boards.
As a positive side-effect we also enable the SAR ADC on the P231 and Q201 boards (the only difference to the P230 and Q200 boards seems to be that P230 and Q200 use an external RGMII Ethernet PHY, while P231 and Q201 use the internal PHY).

Martin Blumenstingl (1):
ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi

 arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi  | 12 ++++++++++++
 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 12 ------------
 arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts       | 12 ------------
 3 files changed, 12 insertions(+), 24 deletions(-)
Signature · 1 line
2.18.0
author reviewer
#1 lore raw

PATCH 1/1 ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi

meson-gxl-s905d-p230.dts and meson-gxm-q200.dts enable the saradc node (and configure it's vref-supply "VDDIO_AO18") in their corresponding .dts file.
Move both (the saradc node as well as the VDDIO_AO18 regulator) to remove some duplicate code.

As a positive side-effect this enables the saradc also for the P231 (GXL S905D) and Q201 (GXM S912) development boards which are similar to the P230/Q200 boards (P231 and Q201 use the internal 100Mbit/s PHY, while P230 and Q200 have an external RGMII PHY).

Signed-off-by Martin Blumenstingl <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi  | 12 ++++++++++++
 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 12 ------------
 arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts       | 12 ------------
 3 files changed, 12 insertions(+), 24 deletions(-)
arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi +12 -0
index 88e712ea757a..01616982af0d 100644
@@ -35,6 +35,13 @@
 		regulator-always-on;
 	};
 
+	vddio_ao18: regulator-vddio_ao18 {
+		compatible = "regulator-fixed";
+		regulator-name = "VDDIO_AO18";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+	};
+
 	vddio_boot: regulator-vddio_boot {
 		compatible = "regulator-fixed";
 		regulator-name = "VDDIO_BOOT";

@@ -140,6 +147,11 @@
 	clock-names = "clkin0";
 };
 
+&saradc {
+	status = "okay";
+	vref-supply = <&vddio_ao18>;
+};
+
 /* Wireless SDIO Module */
 &sd_emmc_a {
 	status = "okay";
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts +0 -12
index a9f9bb90a877..9c5be060fd5e 100644
@@ -41,13 +41,6 @@
 		};
 	};
 
-	vddio_ao18: regulator-vddio_ao18 {
-		compatible = "regulator-fixed";
-		regulator-name = "VDDIO_AO18";
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
-	};
-
 	hdmi-connector {
 		compatible = "hdmi-connector";
 		type = "a";

@@ -107,8 +100,3 @@
 		remote-endpoint = <&hdmi_connector_in>;
 	};
 };
-
-&saradc {
-	status = "okay";
-	vref-supply = <&vddio_ao18>;
-};
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts +0 -12
index 101417298a1d..432f7a435fba 100644
@@ -40,13 +40,6 @@
 			gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
 		};
 	};
-
-	vddio_ao18: regulator-vddio_ao18 {
-		compatible = "regulator-fixed";
-		regulator-name = "VDDIO_AO18";
-		regulator-min-microvolt = <1800000>;
-		regulator-max-microvolt = <1800000>;
-	};
 };
 
 /* Q200 has exclusive choice between internal or external PHY */

@@ -78,8 +71,3 @@
 		interrupts = <25 IRQ_TYPE_LEVEL_LOW>;
 	};
 };
-
-&saradc {
-	status = "okay";
-	vref-supply = <&vddio_ao18>;
-};
Signature · 1 line
2.18.0
#2 lore raw

PATCH 1/1 ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi

Quoted 18 lines · Martin Blumenstingl

meson-gxl-s905d-p230.dts and meson-gxm-q200.dts enable the saradc node (and configure it's vref-supply "VDDIO_AO18") in their corresponding .dts file.
Move both (the saradc node as well as the VDDIO_AO18 regulator) to remove some duplicate code.

As a positive side-effect this enables the saradc also for the P231 (GXL S905D) and Q201 (GXM S912) development boards which are similar to the P230/Q200 boards (P231 and Q201 use the internal 100Mbit/s PHY, while P230 and Q200 have an external RGMII PHY).

Signed-off-by Martin Blumenstingl <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi  | 12 ++++++++++++
 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 12 ------------
 arch/arm64/boot/dts/amlogic/meson-gxm-q200.dts       | 12 ------------
 3 files changed, 12 insertions(+), 24 deletions(-)

[...]

Reviewed-by Neil Armstrong <[email protected]>
maintainer Applied
#3 lore raw

PATCH 1/1 ARM64: dts: meson: enable the saradc node in meson-gx-p23x-q20x.dtsi

In reply to Martin Blumenstingl
Quoted 6 lines · Martin Blumenstingl

meson-gxl-s905d-p230.dts and meson-gxm-q200.dts enable the saradc node (and configure it's vref-supply "VDDIO_AO18") in their corresponding .dts file.
Move both (the saradc node as well as the VDDIO_AO18 regulator) to remove some duplicate code.

Quoted 6 lines

As a positive side-effect this enables the saradc also for the P231 (GXL S905D) and Q201 (GXM S912) development boards which are similar to the P230/Q200 boards (P231 and Q201 use the internal 100Mbit/s PHY, while P230 and Q200 have an external RGMII PHY).

Signed-off-by Martin Blumenstingl <[email protected]>

Applied to v4.19/dt64,

Kevin