Skip to contentSkip to conversation

arm64: meson-gxm: Add support for the Mali T820 GPU

PATCH In review Neil Armstrong 3 participants 6 messages Mar 15, 2019 – Apr 2, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v2 cover arm64: meson-gxm: Add support for the Mali T820 GPU

This patchset adds :
- Optional reset properties in the midgard bindings
- Mali T820 Node in Amlogic Meson GXM DTSI

Changes since v1:
- Updated midgard DT wording following the recently submitted bifrost bindings

Christian Hewitt (1):
arm64: dts: meson-gxm: Add Mali-T820 node

Neil Armstrong (1):
dt-bindings: gpu: mali-midgard: Add resets property

 .../bindings/gpu/arm,mali-midgard.txt         | 14 ++++++++++
 arch/arm64/boot/dts/amlogic/meson-gxm.dtsi    | 27 +++++++++++++++++++
 2 files changed, 41 insertions(+)
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/2 dt-bindings: gpu: mali-midgard: Add resets property

The Amlogic ARM Mali Midgard requires reset controls to power on and software reset the GPU, adds these as optional in the bindings.

---
 .../devicetree/bindings/gpu/arm,mali-midgard.txt   | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt +14 -0
index 18a2cde2e5f3..1b1a74129141 100644
@@ -37,6 +37,20 @@ Optional properties:
 - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt
   for details.
 
+- resets : Phandle of the GPU reset line.
+
+Vendor-specific bindings
+------------------------
+
+The Mali GPU is integrated very differently from one SoC to
+another. In order to accomodate those differences, you have the option
+to specify one more vendor-specific compatible, among:
+
+- "amlogic,meson-gxm-mali"
+  Required properties:
+  - resets : Should contain phandles of :
+    + GPU reset line
+    + GPU APB glue reset line
 
 Example for a Mali-T760:
 
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: gpu: mali-midgard: Add resets property

Quoted 8 lines · Neil Armstrong

The Amlogic ARM Mali Midgard requires reset controls to power on and software reset the GPU, adds these as optional in the bindings.

---
 .../devicetree/bindings/gpu/arm,mali-midgard.txt   | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw

PATCH v2 2/2 arm64: dts: meson-gxm: Add Mali-T820 node

In reply to Neil Armstrong

From: Christian Hewitt <[email protected]>

The Amlogic Meson GXM SoC embeds an ARM Mali T820 GPU.

This patch adds the node with all the needed properties to power on the GPU.

This has been tested with the work-in-progress PanFrost project aiming support for ARM Mali Midgard and later GPUs.

---
 arch/arm64/boot/dts/amlogic/meson-gxm.dtsi | 27 ++++++++++++++++++++++
 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/amlogic/meson-gxm.dtsi +27 -0
index 247888d68a3a..35e59d390903 100644
@@ -91,6 +91,33 @@
 		reset-names = "phy";
 		status = "okay";
 	};
+
+	mali: gpu@c0000 {
+		compatible = "amlogic,meson-gxm-mali", "arm,mali-t820";
+		reg = <0x0 0xc0000 0x0 0x40000>;
+		interrupt-parent = <&gic>;
+		interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "gpu", "mmu", "job";
+		clocks = <&clkc CLKID_MALI>;
+		resets = <&reset RESET_MALI_CAPB3>, <&reset RESET_MALI>;
+
+		/*
+		 * Mali clocking is provided by two identical clock paths
+		 * MALI_0 and MALI_1 muxed to a single clock by a glitch
+		 * free mux to safely change frequency while running.
+		 */
+		assigned-clocks = <&clkc CLKID_MALI_0_SEL>,
+				  <&clkc CLKID_MALI_0>,
+				  <&clkc CLKID_MALI>; /* Glitch free mux */
+		assigned-clock-parents = <&clkc CLKID_FCLK_DIV3>,
+					 <0>, /* Do Nothing */
+					 <&clkc CLKID_MALI_0>;
+		assigned-clock-rates = <0>, /* Do Nothing */
+				       <666666666>,
+				       <0>; /* Do Nothing */
+	};
 };
 
 &clkc_AO {
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw
In reply to Neil Armstrong
Quoted 11 lines · Neil Armstrong

This patchset adds :
- Optional reset properties in the midgard bindings
- Mali T820 Node in Amlogic Meson GXM DTSI

Changes since v1:
- Updated midgard DT wording following the recently submitted bifrost bindings

Christian Hewitt (1):
arm64: dts: meson-gxm: Add Mali-T820 node

Quoted 7 lines

Neil Armstrong (1):
dt-bindings: gpu: mali-midgard: Add resets property

 .../bindings/gpu/arm,mali-midgard.txt         | 14 ++++++++++
 arch/arm64/boot/dts/amlogic/meson-gxm.dtsi    | 27 +++++++++++++++++++
 2 files changed, 41 insertions(+)

Kevin, can you take both in your tree now the bindings are reviewed ?

Thanks,
Neil
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

maintainer
#5 lore raw
Quoted 15 lines · Neil Armstrong
Quoted 14 lines · Neil Armstrong

This patchset adds :
- Optional reset properties in the midgard bindings
- Mali T820 Node in Amlogic Meson GXM DTSI

Changes since v1:
- Updated midgard DT wording following the recently submitted bifrost bindings

Christian Hewitt (1):
arm64: dts: meson-gxm: Add Mali-T820 node

Neil Armstrong (1):
dt-bindings: gpu: mali-midgard: Add resets property

Quoted 6 lines
Quoted 4 lines
 .../bindings/gpu/arm,mali-midgard.txt         | 14 ++++++++++
 arch/arm64/boot/dts/amlogic/meson-gxm.dtsi    | 27 +++++++++++++++++++
 2 files changed, 41 insertions(+)

Kevin, can you take both in your tree now the bindings are reviewed ?

Yes.

Queud for v5.2 (branch: v5.2/dt64)

Thanks,

Kevin