Skip to contentSkip to conversation

arm64: dts: meson: S922X: extend cpu opp-points

PATCH Applied Tim Lewis 5 participants 5 messages Apr 26, 2020 – Apr 29, 2020

Subsystems (2)
lore
Share & tools
lore

Tim Lewis

author
#0 lore raw

PATCH v4 1/1 arm64: dts: meson: S922X: extend cpu opp-points

Add extra cpu pop points to allow mild overclock on S922X. The opp points are found in Hardkernel N2 sources [1] and testing shows no obvious issues on other S922X devices. Thermal throttling should keep things in-check if needed.

[1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f

---
 arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 15 +++++++++++++++
 1 files changed, 15 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi +15 -0
index 046cc332d..1e5d0ee5d 100644
@@ -65,6 +65,11 @@
 			opp-hz = /bits/ 64 <1896000000>;
 			opp-microvolt = <981000>;
 		};
+
+		opp-1992000000 {
+			opp-hz = /bits/ 64 <1992000000>;
+			opp-microvolt = <1001000>;
+		};
 	};
 
 	cpub_opp_table_1: opp-table-1 {
@@ -120,5 +125,15 @@
 			opp-hz = /bits/ 64 <1704000000>;
 			opp-microvolt = <891000>;
 		};
+
+		opp-1800000000 {
+			opp-hz = /bits/ 64 <1800000000>;
+			opp-microvolt = <981000>;
+		};
+
+		opp-1908000000 {
+			opp-hz = /bits/ 64 <1908000000>;
+			opp-microvolt = <1022000>;
+		};
 	};
 };
Signature · 1 line
2.17.1
reviewer
#1 lore raw
Quoted 4 lines · Tim Lewis

Add extra cpu pop points to allow mild overclock on S922X. The opp points are found in Hardkernel N2 sources [1] and testing shows no obvious issues on other S922X devices. Thermal throttling should keep things in-check if needed.

The Odroid-N2 has a massive heatsink mounted.
Do we have any idea if this applies (is safe) on any other S922x device ?

It would be nice to get some input (review) from Amlogic is this to included for any devices using the SoC.

In the meantime, I think this should be applied to odroid-n2 dt only.

Quoted 42 lines

[1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f

---
 arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi | 15 +++++++++++++++
 1 files changed, 15 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi +15 -0
index 046cc332d..1e5d0ee5d 100644
@@ -65,6 +65,11 @@
 			opp-hz = /bits/ 64 <1896000000>;
 			opp-microvolt = <981000>;
 		};
+
+		opp-1992000000 {
+			opp-hz = /bits/ 64 <1992000000>;
+			opp-microvolt = <1001000>;
+		};
 	};
 
 	cpub_opp_table_1: opp-table-1 {
@@ -120,5 +125,15 @@
 			opp-hz = /bits/ 64 <1704000000>;
 			opp-microvolt = <891000>;
 		};
+
+		opp-1800000000 {
+			opp-hz = /bits/ 64 <1800000000>;
+			opp-microvolt = <981000>;
+		};
+
+		opp-1908000000 {
+			opp-hz = /bits/ 64 <1908000000>;
+			opp-microvolt = <1022000>;
+		};
 	};
 };
#2 lore raw
Quoted 13 lines · Jerome Brunet
Quoted 4 lines · Tim Lewis

Add extra cpu pop points to allow mild overclock on S922X. The opp points are found in Hardkernel N2 sources [1] and testing shows no obvious issues on other S922X devices. Thermal throttling should keep things in-check if needed.

The Odroid-N2 has a massive heatsink mounted.
Do we have any idea if this applies (is safe) on any other S922x device ?

I’ve tested it on several S922X box devices that I have, and also the original S922X version of the VIM3 - all have similar sized passive heatsinks about 20% the size of the N2 one. No obvious issues with Kodi software decoding to increase CPU usage. NB: The original patch submission was N2 specific and then reworked to apply to all S922X devices at Neil’s suggestion (after my TB and earlier comments).

CH.

[snip]

maintainer
#3 lore raw
Quoted 13 lines · Christian Hewitt
Quoted 12 lines · Jerome Brunet
Quoted 4 lines · Tim Lewis

Add extra cpu pop points to allow mild overclock on S922X. The opp points are found in Hardkernel N2 sources [1] and testing shows no obvious issues on other S922X devices. Thermal throttling should keep things in-check if needed.

The Odroid-N2 has a massive heatsink mounted.
Do we have any idea if this applies (is safe) on any other S922x device ?

Quoted 6 lines

I’ve tested it on several S922X box devices that I have, and also the original S922X version of the VIM3 - all have similar sized passive heatsinks about 20% the size of the N2 one. No obvious issues with Kodi software decoding to increase CPU usage. NB: The original patch submission was N2 specific and then reworked to apply to all S922X devices at Neil’s suggestion (after my TB and earlier comments).

Yes, we also have OPP lowering enabled by default (which I think Neil mentioned earlier) so this should be safe (enough) to apply.

Queuing for v5.8,

Kevin

#4 lore raw
In reply to Tim Lewis
This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).

Hello:

This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).

Quoted 11 lines · On Sun, 26 Apr 2020 12:21:19 -0400 you wrote:

Add extra cpu pop points to allow mild overclock on S922X. The opp points are found in Hardkernel N2 sources [1] and testing shows no obvious issues on other S922X devices. Thermal throttling should keep things in-check if needed.

[1] https://github.com/hardkernel/linux/commit/f86cd9487c7483b2a05f448b9ebacf6bd5a2ad2f

[...]

Here is a summary with links:
- [v4] arm64: dts: meson: S922X: extend cpu opp-points

    https://git.kernel.org/khilman/linux-amlogic/c/75800d701782e89eecaf712fa141082b6e36f956

You are awesome, thank you!

Signature · 7 lines
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic