Skip to contentSkip to conversation

ARM: multi_v7_defconfig: Enable required QCOM SPMI/PMIC drivers

PATCH New Andy Gross 4 participants 7 messages Nov 26, 2015 – Dec 2, 2015

Subsystems (2)
Arm (32-bit) Arm Qualcomm mailing list
lore
Share & tools
lore

Andy Gross

author
#0 lore raw

PATCH 1/1 ARM: multi_v7_defconfig: Enable required QCOM SPMI/PMIC drivers

This patch enables the QCOM SPMI and PMIC related drivers that are now required to boot some supported devices.

Signed-off-by Andy Gross <[email protected]>
---
 arch/arm/configs/multi_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/configs/multi_v7_defconfig +4 -0
index 69a22fd..8a5227e 100644
@@ -340,10 +340,13 @@ CONFIG_SPI_TEGRA20_SFLASH=y
 CONFIG_SPI_TEGRA20_SLINK=y
 CONFIG_SPI_XILINX=y
 CONFIG_SPI_SPIDEV=y
+CONFIG_SPMI=y
 CONFIG_PINCTRL_AS3722=y
 CONFIG_PINCTRL_PALMAS=y
 CONFIG_PINCTRL_APQ8064=y
 CONFIG_PINCTRL_APQ8084=y
+CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
+CONFIG_PINCTRL_QCOM_SSBI_PMIC=y
 CONFIG_GPIO_SYSFS=y
 CONFIG_GPIO_GENERIC_PLATFORM=y
 CONFIG_GPIO_DAVINCI=y

@@ -407,6 +410,7 @@ CONFIG_MFD_MAX8907=y
 CONFIG_MFD_RK808=y
 CONFIG_MFD_PM8921_CORE=y
 CONFIG_MFD_QCOM_RPM=y
+CONFIG_MFD_SPMI_PMIC=y
 CONFIG_MFD_SEC_CORE=y
 CONFIG_MFD_STMPE=y
 CONFIG_MFD_PALMAS=y
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 ARM: multi_v7_defconfig: Enable required QCOM SPMI/PMIC drivers

Quoted 5 lines · On Thursday 26 November 2015 00:15:57 Andy Gross wrote:

This patch enables the QCOM SPMI and PMIC related drivers that are now required to boot some supported devices.

Signed-off-by Andy Gross <[email protected]>

Applied to next/defconfig. I assume you didn't mean this to go into 4.4.

Arnd

author
#2 lore raw

PATCH 1/1 ARM: multi_v7_defconfig: Enable required QCOM SPMI/PMIC drivers

Quoted 6 lines · Arnd Bergmann
Quoted 5 lines · On Thursday 26 November 2015 00:15:57 Andy Gross wrote:

This patch enables the QCOM SPMI and PMIC related drivers that are now required to boot some supported devices.

Signed-off-by Andy Gross <[email protected]>

That should be fine.

Andy

#3 lore raw

PATCH 1/1 ARM: defconfig: multi_v7: Enable Qualcomm options for Honami

In reply to Andy Gross

The Honami device does not boot due to the lack of pinctrl support compiled in with the multi_v7_defconfig. This patch correct this and enables coincell, sdhci, smsm, smp2p and wcnss_ctrl as well, all found on a variety of Qualcomm boards.

Reported-by Kevin Hilman <[email protected]>
Signed-off-by Bjorn Andersson <[email protected]>

---

For next/deconfig.

As Kevin reported the Honami stops booting with the addition of pinctrl reference in the serial node, simply due to the fact that it references a pinctrl driver that's not enabled in the defconfig.

The patch sent by Andy is hence not enough to fix the problem.

PS. It would be mighty convenient if savedefconfig could be used on the multi_v7_defconfig.

 arch/arm/configs/multi_v7_defconfig | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
arch/arm/configs/multi_v7_defconfig +11 -1
index fa7ba92cfe70..dc30a48374b2 100644
@@ -186,6 +186,7 @@ CONFIG_AD525X_DPOT_I2C=y
 CONFIG_ATMEL_TCLIB=y
 CONFIG_ICS932S401=y
 CONFIG_ATMEL_SSC=m
+CONFIG_QCOM_COINCELL=m
 CONFIG_APDS9802ALS=y
 CONFIG_ISL29003=y
 CONFIG_EEPROM_AT24=y

@@ -347,6 +348,11 @@ CONFIG_PINCTRL_AS3722=y
 CONFIG_PINCTRL_PALMAS=y
 CONFIG_PINCTRL_APQ8064=y
 CONFIG_PINCTRL_APQ8084=y
+CONFIG_PINCTRL_IPQ8064=y
+CONFIG_PINCTRL_MSM8660=y
+CONFIG_PINCTRL_MSM8960=y
+CONFIG_PINCTRL_MSM8X74=y
+CONFIG_PINCTRL_MSM8916=y
 CONFIG_PINCTRL_QCOM_SPMI_PMIC=y
 CONFIG_PINCTRL_QCOM_SSBI_PMIC=y
 CONFIG_GPIO_SYSFS=y

@@ -580,6 +586,7 @@ CONFIG_MMC_SDHCI_ST=y
 CONFIG_MMC_OMAP=y
 CONFIG_MMC_OMAP_HS=y
 CONFIG_MMC_ATMELMCI=y
+CONFIG_MMC_SDHCI_MSM=y
 CONFIG_MMC_MVSDIO=y
 CONFIG_MMC_SDHI=y
 CONFIG_MMC_DW=y

@@ -668,9 +675,12 @@ CONFIG_NVEC_POWER=y
 CONFIG_NVEC_PAZ00=y
 CONFIG_QCOM_GSBI=y
 CONFIG_QCOM_PM=y
+CONFIG_QCOM_SMEM=y
 CONFIG_QCOM_SMD=y
 CONFIG_QCOM_SMD_RPM=y
-CONFIG_QCOM_SMEM=y
+CONFIG_QCOM_SMP2P=y
+CONFIG_QCOM_SMSM=y
+CONFIG_QCOM_WCNSS_CTRL=m
 CONFIG_COMMON_CLK_QCOM=y
 CONFIG_CHROME_PLATFORMS=y
 CONFIG_CROS_EC_CHARDEV=m
Signature · 1 line
2.4.2
author
#4 lore raw

PATCH 1/1 ARM: defconfig: multi_v7: Enable Qualcomm options for Honami

Quoted 8 lines · Bjorn Andersson

The Honami device does not boot due to the lack of pinctrl support compiled in with the multi_v7_defconfig. This patch correct this and enables coincell, sdhci, smsm, smp2p and wcnss_ctrl as well, all found on a variety of Qualcomm boards.

Reported-by Kevin Hilman <[email protected]>
Signed-off-by Bjorn Andersson <[email protected]>

---

That would make a difference, wouldn't it.

Acked-by Andy Gross <[email protected]>
#5 lore raw

PATCH 1/1 ARM: defconfig: multi_v7: Enable Qualcomm options for Honami

In reply to Bjorn Andersson
Quoted 7 lines · Bjorn Andersson

The Honami device does not boot due to the lack of pinctrl support compiled in with the multi_v7_defconfig. This patch correct this and enables coincell, sdhci, smsm, smp2p and wcnss_ctrl as well, all found on a variety of Qualcomm boards.

Reported-by Kevin Hilman <[email protected]>
Signed-off-by Bjorn Andersson <[email protected]>
Tested-by Kevin Hilman <[email protected]>

Verified that this patch on top of next-20151127 gets my z1 booting again.

Kevin

#6 lore raw

PATCH 1/1 ARM: defconfig: multi_v7: Enable Qualcomm options for Honami

Quoted 7 lines · Kevin Hilman
Quoted 5 lines · Bjorn Andersson

The Honami device does not boot due to the lack of pinctrl support compiled in with the multi_v7_defconfig. This patch correct this and enables coincell, sdhci, smsm, smp2p and wcnss_ctrl as well, all found on a variety of Qualcomm boards.

Quoted 7 lines
Quoted 2 lines
Reported-by Kevin Hilman <[email protected]>
Signed-off-by Bjorn Andersson <[email protected]>
Tested-by Kevin Hilman <[email protected]>

Verified that this patch on top of next-20151127 gets my z1 booting again.

... and applied to next/defconfig on top of Andy's patch.

Thanks,

Kevin