Skip to contentSkip to conversation

arm64: dts: meson-g12b-khadas-vim3: fix missing frddr_a node

PATCH In review chewitt 3 participants 4 messages Apr 15, 2020 – Apr 29, 2020

Subsystems (2)
lore
Share & tools
lore

chewitt

author
#0 lore raw

PATCH 1/1 arm64: dts: meson-g12b-khadas-vim3: fix missing frddr_a node

From: Christian Hewitt <[email protected]>

The frddr_a node was accidently deleted when creating a common dtsi for the Khadas VIM3/VIM3L boards, preventing audio from working on the VIM3.

Fixes 4f26cc1c96c9 ("arm64: dts: khadas-vim3: move common nodes into meson-khadas-vim3.dtsi")
---
 arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi +4 -0
index c33e85fbdaba..c6c8caed8327 100644
@@ -154,6 +154,10 @@
 	clock-latency = <50000>;
 };
 
+&frddr_a {
+	status = "okay";
+};
+
 &frddr_b {
 	status = "okay";
 };
Signature · 1 line
2.17.1
#1 lore raw
Quoted 31 lines · chewitt

From: Christian Hewitt <[email protected]>

The frddr_a node was accidently deleted when creating a common dtsi for the Khadas VIM3/VIM3L boards, preventing audio from working on the VIM3.

Fixes 4f26cc1c96c9 ("arm64: dts: khadas-vim3: move common nodes into meson-khadas-vim3.dtsi")

---
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++++

1 file changed, 4 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi +4 -0
index c33e85fbdaba..c6c8caed8327 100644
@@ -154,6 +154,10 @@
 	clock-latency = <50000>;
 };
 
+&frddr_a {
+	status = "okay";
+};
+
 &frddr_b {
 	status = "okay";
 };
Signature · 1 line
2.17.1

NB: I appears the same change was sent by Neil in [1] as a fix to 5.4, but this appears to have been dropped/missed somewhere.

[1] https://patchwork.kernel.org/patch/11198535/

maintainer
#2 lore raw
Quoted 34 lines · Christian Hewitt
Quoted 30 lines · chewitt

From: Christian Hewitt <[email protected]>

The frddr_a node was accidently deleted when creating a common dtsi for the Khadas VIM3/VIM3L boards, preventing audio from working on the VIM3.

Fixes 4f26cc1c96c9 ("arm64: dts: khadas-vim3: move common nodes into meson-khadas-vim3.dtsi")

---
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++++

1 file changed, 4 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi +4 -0
index c33e85fbdaba..c6c8caed8327 100644
@@ -154,6 +154,10 @@
 	clock-latency = <50000>;
 };
 
+&frddr_a {
+	status = "okay";
+};
+
 &frddr_b {
 	status = "okay";
 };
Signature · 1 line
2.17.1

NB: I appears the same change was sent by Neil in [1] as a fix to 5.4, but this appears to have been dropped/missed somewhere.

Quoted 1 line

[1] https://patchwork.kernel.org/patch/11198535/

Hmm, not sure how I dropped that one. I applied (again) the original from Neil (with updated tags from Jerome) and queued as fix for v5.7-rc.

Sorry,

Kevin

reviewer Reviewed-by Tested-by on v1 1/1
#3 lore raw
In reply to chewitt
Quoted 7 lines · chewitt

From: Christian Hewitt <[email protected]>

The frddr_a node was accidently deleted when creating a common dtsi for the Khadas VIM3/VIM3L boards, preventing audio from working on the VIM3.

Fixes 4f26cc1c96c9 ("arm64: dts: khadas-vim3: move common nodes into meson-khadas-vim3.dtsi")
Quoted 19 lines
---
 arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/amlogic/meson-g12b-khadas-vim3.dtsi +4 -0
index c33e85fbdaba..c6c8caed8327 100644
@@ -154,6 +154,10 @@
 	clock-latency = <50000>;
 };
 
+&frddr_a {
+	status = "okay";
+};
+
 &frddr_b {
 	status = "okay";
 };