ARM: dts: Add support for the BeagleBoard xM A/B

PATCH New Robert Nelson 5 participants 13 messages Apr 15, 2014 – Apr 24, 2014

Subsystems (2)

Device tree bindings Arm and arm64 SoC sub-architectures (common parts)

lore

Share & tools

lore

Robert Nelson

author

2014-04-15 15:09 UTC #0 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C

Signed-off-by Robert Nelson <[email protected]>

---
 arch/arm/boot/dts/Makefile               |  1 +
 arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts

arch/arm/boot/dts/Makefile +1 -0

index 35c146f..0bdeba3 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
 	omap3-sbc-t3730.dtb \
 	omap3-devkit8000.dtb \
 	omap3-beagle-xm.dtb \
+	omap3-beagle-xm-ab.dtb \
 	omap3-evm.dtb \
 	omap3-evm-37xx.dtb \
 	omap3-ldp.dtb \

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +15 -0

new file mode 100644
index 0000000..9d81123
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+	/* HS USB Port 2 Power enable was inverted with the xM C */
+	hsusb2_power: hsusb2_power_reg {
+		enable-active-high;
+};

Signature · 1 line

1.9.1

Robert Nelson

author

2014-04-15 15:12 UTC #1 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 31 lines · Robert Nelson

BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C

Signed-off-by Robert Nelson <[email protected]>

---
 arch/arm/boot/dts/Makefile               |  1 +
 arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts

arch/arm/boot/dts/Makefile +1 -0

index 35c146f..0bdeba3 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
        omap3-sbc-t3730.dtb \
        omap3-devkit8000.dtb \
        omap3-beagle-xm.dtb \
+       omap3-beagle-xm-ab.dtb \
        omap3-evm.dtb \
        omap3-evm-37xx.dtb \
        omap3-ldp.dtb \

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +4 -0

new file mode 100644
index 0000000..9d81123
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify

arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 14

Quoted 10 lines

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +10 -0

+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+       /* HS USB Port 2 Power enable was inverted with the xM C */
+       hsusb2_power: hsusb2_power_reg {
+               enable-active-high;

};

arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 15

Quoted 1 line

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +1 -0
+};

Crap, copy paste bug, there. I can send a v2, if you guys are happy with the "omap3-beagle-xm-ab.dtb" naming..

Regards,

Signature · 2 lines

Robert Nelson
http://www.rcn-ee.com/

Nishanth Menon

2014-04-15 15:35 UTC #2 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 43 lines · Robert Nelson

Quoted 31 lines · Robert Nelson

BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C

Signed-off-by Robert Nelson <[email protected]>

---
 arch/arm/boot/dts/Makefile               |  1 +
 arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts

arch/arm/boot/dts/Makefile +1 -0

index 35c146f..0bdeba3 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
        omap3-sbc-t3730.dtb \
        omap3-devkit8000.dtb \
        omap3-beagle-xm.dtb \
+       omap3-beagle-xm-ab.dtb \
        omap3-evm.dtb \
        omap3-evm-37xx.dtb \
        omap3-ldp.dtb \

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +4 -0

new file mode 100644
index 0000000..9d81123
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify

arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 14

Quoted 10 lines

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +10 -0

+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+       /* HS USB Port 2 Power enable was inverted with the xM C */
+       hsusb2_power: hsusb2_power_reg {
+               enable-active-high;

};

Quoted 7 lines

arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 15
Quoted 1 line
arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +1 -0
+};
Crap, copy paste bug, there. I can send a v2, if you guys are happy with the "omap3-beagle-xm-ab.dtb" naming..
Regards,

Will u-boot adequately handle this as part of find_fdt?

Signature · 2 lines

Regards,
Nishanth Menon

Robert Nelson

author

2014-04-15 15:40 UTC #3 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 44 lines · Nishanth Menon

Quoted 43 lines · Robert Nelson

Quoted 31 lines · Robert Nelson

BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C

Signed-off-by Robert Nelson <[email protected]>

---
 arch/arm/boot/dts/Makefile               |  1 +
 arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts

arch/arm/boot/dts/Makefile +1 -0

index 35c146f..0bdeba3 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
        omap3-sbc-t3730.dtb \
        omap3-devkit8000.dtb \
        omap3-beagle-xm.dtb \
+       omap3-beagle-xm-ab.dtb \
        omap3-evm.dtb \
        omap3-evm-37xx.dtb \
        omap3-ldp.dtb \

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +4 -0

new file mode 100644
index 0000000..9d81123
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify

arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 14

Quoted 10 lines

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +10 -0

+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+       /* HS USB Port 2 Power enable was inverted with the xM C */
+       hsusb2_power: hsusb2_power_reg {
+               enable-active-high;

};

Quoted 8 lines

Quoted 7 lines
arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 15
Quoted 1 line
arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +1 -0
+};
Crap, copy paste bug, there. I can send a v2, if you guys are happy with the "omap3-beagle-xm-ab.dtb" naming..
Regards,
Will u-boot adequately handle this as part of find_fdt?

It will after i submit something like: (this uses a new feature in v2014.04)

https://github.com/eewiki/u-boot-patches/blob/master/v2014.04/0001-am335x_evm-uEnv.txt-bootz-n-fixes.patch#L76

Essentially, test for presence of omap3-beagle-xm-ab.dtb, if not found drop to old omap3-beagle-xm.dtb

Background: i also tried getting this having this fixed in u-boot:

Quoted 4 lines

--
Regards,
Nishanth Menon

Signature · 2 lines

Robert Nelson
http://www.rcn-ee.com/

Tony Lindgren

2014-04-18 22:51 UTC #4 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 54 lines · Robert Nelson

Quoted 44 lines · Nishanth Menon
Quoted 43 lines · Robert Nelson
Quoted 31 lines · Robert Nelson
BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
Signed-off-by Robert Nelson <[email protected]>
---
 arch/arm/boot/dts/Makefile               |  1 +
 arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
arch/arm/boot/dts/Makefile +1 -0
index 35c146f..0bdeba3 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
        omap3-sbc-t3730.dtb \
        omap3-devkit8000.dtb \
        omap3-beagle-xm.dtb \
+       omap3-beagle-xm-ab.dtb \
        omap3-evm.dtb \
        omap3-evm-37xx.dtb \
        omap3-ldp.dtb \
arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +4 -0
new file mode 100644
index 0000000..9d81123
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 14
Quoted 10 lines
arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +10 -0
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+       /* HS USB Port 2 Power enable was inverted with the xM C */
+       hsusb2_power: hsusb2_power_reg {
+               enable-active-high;
       };
Quoted 8 lines
Quoted 7 lines
arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 15
Quoted 1 line
arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +1 -0
+};
Crap, copy paste bug, there. I can send a v2, if you guys are happy with the "omap3-beagle-xm-ab.dtb" naming..
Regards,
Will u-boot adequately handle this as part of find_fdt?

Quoted 8 lines

It will after i submit something like: (this uses a new feature in v2014.04)
https://github.com/eewiki/u-boot-patches/blob/master/v2014.04/0001-am335x_evm-uEnv.txt-bootz-n-fixes.patch#L76
Essentially, test for presence of omap3-beagle-xm-ab.dtb, if not found drop to old omap3-beagle-xm.dtb
Background: i also tried getting this having this fixed in u-boot:

Do we still need to apply this patch then?

Tony

Robert Nelson

author

2014-04-18 23:42 UTC #5 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 57 lines · Tony Lindgren

Quoted 56 lines · Robert Nelson
Quoted 44 lines · Nishanth Menon
Quoted 43 lines · Robert Nelson
Quoted 31 lines · Robert Nelson
BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C
Signed-off-by Robert Nelson <[email protected]>
---
 arch/arm/boot/dts/Makefile               |  1 +
 arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts
arch/arm/boot/dts/Makefile +1 -0
index 35c146f..0bdeba3 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
        omap3-sbc-t3730.dtb \
        omap3-devkit8000.dtb \
        omap3-beagle-xm.dtb \
+       omap3-beagle-xm-ab.dtb \
        omap3-evm.dtb \
        omap3-evm-37xx.dtb \
        omap3-ldp.dtb \
arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +4 -0
new file mode 100644
index 0000000..9d81123
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 14
Quoted 10 lines
arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +10 -0
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+       /* HS USB Port 2 Power enable was inverted with the xM C */
+       hsusb2_power: hsusb2_power_reg {
+               enable-active-high;
       };
Quoted 8 lines
Quoted 7 lines
arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 15
Quoted 1 line
arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +1 -0
+};
Crap, copy paste bug, there. I can send a v2, if you guys are happy with the "omap3-beagle-xm-ab.dtb" naming..
Regards,
Will u-boot adequately handle this as part of find_fdt?
It will after i submit something like: (this uses a new feature in v2014.04)

Quoted 8 lines

Quoted 6 lines
https://github.com/eewiki/u-boot-patches/blob/master/v2014.04/0001-am335x_evm-uEnv.txt-bootz-n-fixes.patch#L76
Essentially, test for presence of omap3-beagle-xm-ab.dtb, if not found drop to old omap3-beagle-xm.dtb
Background: i also tried getting this having this fixed in u-boot:
Do we still need to apply this patch then?

Yeah, Tom want's it done in the kernel:

Here's my proposed u-boot patch:
http://lists.denx.de/pipermail/u-boot/2014-January/172154.html

and Tom's recommendation:
http://lists.denx.de/pipermail/u-boot/2014-January/172274.html

Once this hits mainline, i'll submit a patch to u-boot to check for the presence of this version and drop to the old dtb if not found.

Regards,

Signature · 2 lines

Robert Nelson
http://www.rcn-ee.com/

Tony Lindgren

2014-04-18 23:51 UTC #6 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 9 lines · Robert Nelson

Quoted 5 lines · Tony Lindgren
Quoted 2 lines · Robert Nelson
Background: i also tried getting this having this fixed in u-boot:
Do we still need to apply this patch then?
Yeah, Tom want's it done in the kernel:

Quoted 8 lines

Here's my proposed u-boot patch:
http://lists.denx.de/pipermail/u-boot/2014-January/172154.html
and Tom's recommendation:
http://lists.denx.de/pipermail/u-boot/2014-January/172274.html
Once this hits mainline, i'll submit a patch to u-boot to check for the presence of this version and drop to the old dtb if not found.

OK applying into omap-for-v3.15/fixes thanks.

Tony

Gupta, Pekon

2014-04-22 06:49 UTC #7 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Tony,

Quoted 17 lines

From: Tony Lindgren
Quoted 15 lines · Robert Nelson
Quoted 5 lines · Tony Lindgren
Quoted 2 lines · Robert Nelson
Background: i also tried getting this having this fixed in u-boot:
Do we still need to apply this patch then?
Yeah, Tom want's it done in the kernel:
Here's my proposed u-boot patch:
http://lists.denx.de/pipermail/u-boot/2014-January/172154.html
and Tom's recommendation:
http://lists.denx.de/pipermail/u-boot/2014-January/172274.html

Quoted 6 lines

Quoted 2 lines
Once this hits mainline, i'll submit a patch to u-boot to check for the presence of this version and drop to the old dtb if not found.
OK applying into omap-for-v3.15/fixes thanks.
Tony

You probably missed fixing below typo before applying this patch. omap3-beagle-xm-ab.dts breaks without this.

Review

Quoted 4 lines

(quoted diff) +4 -0

+/ {
+       /* HS USB Port 2 Power enable was inverted with the xM C */
+       hsusb2_power: hsusb2_power_reg {
+               enable-active-high;

};

Quoted 1 line

+};

with regards, pekon

Tony Lindgren

2014-04-22 14:03 UTC #8 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 22 lines · Gupta, Pekon

Tony,
Quoted 20 lines
From: Tony Lindgren
Quoted 17 lines · Robert Nelson
Quoted 5 lines · Tony Lindgren
Quoted 2 lines · Robert Nelson
Background: i also tried getting this having this fixed in u-boot:
Do we still need to apply this patch then?
Yeah, Tom want's it done in the kernel:
Here's my proposed u-boot patch:
http://lists.denx.de/pipermail/u-boot/2014-January/172154.html
and Tom's recommendation:
http://lists.denx.de/pipermail/u-boot/2014-January/172274.html
Once this hits mainline, i'll submit a patch to u-boot to check for the presence of this version and drop to the old dtb if not found.

Quoted 6 lines

Quoted 3 lines
OK applying into omap-for-v3.15/fixes thanks.
Tony
You probably missed fixing below typo before applying this patch. omap3-beagle-xm-ab.dts breaks without this.

Yeah pushed out omap-for-v3.15/fixes-v2 with the missing bracket.

Regards,

Tony

Kevin Hilman

2014-04-24 22:34 UTC #9 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 23 lines · Tony Lindgren

Quoted 22 lines · Gupta, Pekon
Tony,
Quoted 20 lines
From: Tony Lindgren
Quoted 17 lines · Robert Nelson
Quoted 5 lines · Tony Lindgren
Quoted 2 lines · Robert Nelson
Background: i also tried getting this having this fixed in u-boot:
Do we still need to apply this patch then?
Yeah, Tom want's it done in the kernel:
Here's my proposed u-boot patch:
http://lists.denx.de/pipermail/u-boot/2014-January/172154.html
and Tom's recommendation:
http://lists.denx.de/pipermail/u-boot/2014-January/172274.html
Once this hits mainline, i'll submit a patch to u-boot to check for the presence of this version and drop to the old dtb if not found.

Quoted 8 lines

Quoted 6 lines
Quoted 3 lines
OK applying into omap-for-v3.15/fixes thanks.
Tony
You probably missed fixing below typo before applying this patch. omap3-beagle-xm-ab.dts breaks without this.
Yeah pushed out omap-for-v3.15/fixes-v2 with the missing bracket.

Your master branch still has the one that doesn't compile.

Kevin

Kevin Hilman

2014-04-24 22:32 UTC #10 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

In reply to Robert Nelson

Quoted 31 lines · Robert Nelson

BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C

Signed-off-by Robert Nelson <[email protected]>

---
 arch/arm/boot/dts/Makefile               |  1 +
 arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts

arch/arm/boot/dts/Makefile +1 -0

index 35c146f..0bdeba3 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
 	omap3-sbc-t3730.dtb \
 	omap3-devkit8000.dtb \
 	omap3-beagle-xm.dtb \
+	omap3-beagle-xm-ab.dtb \
 	omap3-evm.dtb \
 	omap3-evm-37xx.dtb \
 	omap3-ldp.dtb \

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +4 -0

new file mode 100644
index 0000000..9d81123
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify

arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 14

Quoted 10 lines

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +10 -0

+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+	/* HS USB Port 2 Power enable was inverted with the xM C */
+	hsusb2_power: hsusb2_power_reg {
+		enable-active-high;

Missing '};' here?

This causes build breakage in linux-omap master, which now has this applied.

arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 15

Quoted 1 line

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +1 -0
+};

Kevin

Kevin Hilman

2014-04-24 23:21 UTC #11 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 46 lines · Kevin Hilman

Quoted 31 lines · Robert Nelson

BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C

Signed-off-by Robert Nelson <[email protected]>

---
 arch/arm/boot/dts/Makefile               |  1 +
 arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts

arch/arm/boot/dts/Makefile +1 -0

index 35c146f..0bdeba3 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
      omap3-sbc-t3730.dtb \
      omap3-devkit8000.dtb \
      omap3-beagle-xm.dtb \
+     omap3-beagle-xm-ab.dtb \
      omap3-evm.dtb \
      omap3-evm-37xx.dtb \
      omap3-ldp.dtb \

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +4 -0

new file mode 100644
index 0000000..9d81123
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify

arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 14

Quoted 10 lines

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +10 -0

+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+     /* HS USB Port 2 Power enable was inverted with the xM C */
+     hsusb2_power: hsusb2_power_reg {
+             enable-active-high;

Missing '};' here?

Quoted 2 lines

This causes build breakage in linux-omap master, which now has this applied.

ignore this. It's already been fixed, but was still lingering in Tony's master branch.

Kevin

Tony Lindgren

2014-04-24 23:37 UTC #12 lore raw

PATCH 1/1 ARM: dts: Add support for the BeagleBoard xM A/B

Quoted 47 lines · Kevin Hilman

Quoted 46 lines · Kevin Hilman

Quoted 31 lines · Robert Nelson

BeagleBoard xM A/B has an inverted usb hub enable line vs the xM C

Signed-off-by Robert Nelson <[email protected]>

---
 arch/arm/boot/dts/Makefile               |  1 +
 arch/arm/boot/dts/omap3-beagle-xm-ab.dts | 15 +++++++++++++++
 2 files changed, 16 insertions(+)
 create mode 100644 arch/arm/boot/dts/omap3-beagle-xm-ab.dts

arch/arm/boot/dts/Makefile +1 -0

index 35c146f..0bdeba3 100644
@@ -246,6 +246,7 @@ dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
      omap3-sbc-t3730.dtb \
      omap3-devkit8000.dtb \
      omap3-beagle-xm.dtb \
+     omap3-beagle-xm-ab.dtb \
      omap3-evm.dtb \
      omap3-evm-37xx.dtb \
      omap3-ldp.dtb \

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +4 -0

new file mode 100644
index 0000000..9d81123
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify

arch/arm/boot/dts/omap3-beagle-xm-ab.dts line 14

Quoted 10 lines

arch/arm/boot/dts/omap3-beagle-xm-ab.dts new file +10 -0

+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include "omap3-beagle-xm.dts"
+
+/ {
+     /* HS USB Port 2 Power enable was inverted with the xM C */
+     hsusb2_power: hsusb2_power_reg {
+             enable-active-high;

Missing '};' here?

Quoted 5 lines

Quoted 2 lines
This causes build breakage in linux-omap master, which now has this applied.
ignore this. It's already been fixed, but was still lingering in Tony's master branch.

Oops, sorry yeah looks like I forgot to remerge the updated fixes branch. Will update it today.

Tony