Skip to contentSkip to conversation

bluetooth: hci_bcm: enable IRQ capability from node

PATCH Superseded Guillaume La Roque 2 participants 4 messages Dec 4, 2019 – Dec 7, 2019 Bluetooth drivers

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 bluetooth: hci_bcm: enable IRQ capability from node

Actually IRQ can be found from GPIO but all platorms don't support gpiod_to_irq, it's the case on amlogic chip.
so to have possibility to use interrupt mode we need to add interrupts field in node and support it in driver.

---
sorry for noise,

v2 is for rebasing on master branch

guillaume

 drivers/bluetooth/hci_bcm.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/bluetooth/hci_bcm.c +3 -0
index f8f5c593a05c..9f52d57c56de 100644
@@ -1409,6 +1409,7 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
 {
 	struct bcm_device *bcmdev;
 	const struct bcm_device_data *data;
+	struct platform_device *pdev;
 	int err;
 
 	bcmdev = devm_kzalloc(&serdev->dev, sizeof(*bcmdev), GFP_KERNEL);
@@ -1421,6 +1422,8 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
 #endif
 	bcmdev->serdev_hu.serdev = serdev;
 	serdev_device_set_drvdata(serdev, bcmdev);
+	pdev = to_platform_device(bcmdev->dev);
+	bcmdev->irq = platform_get_irq(pdev, 0);
 
 	/* Initialize routing field to an unused value */
 	bcmdev->pcm_int_params[0] = 0xff;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 1 line · Guillaume La Roque

Actually IRQ can be found from GPIO but all platorms don't support

nit: s/platorms/platforms/

Quoted 28 lines

gpiod_to_irq, it's the case on amlogic chip.
so to have possibility to use interrupt mode we need to add interrupts field in node and support it in driver.

---
sorry for noise,

v2 is for rebasing on master branch

guillaume

 drivers/bluetooth/hci_bcm.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/bluetooth/hci_bcm.c +1 -0
index f8f5c593a05c..9f52d57c56de 100644
@@ -1409,6 +1409,7 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
 {
 	struct bcm_device *bcmdev;
 	const struct bcm_device_data *data;
+	struct platform_device *pdev;
 	int err;
 
 	bcmdev = devm_kzalloc(&serdev->dev, sizeof(*bcmdev), GFP_KERNEL);

drivers/bluetooth/hci_bcm.c static int bcm_serdev_probe(struct serdev_device *serdev) · line 1426

Quoted 5 lines
drivers/bluetooth/hci_bcm.c +2 -0
@@ -1421,6 +1422,8 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
 #endif
 	bcmdev->serdev_hu.serdev = serdev;
 	serdev_device_set_drvdata(serdev, bcmdev);
+	pdev = to_platform_device(bcmdev->dev);
+	bcmdev->irq = platform_get_irq(pdev, 0);

I don't know this driver well enough to be sure, but don't you need some error checking here?

If this fails (on platforms with no IRQ defined), is an error code in bcmdev->irq going to affect later code that tries to setup IRQs?

Kevin

#2 lore raw

hi Kevin,

Quoted 4 lines · Kevin Hilman
Quoted 1 line · Guillaume La Roque

Actually IRQ can be found from GPIO but all platorms don't support

nit: s/platorms/platforms/

will fix in v3

Quoted 36 lines
Quoted 28 lines

gpiod_to_irq, it's the case on amlogic chip.
so to have possibility to use interrupt mode we need to add interrupts field in node and support it in driver.

---
sorry for noise,

v2 is for rebasing on master branch

guillaume

 drivers/bluetooth/hci_bcm.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/bluetooth/hci_bcm.c +1 -0
index f8f5c593a05c..9f52d57c56de 100644
@@ -1409,6 +1409,7 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
 {
 	struct bcm_device *bcmdev;
 	const struct bcm_device_data *data;
+	struct platform_device *pdev;
 	int err;
 
 	bcmdev = devm_kzalloc(&serdev->dev, sizeof(*bcmdev), GFP_KERNEL);

drivers/bluetooth/hci_bcm.c static int bcm_serdev_probe(struct serdev_device *serdev) · line 1426

Quoted 5 lines
drivers/bluetooth/hci_bcm.c +2 -0
@@ -1421,6 +1422,8 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
 #endif
 	bcmdev->serdev_hu.serdev = serdev;
 	serdev_device_set_drvdata(serdev, bcmdev);
+	pdev = to_platform_device(bcmdev->dev);
+	bcmdev->irq = platform_get_irq(pdev, 0);

I don't know this driver well enough to be sure, but don't you need some error checking here?

Quoted 2 lines

If this fails (on platforms with no IRQ defined), is an error code in bcmdev->irq going to affect later code that tries to setup IRQs?

not needed to do something here because  bcm_get_resources function check irq <=0 if yes it check if host-wakeup gpio was defined in node and try a gpiod_to_irq.

at the end in bcm_request_irq function i check if irq <=0 if yes return EOPNOTSUPP

Quoted 2 lines

Kevin

Guillaume

#3 lore raw
Quoted 45 lines · guillaume La Roque

hi Kevin,

Quoted 4 lines · Kevin Hilman
Quoted 1 line · Guillaume La Roque

Actually IRQ can be found from GPIO but all platorms don't support

nit: s/platorms/platforms/

will fix in v3

Quoted 36 lines
Quoted 28 lines

gpiod_to_irq, it's the case on amlogic chip.
so to have possibility to use interrupt mode we need to add interrupts field in node and support it in driver.

---
sorry for noise,

v2 is for rebasing on master branch

guillaume

 drivers/bluetooth/hci_bcm.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/bluetooth/hci_bcm.c +1 -0
index f8f5c593a05c..9f52d57c56de 100644
@@ -1409,6 +1409,7 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
 {
 	struct bcm_device *bcmdev;
 	const struct bcm_device_data *data;
+	struct platform_device *pdev;
 	int err;
 
 	bcmdev = devm_kzalloc(&serdev->dev, sizeof(*bcmdev), GFP_KERNEL);

drivers/bluetooth/hci_bcm.c static int bcm_serdev_probe(struct serdev_device *serdev) · line 1426

Quoted 5 lines
drivers/bluetooth/hci_bcm.c +2 -0
@@ -1421,6 +1422,8 @@ static int bcm_serdev_probe(struct serdev_device *serdev)
 #endif
 	bcmdev->serdev_hu.serdev = serdev;
 	serdev_device_set_drvdata(serdev, bcmdev);
+	pdev = to_platform_device(bcmdev->dev);
+	bcmdev->irq = platform_get_irq(pdev, 0);

I don't know this driver well enough to be sure, but don't you need some error checking here?

Quoted 7 lines
Quoted 2 lines

If this fails (on platforms with no IRQ defined), is an error code in bcmdev->irq going to affect later code that tries to setup IRQs?

not needed to do something here because  bcm_get_resources function check irq <=0 if yes it check if host-wakeup gpio was defined in node and try a gpiod_to_irq.

at the end in bcm_request_irq function i check if irq <=0 if yes return EOPNOTSUPP

OK, sounds good. Thanks for clarifying.

Kevin