Skip to contentSkip to conversation

ARM64: dts: meson-gxl: fix Mali GPU compatible string

PATCH New Martin Blumenstingl 3 participants 3 messages Jun 23, 2018 – Jun 27, 2018

Subsystems (2)
Device tree bindings Arm/Amlogic Meson SoC support
lore
Share & tools
lore

Martin Blumenstingl

author reviewer
#0 lore raw

PATCH 1/1 ARM64: dts: meson-gxl: fix Mali GPU compatible string

meson-gxl-mali.dtsi is only used on GXL SoCs. Thus it should use the GXL specific compatible string instead of the GXBB one.
For now this is purely cosmetic since the (out-of-tree) lima driver for this GPU currently uses the "arm,mali-450" match instead of the SoC specific one. However, update the .dts to match the documentation since this driver behavior might change in the future.

Signed-off-by Martin Blumenstingl <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi +1 -1
index eb327664a4d8..6aaafff674f9 100644
@@ -6,7 +6,7 @@
 
 &apb {
 	mali: gpu at c0000 {
-		compatible = "amlogic,meson-gxbb-mali", "arm,mali-450";
+		compatible = "amlogic,meson-gxl-mali", "arm,mali-450";
 		reg = <0x0 0xc0000 0x0 0x40000>;
 		interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 ARM64: dts: meson-gxl: fix Mali GPU compatible string

Quoted 18 lines · Martin Blumenstingl

meson-gxl-mali.dtsi is only used on GXL SoCs. Thus it should use the GXL specific compatible string instead of the GXBB one.
For now this is purely cosmetic since the (out-of-tree) lima driver for this GPU currently uses the "arm,mali-450" match instead of the SoC specific one. However, update the .dts to match the documentation since this driver behavior might change in the future.

Signed-off-by Martin Blumenstingl <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi +0 -0
index eb327664a4d8..6aaafff674f9 100644

arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi line 12

Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi +1 -1
@@ -6,7 +6,7 @@
 
 &apb {
 	mali: gpu at c0000 {
-		compatible = "amlogic,meson-gxbb-mali", "arm,mali-450";
+		compatible = "amlogic,meson-gxl-mali", "arm,mali-450";
 		reg = <0x0 0xc0000 0x0 0x40000>;
 		interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
[...]
Acked-by Neil Armstrong <[email protected]>
maintainer Applied
#2 lore raw

PATCH 1/1 ARM64: dts: meson-gxl: fix Mali GPU compatible string

Quoted 19 lines · Neil Armstrong
Quoted 18 lines · Martin Blumenstingl

meson-gxl-mali.dtsi is only used on GXL SoCs. Thus it should use the GXL specific compatible string instead of the GXBB one.
For now this is purely cosmetic since the (out-of-tree) lima driver for this GPU currently uses the "arm,mali-450" match instead of the SoC specific one. However, update the .dts to match the documentation since this driver behavior might change in the future.

Signed-off-by Martin Blumenstingl <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi +0 -0
index eb327664a4d8..6aaafff674f9 100644
@@ -6,7 +6,7 @@
Quoted 10 lines

arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi line 12

Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-gxl-mali.dtsi +1 -1
 &apb {
 	mali: gpu at c0000 {
-		compatible = "amlogic,meson-gxbb-mali", "arm,mali-450";
+		compatible = "amlogic,meson-gxl-mali", "arm,mali-450";
 		reg = <0x0 0xc0000 0x0 0x40000>;
 		interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>,
[...]
Acked-by Neil Armstrong <[email protected]>

Applied to v4.18/fixes (which I'll be submitting today.)

Kevin