Skip to contentSkip to conversation

Add TI TPS65219 PMIC support for AM642 SK board.

RFC PATCH In review Jerome NEANNE 4 participants 11 messages Jun 13, 2022 – Jun 16, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover Add TI TPS65219 PMIC support for AM642 SK board.

1-Regulators: full implementation
Visual check: cat /sys/kernel/debug/regulator/regulator_summary
Validation: userspace-consumer and virtual-regulator required to test further

enable/disable:
cat /sys/devices/platform/userspace-consumer-VDDSHV_SD_IO_PMIC/state echo disabled > /sys/devices/platform/userspace-consumer-VDDSHV_SD_IO_PMIC/state echo enabled > /sys/devices/platform/userspace-consumer-VDDSHV_SD_IO_PMIC/state

change voltage:
cat /sys/devices/platform/regulator-virtual-ldo1/min_microvolts echo 1000000 > /sys/devices/platform/regulator-virtual-ldo1/min_microvolts echo 3000000 > /sys/devices/platform/regulator-virtual-ldo1/max_microvolts

Voltage changes monitored on LDO1 output on TP84 for k3-am642-sk board

2-Low power Mode (STBY)
A regulator set_mode with a standby mode is implemented (not tested)

3-Reset WARM/COLD
implemented not tested

4-SD Card VSEL_SD
Implemented, appears in summary as: tps65219-LDO1-SEL-SD GPIO control not tested

5-Interrupt Pin (nINT)
Not implemented

6-SW Shutdown
Implemented not tested
Note: enters in competition with other source during probe

7-PB Startup and Shutdown
Can be derived from 65217/8 implementation but postponed, interrupt support required first.

Jerome NEANNE (5):
regulator: dt-bindings: Add TI TPS65219 PMIC bindings
mfd: drivers: Add TI TPS65219 PMIC support
regulator: drivers: Add TI TPS65219 PMIC regulators support
arm64: Kconfig: Introduce CONFIG_MFD_TPS65219 and

    CONFIG_REGULATOR_TPS65219

arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board.

 .../bindings/regulator/ti,tps65219.yaml       | 146 ++++++++
 arch/arm64/boot/dts/ti/k3-am642-sk.dts        | 102 ++++++
 arch/arm64/configs/defconfig                  |   2 +
 drivers/mfd/Kconfig                           |  15 +
 drivers/mfd/Makefile                          |   1 +
 drivers/mfd/tps65219.c                        | 296 ++++++++++++++++
 drivers/regulator/Kconfig                     |   9 +
 drivers/regulator/Makefile                    |   1 +
 drivers/regulator/tps65219-regulator.c        | 334 ++++++++++++++++++
 include/linux/mfd/tps65219.h                  | 245 +++++++++++++
 10 files changed, 1151 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
 create mode 100644 drivers/mfd/tps65219.c
 create mode 100644 drivers/regulator/tps65219-regulator.c
 create mode 100644 include/linux/mfd/tps65219.h
Signature · 1 line
2.17.1
#1 lore raw

RFC PATCH 1/5 regulator: dt-bindings: Add TI TPS65219 PMIC bindings

Add TPS65219 PMIC bindings using json-schema.

Describe required properties and regname-supply. regname-supply is required when bypass mode is used for a regulator. Describes regulator topology.

---
 .../bindings/regulator/ti,tps65219.yaml       | 146 ++++++++++++++++++
 1 file changed, 146 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
Documentation/devicetree/bindings/regulator/ti,tps65219.yaml new file +146 -0
new file mode 100644
index 000000000000..a4717ff4e95b
@@ -0,0 +1,146 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps65219.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI tps65219 Power Management Integrated Circuit regulators
+
+maintainers:
+  - Jerome Neanne <[email protected]>
+
+description: |
+  Regulator nodes should be named to buck<number> and ldo<number>.
+
+properties:
+  compatible:
+    enum:
+      - ti,tps65219
+
+  reg:
+    maxItems: 1
+
+patternProperties:
+  "^buck[1-3]-supply$":
+    description: Input supply phandle of one regulator.
+
+  "^ldo[1-4]-supply$":
+    description: Input supply phandle of one regulator.
+
+  regulators:
+    type: object
+    description: |
+      list of regulators provided by this controller
+
+    patternProperties:
+      "^ldo[1-4]$":
+        type: object
+        $ref: regulator.yaml#
+        description:
+          Properties for single LDO regulator.
+
+        properties:
+          regulator-name:
+            pattern: "^VDD[A-Z0-9_]+$"
+            description:
+              should be "VDDNAME_LDO1", ..., "VDDNAMELDO4"
+
+        unevaluatedProperties: false
+
+      "^buck[1-3]$":
+        type: object
+        $ref: regulator.yaml#
+        description:
+          Properties for single BUCK regulator.
+
+        properties:
+          regulator-name:
+            pattern: "^VDD|VCC[A-Z0-9_]+$"
+            description:
+              should be like "VDD_BUCK1NAME", ..., "VCCBUCK_3NAME"
+
+        unevaluatedProperties: false
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - regulators
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        tps65219: pmic@30 {
+            compatible = "ti,tps65219";
+            reg = <0x30>;
+            buck1-supply = <&vcc_3v3_sys>;
+            buck2-supply = <&vcc_3v3_sys>;
+            buck3-supply = <&vcc_3v3_sys>;
+            ldo1-supply = <&vcc_3v3_sys>;
+            ldo2-supply = <&buck2_reg>;
+            ldo3-supply = <&vcc_3v3_sys>;
+            ldo4-supply = <&vcc_3v3_sys>;
+
+            regulators {
+                buck1_reg: buck1 {
+                    regulator-name = "VDD_CORE";
+                    regulator-min-microvolt = <750000>;
+                    regulator-max-microvolt = <750000>;
+                    regulator-boot-on;
+                    regulator-always-on;
+                };
+
+                buck2_reg: buck2 {
+                    regulator-name = "VCC1V8";
+                    regulator-min-microvolt = <1800000>;
+                    regulator-max-microvolt = <1800000>;
+                    regulator-boot-on;
+                    regulator-always-on;
+                };
+
+                buck3_reg: buck3 {
+                    regulator-name = "VDD_LPDDR4";
+                    regulator-min-microvolt = <1100000>;
+                    regulator-max-microvolt = <1100000>;
+                    regulator-boot-on;
+                    regulator-always-on;
+                };
+
+                ldo1_reg: ldo1 {
+                    regulator-name = "VDDSHV_SD_IO_PMIC";
+                    regulator-min-microvolt = <33000000>;
+                    regulator-max-microvolt = <33000000>;
+                };
+
+                ldo2_reg: ldo2 {
+                    regulator-name = "VDDAR_CORE";
+                    regulator-min-microvolt = <850000>;
+                    regulator-max-microvolt = <850000>;
+                    regulator-boot-on;
+                    regulator-always-on;
+                };
+
+                ldo3_reg: ldo3 {
+                    regulator-name = "VDDA_1V8";
+                    regulator-min-microvolt = <18000000>;
+                    regulator-max-microvolt = <18000000>;
+                    regulator-boot-on;
+                    regulator-always-on;
+                };
+
+                ldo4_reg: ldo4 {
+                    regulator-name = "VDD_PHY_2V5";
+                    regulator-min-microvolt = <25000000>;
+                    regulator-max-microvolt = <25000000>;
+                    regulator-boot-on;
+                    regulator-always-on;
+                };
+            };
+        };
+    };
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/5
#2 lore raw

Re: [RFC PATCH 1/5] regulator: dt-bindings: Add TI TPS65219 PMIC bindings

Quoted 56 lines · Jerome NEANNE

Add TPS65219 PMIC bindings using json-schema.

Describe required properties and regname-supply. regname-supply is required when bypass mode is used for a regulator. Describes regulator topology.

---
 .../bindings/regulator/ti,tps65219.yaml       | 146 ++++++++++++++++++
 1 file changed, 146 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/ti,tps65219.yaml
Documentation/devicetree/bindings/regulator/ti,tps65219.yaml new file +38 -0
new file mode 100644
index 000000000000..a4717ff4e95b
@@ -0,0 +1,146 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps65219.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI tps65219 Power Management Integrated Circuit regulators
+
+maintainers:
+  - Jerome Neanne <[email protected]>
+
+description: |
+  Regulator nodes should be named to buck<number> and ldo<number>.
+
+properties:
+  compatible:
+    enum:
+      - ti,tps65219
+
+  reg:
+    maxItems: 1
+
+patternProperties:
+  "^buck[1-3]-supply$":
+    description: Input supply phandle of one regulator.
+
+  "^ldo[1-4]-supply$":
+    description: Input supply phandle of one regulator.
+
+  regulators:
+    type: object
+    description: |
+      list of regulators provided by this controller
+
+    patternProperties:
+      "^ldo[1-4]$":
+        type: object
+        $ref: regulator.yaml#

Documentation/devicetree/bindings/regulator/ti,tps65219.yaml line 48

Quoted 10 lines
Documentation/devicetree/bindings/regulator/ti,tps65219.yaml new file +10 -0
+        description:
+          Properties for single LDO regulator.
+
+        properties:
+          regulator-name:
+            pattern: "^VDD[A-Z0-9_]+$"
+            description:
+              should be "VDDNAME_LDO1", ..., "VDDNAMELDO4"
+
+        unevaluatedProperties: false

For the indented cases of this it's more readable when 'properties' gets long to put these next to 'type' or '$ref'.

Either way,

#3 lore raw

RFC PATCH 2/5 mfd: drivers: Add TI TPS65219 PMIC support

In reply to Jerome NEANNE

The TPS65219 is a power management IC PMIC designed to supply a wide range of SoCs
in both portable and stationary applications.
Any SoC can control TPS65219 over a standard I2C interface.

It contains the following components:
- Regulators.
- Over Temperature warning and Shut down.
- GPIOs
- Multi Function Pins (MFP)

This patch adds support for tps65219 mfd device. At this time only the functionalities listed below are made available:

- Regulators probe and functionalities
- warm and cold reset support
- SW shutdown support

---
 drivers/mfd/Kconfig          |  15 ++
 drivers/mfd/Makefile         |   1 +
 drivers/mfd/tps65219.c       | 296 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/tps65219.h | 245 +++++++++++++++++++++++++++++
 4 files changed, 557 insertions(+)
 create mode 100644 drivers/mfd/tps65219.c
 create mode 100644 include/linux/mfd/tps65219.h
drivers/mfd/Kconfig +15 -0
index 6a3fd2d75f96..f8639b7b034b 100644
@@ -1555,6 +1555,21 @@ config MFD_TPS65218
 	  This driver can also be built as a module.  If so, the module
 	  will be called tps65218.
 
+config MFD_TPS65219
+	tristate "TI TPS65219 Power Management chips"
+	depends on I2C && OF
+	select MFD_CORE
+	select REGMAP_I2C
+	select REGMAP_IRQ
+	help
+	  If you say yes here you get support for the TPS65219 series of
+	  Power Management chips.
+	  These include voltage regulators, gpio and other features
+	  that are often used in portable devices.
+
+	  This driver can also be built as a module.  If so, the module
+	  will be called tps65219.
+
 config MFD_TPS6586X
 	bool "TI TPS6586x Power Management chips"
 	depends on I2C=y
drivers/mfd/Makefile +1 -0
index 8116c19d5fd4..11bce3e134f4 100644
@@ -101,6 +101,7 @@ obj-$(CONFIG_TPS6507X)		+= tps6507x.o
 obj-$(CONFIG_MFD_TPS65086)	+= tps65086.o
 obj-$(CONFIG_MFD_TPS65217)	+= tps65217.o
 obj-$(CONFIG_MFD_TPS65218)	+= tps65218.o
+obj-$(CONFIG_MFD_TPS65219)	+= tps65219.o
 obj-$(CONFIG_MFD_TPS65910)	+= tps65910.o
 obj-$(CONFIG_MFD_TPS65912)	+= tps65912-core.o
 obj-$(CONFIG_MFD_TPS65912_I2C)	+= tps65912-i2c.o
drivers/mfd/tps65219.c new file +296 -0

296 lines not on this page · raw message

include/linux/mfd/tps65219.h new file +245 -0

245 lines not on this page · raw message

Signature · 1 line
2.17.1
maintainer
#4 lore raw

Re: [RFC PATCH 2/5] mfd: drivers: Add TI TPS65219 PMIC support

drivers/mfd/tps65219.c line 86

Quoted 13 lines · Jerome NEANNE
drivers/mfd/tps65219.c new file +13 -0
+/**
+ * tps65219_reg_read: Read a single tps65219 register.
+ *
+ * @tps: Device to read from.
+ * @reg: Register to read.
+ * @val: Contians the value
+ */
+int tps65219_reg_read(struct tps65219 *tps, unsigned int reg,
+			unsigned int *val)
+{
+	return regmap_read(tps->regmap, reg, val);
+}
+EXPORT_SYMBOL_GPL(tps65219_reg_read);

It is better practice to just expose the regmap and let the function drivers use it, that means the function drivers can just use standard helper functions.

Quoted 10 lines
drivers/mfd/tps65219.c new file +10 -0
+static int tps65219_update_bits(struct tps65219 *tps, unsigned int reg,
+		unsigned int mask, unsigned int val)
+{
+	int ret;
+	unsigned int data;
+
+	ret = regmap_read(tps->regmap, reg, &data);
+	if (ret) {
+		dev_err(tps->dev, "Read from reg 0x%x failed\n", reg);
+		return ret;

drivers/mfd/tps65219.c line 129

Quoted 10 lines
drivers/mfd/tps65219.c new file +10 -0
+	}
+
+	data &= ~mask;
+	data |= val & mask;
+
+	mutex_lock(&tps->tps_lock);
+	ret = tps65219_reg_write(tps, reg, data);
+	if (ret)
+		dev_err(tps->dev, "Write for reg 0x%x failed\n", reg);
+	mutex_unlock(&tps->tps_lock);

It's not clear what this locking is intended to protect. It looks like this should just be using regmap_update_bits().

drivers/mfd/tps65219.c line 206

Quoted 8 lines
drivers/mfd/tps65219.c new file +8 -0
+static const struct regmap_range tps65219_yes_ranges[] = {
+	regmap_reg_range(TPS65219_REG_INT_SOURCE, TPS65219_REG_POWER_UP_STATUS),
+};
+
+static const struct regmap_access_table tps65219_volatile_table = {
+	.yes_ranges = tps65219_yes_ranges,
+	.n_yes_ranges = ARRAY_SIZE(tps65219_yes_ranges),
+};

tps65219_yes_ranges probably needs a clearer name.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#5 lore raw

Re: [RFC PATCH 2/5] mfd: drivers: Add TI TPS65219 PMIC support

In reply to Jerome NEANNE
Quoted 19 lines · Jerome NEANNE

The TPS65219 is a power management IC PMIC designed to supply a wide range of SoCs
in both portable and stationary applications.
Any SoC can control TPS65219 over a standard I2C interface.

It contains the following components:
- Regulators.
- Over Temperature warning and Shut down.
- GPIOs
- Multi Function Pins (MFP)

This patch adds support for tps65219 mfd device. At this time only the functionalities listed below are made available:

- Regulators probe and functionalities
- warm and cold reset support
- SW shutdown support

[...]

drivers/mfd/tps65219.c line 42

Quoted 13 lines
drivers/mfd/tps65219.c new file +13 -0
+/**
+ * pmic_rst_restart: trig tps65219 reset to SOC.
+ *
+ * Trigged via notifier
+ */
+static int pmic_rst_restart(struct notifier_block *this,
+			  unsigned long mode, void *cmd)
+{
+	struct tps65219 *tps;
+
+	tps = container_of(this, struct tps65219, nb);
+	if (tps != NULL) {
+		if (WARMNCOLD)

This value is hard-coded to 1 in the header, so war reset will always be done.

drivers/mfd/tps65219.c line 45

Quoted 3 lines
drivers/mfd/tps65219.c new file +3 -0
+			tps65219_warm_reset(tps);
+		else
+			tps65219_cold_reset(tps);

Doesn't the reboot_notifier get a value like REBOOT_WARM, REBOOT_COLD etc (c.f. enum in linux/reboot.h) so you could properly select?

Kevin

#6 lore raw

RFC PATCH 3/5 regulator: drivers: Add TI TPS65219 PMIC regulators support

In reply to Jerome NEANNE

The regulators set consists of 3 bucks DCDCs and 4 LDOs. The output voltages are configurable and are meant to supply power to the main processor and other components.

Validation:
Visual check: cat /sys/kernel/debug/regulator/regulator_summary
Validation: userspace-consumer and virtual-regulator required to test further

Enable/Disable:
cat /sys/devices/platform/userspace-consumer-VDDSHV_SD_IO_PMIC/state echo disabled > /sys/devices/platform/ userspace-consumer-VDDSHV_SD_IO_PMIC/state
echo enabled > /sys/devices/platform/ userspace-consumer-VDDSHV_SD_IO_PMIC/state

Change voltage:
cat /sys/devices/platform/regulator-virtual-ldo1/min_microvolts echo 1000000 > /sys/devices/platform/regulator-virtual-ldo1/ min_microvolts
echo 3000000 > /sys/devices/platform/regulator-virtual-ldo1/ max_microvolts

---
 drivers/regulator/Kconfig              |   9 +
 drivers/regulator/Makefile             |   1 +
 drivers/regulator/tps65219-regulator.c | 334 +++++++++++++++++++++++++
 3 files changed, 344 insertions(+)
 create mode 100644 drivers/regulator/tps65219-regulator.c
drivers/regulator/Kconfig +9 -0
index 24ce9a17ab4f..1a17b925264c 100644
@@ -1291,6 +1291,15 @@ config REGULATOR_TPS65218
 	  voltage regulators. It supports software based voltage control
 	  for different voltage domains
 
+config REGULATOR_TPS65219
+	tristate "TI TPS65219 Power regulators"
+	depends on MFD_TPS65219 && OF
+	help
+	  This driver supports TPS65219 voltage regulator chips.
+	  TPS65219 series of PMICs have 3 single phase BUCKs & 4 LDOs
+	  voltage regulators. It supports software based voltage control
+	  for different voltage domains
+
 config REGULATOR_TPS6524X
 	tristate "TI TPS6524X Power regulators"
 	depends on SPI
drivers/regulator/Makefile +1 -0
index 8c2f82206b94..790839810e8e 100644
@@ -152,6 +152,7 @@ obj-$(CONFIG_REGULATOR_TPS65086) += tps65086-regulator.o
 obj-$(CONFIG_REGULATOR_TPS65090) += tps65090-regulator.o
 obj-$(CONFIG_REGULATOR_TPS65217) += tps65217-regulator.o
 obj-$(CONFIG_REGULATOR_TPS65218) += tps65218-regulator.o
+obj-$(CONFIG_REGULATOR_TPS65219) += tps65219-regulator.o
 obj-$(CONFIG_REGULATOR_TPS6524X) += tps6524x-regulator.o
 obj-$(CONFIG_REGULATOR_TPS6586X) += tps6586x-regulator.o
 obj-$(CONFIG_REGULATOR_TPS65910) += tps65910-regulator.o
drivers/regulator/tps65219-regulator.c new file +334 -0

334 lines not on this page · raw message

Signature · 1 line
2.17.1
maintainer
#7 lore raw

Re: [RFC PATCH 3/5] regulator: drivers: Add TI TPS65219 PMIC regulators support

drivers/regulator/tps65219-regulator.c line 93

Quoted 8 lines · Jerome NEANNE
drivers/regulator/tps65219-regulator.c new file +8 -0
+static int tps65219_pmic_enable(struct regulator_dev *dev)
+{
+	struct tps65219 *tps = rdev_get_drvdata(dev);
+	int rid = rdev_get_id(dev);
+	int ret;
+
+
+

Lots of random blank space here.

drivers/regulator/tps65219-regulator.c line 96

Quoted 3 lines
drivers/regulator/tps65219-regulator.c new file +3 -0
+	if (rid < TPS65219_BUCK_1 || rid > TPS65219_LDO_4)
+		return -EINVAL;
+

If a regulator doesn't support an operation it shouldn't be providing it, no need to check here.

drivers/regulator/tps65219-regulator.c line 98

Quoted 2 lines
drivers/regulator/tps65219-regulator.c new file +2 -0
+	ret = tps65219_set_bits(tps, dev->desc->enable_reg,
+				 dev->desc->enable_mask, dev->desc->enable_mask);

If you provide the regmap to the child devices then this can use the standard regmap helpers for most of the operations, meaning most of the operations in the driver can be removed.

Quoted 1 line

+/* generic regulator_set_bypass_regmap does not match requirements use custom instead */

In what way? Please also try to keep within 80 columns normally.

drivers/regulator/tps65219-regulator.c line 172

Quoted 5 lines
drivers/regulator/tps65219-regulator.c new file +5 -0
+	if (dev->desc->ops->is_enabled) {
+		dev_err(tps->dev, "%s LDO%d is enabled, should be shut down to set bypass ",
+					 __func__, rid);
+		return -EBUSY;
+	}

This is testing if there is an enable operation, not if the regulator is enabled.

drivers/regulator/tps65219-regulator.c line 177

Quoted 4 lines
drivers/regulator/tps65219-regulator.c new file +4 -0
+	if (enable) {
+		dev_dbg(tps->dev, "%s, LDO%d already in bypass mode", __func__, rid);
+		return ret;
+	}

This is not a problem, just silently succeed.

drivers/regulator/tps65219-regulator.c line 291

Quoted 6 lines
drivers/regulator/tps65219-regulator.c new file +6 -0
+	/* Allocate memory for strobes */
+	tps->strobes = devm_kcalloc(&pdev->dev,
+				    TPS65219_NUM_REGULATOR, sizeof(u8),
+				    GFP_KERNEL);
+	if (!tps->strobes)
+		return -ENOMEM;

These are never referenced anywhere else in the driver, no need to allocate them.

drivers/regulator/tps65219-regulator.c line 308

Quoted 6 lines
drivers/regulator/tps65219-regulator.c new file +6 -0
+		ret = regmap_read(tps->regmap, regulators[i].bypass_reg, &val);
+		if (ret) {
+			dev_err(tps->dev, "dev_err failed to map register for %s regulator\n",
+				pdev->name);
+			return ret;
+		}

I'm not clear what this check is intended to do, it at least needs to be better documented.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#8 lore raw

RFC PATCH 4/5 arm64: Kconfig: Introduce CONFIG_MFD_TPS65219 and CONFIG_REGULATOR_TPS65219

In reply to Jerome NEANNE

This adds a Kconfig option to support TPS65219 PMIC, MFD and Regulators

---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/configs/defconfig +2 -0
index 08c6f769df9a..8d9b359a6663 100644
@@ -609,6 +609,7 @@ CONFIG_MFD_SPMI_PMIC=y
 CONFIG_MFD_RK808=y
 CONFIG_MFD_SEC_CORE=y
 CONFIG_MFD_SL28CPLD=y
+CONFIG_MFD_TPS65219=m
 CONFIG_MFD_ROHM_BD718XX=y
 CONFIG_MFD_WCD934X=m
 CONFIG_REGULATOR_FIXED_VOLTAGE=y
@@ -634,6 +635,7 @@ CONFIG_REGULATOR_QCOM_SPMI=y
 CONFIG_REGULATOR_RK808=y
 CONFIG_REGULATOR_S2MPS11=y
 CONFIG_REGULATOR_TPS65132=m
+CONFIG_REGULATOR_TPS65219=m
 CONFIG_REGULATOR_VCTRL=m
 CONFIG_RC_CORE=m
 CONFIG_RC_DECODERS=y
Signature · 1 line
2.17.1
#9 lore raw

RFC PATCH 5/5 arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board.

In reply to Jerome NEANNE

Add support fot the TI Power Management IC TPS65219 on the AM642 SKEVM board

---
 arch/arm64/boot/dts/ti/k3-am642-sk.dts | 102 +++++++++++++++++++++++++
 1 file changed, 102 insertions(+)
arch/arm64/boot/dts/ti/k3-am642-sk.dts +102 -0
index 8424cd071955..7886bb109160 100644
@@ -69,6 +69,20 @@
 		vin-supply = <&vcc_3v3_sys>;
 		gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
 	};
+
+	vsel_sd_nddr: gpio-regulator {
+		compatible = "regulator-gpio";
+		pinctrl-names = "default";
+		pinctrl-0 = <&vsel_sd_nddr_pins_default>;
+		regulator-name = "tps65219-LDO1-SEL-SD";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		vin-supply = <&ldo1_reg>;
+		gpios = <&main_gpio0 45 GPIO_ACTIVE_HIGH>;
+		states = <1800000 0x0>,
+			 <3300000 0x1>;
+	};
 };
 
 &main_pmx0 {
@@ -85,6 +99,13 @@
 		>;
 	};
 
+	main_i2c0_pins_default: main-i2c0-pins-default {
+		pinctrl-single,pins = <
+			AM64X_IOPAD(0x0260, PIN_INPUT_PULLUP, 0) /* (A18) I2C0_SCL */
+			AM64X_IOPAD(0x0264, PIN_INPUT_PULLUP, 0) /* (B18) I2C0_SDA */
+		>;
+	};
+
 	main_i2c1_pins_default: main-i2c1-pins-default {
 		pinctrl-single,pins = <
 			AM64X_IOPAD(0x0268, PIN_INPUT_PULLUP, 0) /* (C18) I2C1_SCL */
@@ -148,6 +169,12 @@
 			AM64X_IOPAD(0x0008, PIN_INPUT, 0) /* (N19) OSPI0_DQS */
 		>;
 	};
+
+	vsel_sd_nddr_pins_default: vsel-sd-nddr-pins-default {
+		pinctrl-single,pins = <
+			AM64X_IOPAD(0x00b4, PIN_OUTPUT, 0) /* (45x4=0xb4) WKUP_GPIO0_45 */
+		>;
+	};
 };
 
 &mcu_uart0 {
@@ -191,6 +218,81 @@
 	status = "disabled";
 };
 
+&main_i2c0 {
+	pinctrl-nammain-i2c0-pins-defaultes = "default";
+	pinctrl-0 = <&main_i2c0_pins_default>;
+	clock-frequency = <400000>;
+	status = "okay";
+
+	tps65219: pmic@30 {
+		compatible = "ti,tps65219";
+		reg = <0x30>;
+		buck1-supply = <&vcc_3v3_sys>;
+		buck2-supply = <&vcc_3v3_sys>;
+		buck3-supply = <&vcc_3v3_sys>;
+		ldo1-supply = <&vcc_3v3_sys>;
+		ldo2-supply = <&buck2_reg>;
+		ldo3-supply = <&vcc_3v3_sys>;
+		ldo4-supply = <&vcc_3v3_sys>;
+
+		regulators {
+			buck1_reg: buck1 {
+				regulator-name = "VDD_CORE";
+				regulator-min-microvolt = <750000>;
+				regulator-max-microvolt = <1000000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck2_reg: buck2 {
+				regulator-name = "VCC1V8";
+				regulator-min-microvolt = <1700000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			buck3_reg: buck3 {
+				regulator-name = "VDD_LPDDR4";
+				regulator-min-microvolt = <1100000>;
+				regulator-max-microvolt = <1100000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo1_reg: ldo1 {
+				regulator-name = "VDDSHV_SD_IO_PMIC";
+				regulator-min-microvolt = <1000000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-allow-bypass;
+			};
+
+			ldo2_reg: ldo2 {
+				regulator-name = "VDDAR_CORE";
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <850000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo3_reg: ldo3 {
+				regulator-name = "VDDA_1V8";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+
+			ldo4_reg: ldo4 {
+				regulator-name = "VDD_PHY_2V5";
+				regulator-min-microvolt = <2500000>;
+				regulator-max-microvolt = <2500000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};
+		};
+	};
+};
 &main_i2c1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&main_i2c1_pins_default>;
Signature · 1 line
2.17.1
maintainer
#10 lore raw

Re: [RFC PATCH 5/5] arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board.

arch/arm64/boot/dts/ti/k3-am642-sk.dts line 253

Quoted 7 lines · Jerome NEANNE
arch/arm64/boot/dts/ti/k3-am642-sk.dts +7 -0
+			buck2_reg: buck2 {
+				regulator-name = "VCC1V8";
+				regulator-min-microvolt = <1700000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-boot-on;
+				regulator-always-on;
+			};

The supply labelled 1V8 can vary between 1.7V and 1.8V? That at least deserves a comment.

You should only set boot-on for supplies where it is not possible to read the current state.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel