Skip to contentSkip to conversation

ARM64: dts: meson: reduce odroid-c2 eMMC maximum rate

PATCH Applied Jerome Brunet 3 participants 5 messages Mar 2, 2018 – Mar 28, 2018

Subsystems (3)
Stable branch Device tree bindings Arm/Amlogic Meson SoC support
lore
Share & tools
lore

Jerome Brunet

author reviewer
#0 lore raw

PATCH 1/1 ARM64: dts: meson: reduce odroid-c2 eMMC maximum rate

Different modules maybe installed by the user on the eMMC connector of the odroid-c2. While the red modules are working without an issue, it seems some black modules (apparently Samsung based) are having issue at 200MHz

While the tuning algorithm introduced in v4.14 enables high speed modes on every other tested designs, it seems a problem remains for this particular combination of board and eMMC module.

Lowering the maximum frequency of the eMMC on this board until we can figure out a better solution.

Fixes d341ca88eead ("mmc: meson-gx: rework tuning function")
Suggested-by Ellie Reeves <[email protected]>
Signed-off-by Jerome Brunet <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +1 -1
index 73a030a5ecf3..43475139576c 100644
@@ -311,7 +311,7 @@
 	pinctrl-names = "default", "clk-gate";
 
 	bus-width = <8>;
-	max-frequency = <200000000>;
+	max-frequency = <100000000>;
 	non-removable;
 	disable-wp;
 	cap-mmc-highspeed;
Signature · 1 line
2.14.3
maintainer Applied
#1 lore raw
Quoted 9 lines · Jerome Brunet

Different modules maybe installed by the user on the eMMC connector of the odroid-c2. While the red modules are working without an issue, it seems some black modules (apparently Samsung based) are having issue at 200MHz

While the tuning algorithm introduced in v4.14 enables high speed modes on every other tested designs, it seems a problem remains for this particular combination of board and eMMC module.

Quoted 6 lines

Lowering the maximum frequency of the eMMC on this board until we can figure out a better solution.

Fixes d341ca88eead ("mmc: meson-gx: rework tuning function")
Suggested-by Ellie Reeves <[email protected]>
Signed-off-by Jerome Brunet <[email protected]>

Applied to v4.17/dt64 and Cc'd to stable,

Kevin

maintainer
#2 lore raw

PATCH 1/1 ARM64: dts: meson: reduce odroid-c2 eMMC maximum rate

In reply to Jerome Brunet
Quoted 9 lines · Jerome Brunet

Different modules maybe installed by the user on the eMMC connector of the odroid-c2. While the red modules are working without an issue, it seems some black modules (apparently Samsung based) are having issue at 200MHz

While the tuning algorithm introduced in v4.14 enables high speed modes on every other tested designs, it seems a problem remains for this particular combination of board and eMMC module.

Quoted 6 lines

Lowering the maximum frequency of the eMMC on this board until we can figure out a better solution.

Fixes d341ca88eead ("mmc: meson-gx: rework tuning function")
Suggested-by Ellie Reeves <[email protected]>
Signed-off-by Jerome Brunet <[email protected]>

Now in mainline as commit c04ffa71ff49 upstream.

The mainline patch has "Cc: stable at vger.kernel.org", but it doesn't seem to have appeared in stable yet, and I've verified that it applies cleanly to linux-4.15.y and linux-4.14.y.

Kevin

Quoted 20 lines
---
 arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts +1 -2
index 73a030a5ecf3..43475139576c 100644
@@ -311,7 +311,7 @@
        pinctrl-names = "default", "clk-gate";
 
        bus-width = <8>;
-       max-frequency = <200000000>;
+       max-frequency = <100000000>;
        non-removable;
        disable-wp;
        cap-mmc-highspeed;
--

2.14.3

maintainer
#3 lore raw

PATCH 1/1 ARM64: dts: meson: reduce odroid-c2 eMMC maximum rate

Quoted 10 lines · Kevin Hilman
Quoted 9 lines · Jerome Brunet

Different modules maybe installed by the user on the eMMC connector of the odroid-c2. While the red modules are working without an issue, it seems some black modules (apparently Samsung based) are having issue at 200MHz

While the tuning algorithm introduced in v4.14 enables high speed modes on every other tested designs, it seems a problem remains for this particular combination of board and eMMC module.

Quoted 8 lines
Quoted 6 lines

Lowering the maximum frequency of the eMMC on this board until we can figure out a better solution.

Fixes d341ca88eead ("mmc: meson-gx: rework tuning function")
Suggested-by Ellie Reeves <[email protected]>
Signed-off-by Jerome Brunet <[email protected]>

Now in mainline as commit c04ffa71ff49 upstream.

Really? I do not see it in Linus's tree, are you sure about that?

$ git show c04ffa71ff49
fatal: ambiguous argument 'c04ffa71ff49': unknown revision or path not in the working tree.

thanks,

greg k-h

maintainer
#4 lore raw

PATCH 1/1 ARM64: dts: meson: reduce odroid-c2 eMMC maximum rate

Quoted 18 lines · Greg KH
Quoted 17 lines · Kevin Hilman
Quoted 15 lines · Jerome Brunet

Different modules maybe installed by the user on the eMMC connector of the odroid-c2. While the red modules are working without an issue, it seems some black modules (apparently Samsung based) are having issue at 200MHz

While the tuning algorithm introduced in v4.14 enables high speed modes on every other tested designs, it seems a problem remains for this particular combination of board and eMMC module.

Lowering the maximum frequency of the eMMC on this board until we can figure out a better solution.

Fixes d341ca88eead ("mmc: meson-gx: rework tuning function")
Suggested-by Ellie Reeves <[email protected]>
Signed-off-by Jerome Brunet <[email protected]>
Quoted 6 lines
Quoted 1 line

Now in mainline as commit c04ffa71ff49 upstream.

Really? I do not see it in Linus's tree, are you sure about that?

$ git show c04ffa71ff49
fatal: ambiguous argument 'c04ffa71ff49': unknown revision or path not in the working tree.

Oops, you're right. It's still in arm-soc, not yet in mainline. Sorry for the noise.

Kevin