Skip to contentSkip to conversation

package/tvheadend: bump version

PATCH New Bernd Kuhls 3 participants 6 messages Sep 4, 2017 – Sep 6, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/tvheadend: bump version

Add optional dependencies to

- libva
ffmpeg depends on libva, libva depends on xorg, so no need to add them to _DEPENDENCIES
- libtheora, libvorbis, libvpx, opus, x264, x265

---
 package/tvheadend/Config.in      |  2 --
 package/tvheadend/tvheadend.hash |  2 +-
 package/tvheadend/tvheadend.mk   | 51 ++++++++++++++++++++++++++++++++++++++--
 3 files changed, 50 insertions(+), 5 deletions(-)
package/tvheadend/Config.in +0 -2
index fc39d6f48..67a4b1419 100644
@@ -12,8 +12,6 @@ config BR2_PACKAGE_TVHEADEND
 	select BR2_PACKAGE_DTV_SCAN_TABLES
 	select BR2_PACKAGE_FFMPEG_AVRESAMPLE if BR2_PACKAGE_FFMPEG
 	select BR2_PACKAGE_FFMPEG_SWSCALE if BR2_PACKAGE_FFMPEG
-	select BR2_PACKAGE_LIBVPX if BR2_PACKAGE_FFMPEG && !BR2_bfin # libvpx
-	select BR2_PACKAGE_X264 if BR2_PACKAGE_FFMPEG
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	select BR2_PACKAGE_OPENSSL
 	help
package/tvheadend/tvheadend.hash +1 -1
index 3154b3276..a69f8590c 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 1994e379c798b118243e70f7fa38064a9b288d6e38b9ced0e8ad465f5d2e8fd9  tvheadend-54e63e3f9af8fdc0d23f61f3cda7fa7b246c1732.tar.gz
+sha256 5265960bb5569d5d978c434042824484b946945d6ca3b6f530f14f8b3ff2fc02  tvheadend-aa052acbe8cc3873bf9ed2c64dbc953124bcda16.tar.gz
package/tvheadend/tvheadend.mk +49 -2

76 lines not on this page · raw message

Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/tvheadend: bump version

Hello,

Quoted 5 lines · Bernd Kuhls

Add optional dependencies to

- libva
ffmpeg depends on libva, libva depends on xorg, so no need to add them to _DEPENDENCIES

I don't see ffmpeg depending on libva, where do you see that ?

Quoted 1 line

- libtheora, libvorbis, libvpx, opus, x264, x265

You're doing more in this commit: you're removing libvpx as a mandatory dependency, as well as x264.

It would be good to have a more descriptive commit log when the bump isn't trivial.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/tvheadend: bump version

Thomas, All,

On 2017-09-05 22:13 +0200, Thomas Petazzoni spake thusly:

Quoted 8 lines · Bernd Kuhls
Quoted 5 lines

Add optional dependencies to

- libva
ffmpeg depends on libva, libva depends on xorg, so no need to add them to _DEPENDENCIES

I don't see ffmpeg depending on libva, where do you see that ?

Yet it does, see line 243. ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/tvheadend: bump version

Hello,

Quoted 6 lines · Yann E. MORIN

Thomas, All,

On 2017-09-05 22:13 +0200, Thomas Petazzoni spake thusly:

Quoted 3 lines · Bernd Kuhls
Quoted 2 lines

Add optional dependencies to

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

- libva
ffmpeg depends on libva, libva depends on xorg, so no need to add them to _DEPENDENCIES

I don't see ffmpeg depending on libva, where do you see that ?

Yet it does, see line 243. ;-)

Well, it will depend on libva if it's enabled. But I don't see anything in tvheadend or ffmpeg that forces libva to be enabled.

Perhaps I'm missing something obvious here.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 package/tvheadend: bump version

On 2017-09-06 08:55 +0200, Thomas Petazzoni spake thusly:

Quoted 13 lines

Hello,

Quoted 10 lines · Yann E. MORIN

Thomas, All,

On 2017-09-05 22:13 +0200, Thomas Petazzoni spake thusly:

Quoted 7 lines · Bernd Kuhls
Quoted 5 lines

Add optional dependencies to

- libva
ffmpeg depends on libva, libva depends on xorg, so no need to add them to _DEPENDENCIES

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

I don't see ffmpeg depending on libva, where do you see that ?

Yet it does, see line 243. ;-)

Well, it will depend on libva if it's enabled. But I don't see anything in tvheadend or ffmpeg that forces libva to be enabled.

No, but the commit log says it is adding _optional_ dependency to libva.

So indeed nothing forces libva to be on, but if it is, then support is explicitly enabled, otherwise it is explicitly disabled.

That's how I understand the patch.

But yes, the patch does more than one thing at a time, so should be split.

Regards,
Yann E. MORIN.

Quoted 7 lines

Perhaps I'm missing something obvious here.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'