Point out merged submodule maintainers as better addresses for patches
PATCH 1/1 Point out merged submodule maintainers as better addresses for patches
Junio doesn't directly manage the git-gui or gitk-git subdirectories within git.git; these are currently managed by other individuals and then periodically merged to git.git. Users often send patches to Junio for these directories when they should be directed at the current maintainer instead, so we should point out these special cases in the SubmittingPatches documentation.
---
Just a suggestion. Might help people who are new to the Git community to get involved.
Documentation/SubmittingPatches | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
Documentation/SubmittingPatches +7 -1
@@ -34,10 +34,16 @@ Checklist (and a short version for the impatient): - if your name is not writable in ASCII, make sure that you send off a message in the correct encoding. - send the patch to the list ([email protected]) and the - maintainer ([email protected]). If you use + active maintainer (see below). If you use git-send-email(1), please test it first by sending email to yourself. + Active maintainers: + + - git-gui/ submodule: [email protected] + - gitk-git/ submodule: [email protected] + - Everything else: [email protected] + Long version: I started reading over the SubmittingPatches document for Linux
Signature · 1 line
1.5.4.rc2.1097.gb6e0d
Quoted 6 lines · Shawn O. Pearce
Junio doesn't directly manage the git-gui or gitk-git subdirectories within git.git; these are currently managed by other individuals and then periodically merged to git.git. Users often send patches to Junio for these directories when they should be directed at the current maintainer instead, so we should point out these special cases in the SubmittingPatches documentation.
This is a good start, but I think it would be good to mention that contributors should at least Cc: the people who have been heavily involved in the past in the surrounding area of the code or documentation (not necessarily the last person who touched the area) the patch attempts to improve and/or enhance.
Parts of the system are "actively managed" by people other than me even though they aren't merged with the subtree strategy. The areas I mentioned in MaintNotes (in 'todo') are:
- git-svn is generally deferred to Eric, unless the patch is truly trivial.
- Documentation/user-manual.txt is primarily JBF's bailiwick.
- Nico is the guy around pack generation.
- Jakub, Luben and Pasky are more familiar than I am with gitweb.
In fact, I would rather see any nontrivial patch to be first sent "To: " such people with "Cc: " the list. After it has been improved into a good enough shape in the discussion that follows (i.e. success stories to back it up, and without regression reports and objections), I can pick up the last round directly from the list, or the active maintainer in the area (if exists; it might be a better wording to call them "subsystem maintainers") can forward it to me to apply after a final submission is made. Sending the final submission to the subsystem maintainer who forwards it to the higher level is what the kernel folks regularly do, but I do not think we are large enough to require such a formality.