--exec-path not always honored
I noticed this failure if I run git from the build directory:
$ ./git --exec-path=. gc
usage: git pack-objects [{ -q | --progress | --all-progress }]
[--max-pack-size=N] [--local] [--incremental]
[--window=N] [--window-memory=N] [--depth=N]
[--no-reuse-delta] [--no-reuse-object] [--delta-base-offset]
[--threads=N] [--non-empty] [--revs [--unpacked | --all]*] [--reflog]
[--include-tag] [--keep-unreachable | --unpack-unreachable]
--stdout | base-name < ref-or-object-list
error: failed to run repackThe reason is that the version of pack-objects that I have installed in $prefix does not know the option --kept-pack-only, which ./git-repack passes along. It doesn't matter whether I have $prefix in PATH or not.
But on the other hand:
$ ./git --exec-path=. repack -a -d Counting objects: 104070, done. Delta compression using 2 threads. Compressing objects: 100% (26161/26161), done. Writing objects: 100% (104070/104070), done. Total 104070 (delta 76376), reused 104070 (delta 76376)
works just fine whereas without --exec-path it fails like git-gc above.
git-gc is a builtin. Should git setenv("GIT_EXEC_PATH") before it runs other git commands?
-- Hannes
Quoted 2 lines · Johannes Sixt
git-gc is a builtin. Should git
setenv("GIT_EXEC_PATH")before it runs other git commands?
I think we just never have bothered about such a use case, but you are right. It probably is a good solution, although setenv makes me feel a bit nervous for no rational reason.
Quoted 8 lines · Junio C Hamano
Quoted 2 lines · Johannes Sixt
git-gc is a builtin. Should git
setenv("GIT_EXEC_PATH")before it runs other git commands?I think we just never have bothered about such a use case, but you are right. It probably is a good solution, although setenv makes me feel a bit nervous for no rational reason.
This patch fixes the use case and is IMO the most logical solution.
exec_cmd.c +4 -0
@@ -61,6 +61,10 @@ const char *git_extract_argv0_path(const char *argv0)void git_set_argv_exec_path (const char *exec_path) { argv_exec_path = exec_path; +/* +* Propagate this setting to external programs. +*/ +setenv (EXEC_PATH_ENVIRONMENT , exec_path,1 ); }
Hi,
Quoted 3 lines · Johannes Sixt
I noticed this failure if I run git from the build directory:
$ ./git --exec-path=. gc
I am not sure if "." is what you think it is; I imagine it would be $GIT_DIR by the time the PATH variable is adjusted.
Could you try again with
$ ./git --exec-path="$(pwd)" gc
?
Thanks,
Dscho
Quoted 8 lines · Johannes Schindelin
Quoted 3 lines · Johannes Sixt
I noticed this failure if I run git from the build directory:
$ ./git --exec-path=. gcI am not sure if "." is what you think it is; I imagine it would be $GIT_DIR by the time the PATH variable is adjusted.
This would be *very* bogus, wouldn't it?
Quoted 5 lines
Could you try again with
$ ./git --exec-path="$(pwd)" gc?
It fails in the same way:
$ ./git --exec-path=$(pwd) gc usage: git pack-objects blah blah... error: failed to run repack
-- Hannes