autoconf: Add checking for BSD-compatibile 'install' program
PATCH 1/1 autoconf: Add checking for BSD-compatibile 'install' program
Uncomment AC_PROG_INSTALL' macro in configure.ac, and setting INSTALL' variable in config.mak.in
Add install-sh' shell script (required when using AC_PROG_INSTALL' macro) scriptversion=2005-11-07.23, taken from KDE SDK 3.5.3.
---
Perhaps `install-sh' script should be replaced by something simplier, for example by script which was sent to git mailing list, but AFAIK not accepted.
config.mak.in | 2 configure.ac | 3 install-sh | 401 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 404 insertions(+), 2 deletions(-)
config.mak.in +1 -1
@@ -4,7 +4,7 @@ # @configure_input@ CC = @CC@ AR = @AR@ TAR = @TAR@ -#INSTALL = @INSTALL@ # needs install-sh or install.sh in sources +INSTALL = @INSTALL@ prefix = @prefix@ exec_prefix = @exec_prefix@
configure.ac +2 -1
@@ -92,11 +92,12 @@ AC_SUBST(NO_PYTHON) AC_SUBST(PYTHON_PATH) +## ---------------------------------------------------------------------- ## Checks for programs. AC_MSG_NOTICE([CHECKS for programs]) # AC_PROG_CC -#AC_PROG_INSTALL # needs install-sh or install.sh in sources +AC_PROG_INSTALL AC_CHECK_TOOL(AR, ar, :) AC_CHECK_PROGS(TAR, [gtar tar]) #
install-sh new file +401 -0
401 lines not on this page · raw message
Signature · 1 line
1.4.2
Quoted 11 lines · Jakub Narebski
Uncomment
AC_PROG_INSTALL' macro in configure.ac, and settingINSTALL' variable in config.mak.inAdd
install-sh' shell script (required when usingAC_PROG_INSTALL' macro) scriptversion=2005-11-07.23, taken from KDE SDK 3.5.3.Signed-off-by Jakub Narebski <[email protected]>---
Perhaps `install-sh' script should be replaced by something simplier, for example by script which was sent to git mailing list, but AFAIK not accepted.
That somehow sounds like whining. I do not think it was never proposed for inclusion but was just offered as a friendly "somebody else might find it useful".
In any case, I have two issues, but one non-issue first. I am not opposed to including install-sh that is maintained somewhere upstream and GPLv2 compatible.
- I do not particularly like to have too many autoconf related cruft at the toplevel, and I am wondering if we can move it to say compat/install-sh.
- I suspect this fall-back would set "INSTALL = ./install-sh" (if you have it in compat, "INSTALL = compat/install-sh"). I wonder if it breaks builds in subdirectories
(i.e. Documentation/ and templates/).
Quoted 14 lines · Junio C Hamano
Quoted 11 lines · Jakub Narebski
Uncomment
AC_PROG_INSTALL' macro in configure.ac, and settingINSTALL' variable in config.mak.inAdd
install-sh' shell script (required when usingAC_PROG_INSTALL' macro) scriptversion=2005-11-07.23, taken from KDE SDK 3.5.3.Signed-off-by Jakub Narebski <[email protected]>---
Perhaps `install-sh' script should be replaced by something simplier, for example by script which was sent to git mailing list, but AFAIK not accepted.
Quoted 3 lines
That somehow sounds like whining. I do not think it was never proposed for inclusion but was just offered as a friendly "somebody else might find it useful".
Sorry, my mistake. I thought that the install-sh script was proposed as solution for platforms lacking install program...
Quoted 7 lines
In any case, I have two issues, but one non-issue first. I am not opposed to including install-sh that is maintained somewhere upstream and GPLv2 compatible.
- I do not particularly like to have too many autoconf related cruft at the toplevel, and I am wondering if we can move it to say compat/install-sh.
We can do this by adding AC_CONFIG_AUX_DIR(DIR) to configure.ac, where DIR would be for example 'compat/' or 'compat/autoconf/'
Quoted 4 lines
- I suspect this fall-back would set "INSTALL = ./install-sh" (if you have it in compat, "INSTALL = compat/install-sh"). I wonder if it breaks builds in subdirectories
(i.e.Documentation/and templates/).
Yes, it sets "INSTALL = ./install-sh -c". And it does make problems for e.g. 'make install-doc'. I don't know how this should be resolved...
Signature · 3 lines
Jakub Narebski Warsaw, Poland ShadeHawk on #git