Skip to contentSkip to conversation

PCI patches for 2.6.16-rc1

PATCH In review Greg KH 4 participants 7 messages Feb 1, 2006

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 1/1 PCI patches for 2.6.16-rc1

Here are some small PCI patches against your latest git tree. They have all been in the -mm tree for a while with no problems.

They do the following:
- document some feature-removal things for the future
- add support for amd pci hotplug devices to the shpchp driver.
- fix bugs and update the ppc64 rpaphp pci hotplug driver.
- add some new and remove some duplicate pci ids.
- make it more obvious that some msi functions are really being used.
- fix a bug on some boxes that have bogus MCFG tables.

Please pull from:

	rsync://rsync.kernel.org/pub/scm/linux/kernel/git/gregkh/pci-2.6.git/
or if master.kernel.org hasn't synced up yet:
	master.kernel.org:/pub/scm/linux/kernel/git/gregkh/pci-2.6.git/

The full patches will be sent to the linux-pci mailing list, if anyone wants to see them.

thanks,

greg k-h

 Documentation/feature-removal-schedule.txt |   14 +
 arch/i386/pci/irq.c                        |    5 
 arch/i386/pci/mmconfig.c                   |   15 +
 arch/x86_64/pci/mmconfig.c                 |   19 +
 drivers/pci/hotplug/Kconfig                |    3 
 drivers/pci/hotplug/acpiphp_ibm.c          |   21 --
 drivers/pci/hotplug/ibmphp_core.c          |    4 
 drivers/pci/hotplug/rpadlpar_core.c        |   64 +++---
 drivers/pci/hotplug/rpaphp.h               |   14 -
 drivers/pci/hotplug/rpaphp_core.c          |  114 ++++++-----
 drivers/pci/hotplug/rpaphp_pci.c           |  277 +----------------------------
 drivers/pci/hotplug/rpaphp_slot.c          |   16 -
 drivers/pci/hotplug/shpchp.h               |   94 +++++++++
 drivers/pci/hotplug/shpchp_ctrl.c          |   12 +
 drivers/pci/msi.c                          |    8 
 drivers/pci/msi.h                          |    6 
 drivers/pci/pci.c                          |    2 
 drivers/pci/setup-res.c                    |    1 
 drivers/video/cyblafb.c                    |    1 
 include/linux/pci.h                        |    2 
 include/linux/pci_ids.h                    |   16 -
 21 files changed, 299 insertions(+), 409 deletions(-)

Adrian Bunk:
PCI: schedule PCI_LEGACY_PROC for removal
PCI: drivers/pci/pci.c: #if 0 pci_find_ext_capability()

Andi Kleen:
PCI: handle bogus MCFG entries

Arthur Othieno:
PCI: cyblafb: remove pci_module_init() return, really.

Grant Coady:
PCI: pci_ids: remove duplicates gathered during merge period

Grant Grundler:
PCI: make it easier to see that set_msi_affinity() is used

Jason Gaston:
PCI: irq and pci_ids: patch for Intel ICH8

Keck, David:
PCI Hotplug: shpchp: AMD POGO errata fix

linas:
PCI Hotplug: PCI panic on dlpar add (add pci slot to running partition) PCI Hotplug/powerpc: module build break

[email protected]:
powerpc/PCI hotplug: remove rpaphp_find_bus() powerpc/PCI hotplug: merge config_pci_adapter powerpc/PCI hotplug: remove remove_bus_device() powerpc/PCI hotplug: de-convolute rpaphp_unconfig_pci_adap powerpc/PCI hotplug: remove rpaphp_fixup_new_pci_devices() powerpc/PCI hotplug: shuffle error checking to better location. powerpc/PCI hotplug: minor cleanup forward decls powerpc/PCI hotplug: merge rpaphp_enable_pci_slot() powerpc/PCI hotplug: cleanup: add prefix

Mark Rustad:
PCI: restore 2 missing pci ids

Pavel Machek:
PCI Hotplug: fix up coding style issues
PCI Hotplug: fix up Kconfig help text

Richard Knutsson:
pci: Schedule removal of pci_module_init

#1 lore raw
Quoted 8 lines · Greg KH

linas:
PCI Hotplug: PCI panic on dlpar add (add pci slot to running partition) PCI Hotplug/powerpc: module build break

[email protected]:
powerpc/PCI hotplug: remove rpaphp_find_bus() powerpc/PCI hotplug: merge config_pci_adapter

Looks like Linas Vepstas doesn't have a good email address in his From:
fields.. As a result, the logs are nasty.

Linas - could you _please_ fix your email setup, of if your email setup is good, could whoever added the bogus "From: " line to the email please NOT DO THAT HORRIBLE THING?

Greg, if you notice things like this, can you fix them up or bounce them back to the author? Yeah, I let mistakes get through too, so I shouldn't throw stones, but it's just so much _nicer_ if things look nice in the logs etc, so I try to catch it when I can..

Linus

author
#2 lore raw
Quoted 12 lines · Linus Torvalds
Quoted 8 lines · Greg KH

linas:
PCI Hotplug: PCI panic on dlpar add (add pci slot to running partition) PCI Hotplug/powerpc: module build break

[email protected]:
powerpc/PCI hotplug: remove rpaphp_find_bus() powerpc/PCI hotplug: merge config_pci_adapter

Quoted 6 lines

Looks like Linas Vepstas doesn't have a good email address in his From:
fields.. As a result, the logs are nasty.

Linas - could you _please_ fix your email setup, of if your email setup is good, could whoever added the bogus "From: " line to the email please NOT DO THAT HORRIBLE THING?

At least he put a valid email address in there, it used to just bounce to a non-existant domain :(

Quoted 4 lines

Greg, if you notice things like this, can you fix them up or bounce them back to the author? Yeah, I let mistakes get through too, so I shouldn't throw stones, but it's just so much _nicer_ if things look nice in the logs etc, so I try to catch it when I can..

Sorry about that, I should have caught this.

thanks,

greg k-h

#3 lore raw
Quoted 8 lines · Greg KH
Quoted 4 lines · Linus Torvalds

Linas - could you _please_ fix your email setup, of if your email setup is good, could whoever added the bogus "From: " line to the email please NOT DO THAT HORRIBLE THING?

At least he put a valid email address in there, it used to just bounce to a non-existant domain :(

Btw, Linas - even if you can't fix your broken mail setup, what you _can_ do is to always make sure that the patches you send out have

From: Linas Vepstas <[email protected]>

as the first line of the body - then the tools will figure out to use that instead of the broken mail headers. Ok?

(This is true in general - so anybody else who knows that they send out emails from a strange address that they'd rather have show up as their "real" email address instead in the changelogs can do the same).

Linus

PS. It's _damn_ hard to type "Linas". Every time, that "a" just becomes an "u" for me. My fingers obviously have certain things hard-coded ;)

#4 lore raw
Quoted 7 lines · Linus Torvalds

Btw, Linas - even if you can't fix your broken mail setup, what you _can_ do is to always make sure that the patches you send out have

From: Linas Vepstas <[email protected]>

as the first line of the body - then the tools will figure out to use that instead of the broken mail headers. Ok?

BTW, Linus - even if Linas did you already have commits with broken author information; what you _can_ do is to have the following entry in a .mailmap file in your linux-2.6.git repository, where you run git-shortlog for your next announcement:

        $ cat .mailmap
        Linas Vepstas <[email protected]>
        Linus Torvalds <[email protected]>
        ...
        $ 

Then the tool will pick up Author: line of the commit (which is {'linas', '<[email protected]>'} pair) and figure out to use the canonical "name" you define there instead of the broken commit headers. OK?

Quoted 3 lines

(This is true in general - so anybody else who knows that they send out emails from a strange address that they'd rather have show up as their "real" email address instead in the changelogs can do the same).

(This is also true in general - so any upstream maintainer who ended up with commits that have badly formatted author information in his repository that they'd rather have show up nicer in the changelogs can do the same).

Quoted 1 line

Linus

		Junio ;-).
#5 lore raw
In reply to Linus Torvalds

On Tue, Jan 31, 2006 at 06:16:43PM -0800, Linus Torvalds was heard to remark:

Quoted 10 lines · Greg KH
Quoted 8 lines

linas:
PCI Hotplug: PCI panic on dlpar add (add pci slot to running partition) PCI Hotplug/powerpc: module build break

[email protected]:
powerpc/PCI hotplug: remove rpaphp_find_bus() powerpc/PCI hotplug: merge config_pci_adapter

Quoted 6 lines

Looks like Linas Vepstas doesn't have a good email address in his From:
fields.. As a result, the logs are nasty.

Linas - could you _please_ fix your email setup, of if your email setup is good, could whoever added the bogus "From: " line to the email please NOT DO THAT HORRIBLE THING?

(OK, I'm red with embarrassment. I can only offer that email has been an enemy for a while now).

Is this better?

--linas

#6 lore raw
Quoted 5 lines · Linas Vepstas

(OK, I'm red with embarrassment. I can only offer that email has been an enemy for a while now).

Is this better?

This email looks to be fine. My email parsing tools correctly parses the email as

	Author: Linas Vepstas
	Email: [email protected]
	Subject: PCI patches for 2.6.16-rc1
	Date: Wed, 1 Feb 2006 16:20:40 -0600

and everything looks ok.

Linus "one down, a billion to go" Torvalds