Beautifulise git-show output
PATCH 1/1 Beautifulise git-show output
From: Bertrand Jacquin (Beber) <[email protected]>
log-tree.c +1 -1
@@ -164,7 +164,7 @@ int log_tree_diff_flush(struct rev_info }if (opt->loginfo && !opt->no_commit_id) -show_log (opt, opt->loginfo, opt->diffopt.with_stat ?"---\n" :"\n" ); +show_log (opt, opt->loginfo, opt->diffopt.with_stat ?"\n---\n" :"\n" );diff_flush (&opt->diffopt);return 1 ; }
Signature · 1 line
1.4.1
Why?
A patch like this needs to be justified with a bit more explanation; the word "beautiful" is subjective.
(current)
Change this and that file
Signed-off-by: A U Thor <[email protected]>
---
this-file | 20 +++++++----
that-file | 4 ++++
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/this-file b/this-file
...(yours -- and I think 1.3.0 did it like this)
Change this and that file
Signed-off-by: A U Thor <[email protected]>
---
this-file | 20 +++++++----
that-file | 4 ++++
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/this-file b/this-file
...It _might_ be easier to read if it were like this, though:
Change this and that file
Signed-off-by: A U Thor <[email protected]>
---
this-file | 20 +++++++----
that-file | 4 ++++
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/this-file b/this-file
...However, the screen real estate, especially in the vertical direction, is a scarce resource; I do not think the three-dash is a too weak visual separator that needs to be helped by an extra newline.
Quoted 4 lines · Junio C Hamano
Why?
A patch like this needs to be justified with a bit more explanation; the word "beautiful" is subjective.
Arg, git-send-email seems to made a bad job after git-format-patch, sorry.
So explanation don't go here. So here it is :
Git-show actually show (for example) :
Makefile: Create Makefile for Beamer theme rules are : install & uninstall (be careful on this one)
Also, I hacked presentation oral's Makefile to check them presence or not
---
docs/presentation_oral/Makefile | 5 +-
docs/presentation_oral/themes/Makefile | 91 ++++++++++++++++++++++++++++++++
2 files changed, 95 insertions(+), 1 deletions(-)
create mode 100644 docs/presentation_oral/themes/Makefile
I would like to have a newline after commit mesage too as there is one before diff-stat.
Signature · 3 lines
# Beber : [email protected] # IM : [email protected] # http://guybrush.ath.cx, irc://irc.freenode.net/#{e.fr,gentoofr}