Fix invalid volume resolution for Logitech HD Webcam C525
PATCH 1/1 Fix invalid volume resolution for Logitech HD Webcam C525
From: Maksim Boyko <[email protected]>
Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
The similar patch was previously reported for Logitech HD Webcam C310 (see 36691e1be6ec551eef4a5225f126a281f8c051c2).
sound/usb/mixer.c +1 -0
@@ -888,6 +888,7 @@case USB_ID (0x046d ,0x081b ):/* HD Webcam c310 */ case USB_ID (0x046d ,0x081d ):/* HD Webcam c510 */ case USB_ID (0x046d ,0x0825 ):/* HD Webcam c270 */ +case USB_ID (0x046d ,0x0826 ):/* HD Webcam c525 */ case USB_ID (0x046d ,0x0991 ):/* Most audio usb devices lie about volume resolution. * Most Logitech webcams have res = 384.
Quoted 8 lines · Бойко Максим
From: Maksim Boyko <[email protected]>
Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
The similar patch was previously reported for Logitech HD Webcam C310 (see36691e1be6ec551eef4a5225f126a281f8c051c2).
sound/usb/mixer.c line 894
Quoted 7 lines
sound/usb/mixer.c +1
-0@@ -888,6 +888,7 @@case USB_ID (0x046d ,0x081b ):/* HD Webcam c310 */ case USB_ID (0x046d ,0x081d ):/* HD Webcam c510 */ case USB_ID (0x046d ,0x0825 ):/* HD Webcam c270 */ +case USB_ID (0x046d ,0x0826 ):/* HD Webcam c525 */ case USB_ID (0x046d ,0x0991 ):/* Most audio usb devices lie about volume resolution. * Most Logitech webcams have res = 384.
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.
</formletter>
A message that is not in the archive (sent off-list or not yet received): 80181375903486-HW/[email protected]
Hello.
Quoted 4 lines · Бойко Максим
From: Maksim Boyko <[email protected]>
Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
The similar patch was previously reported for Logitech HD Webcam C310 (see36691e1be6ec551eef4a5225f126a281f8c051c2).
Please also specif that commit's summary line in parens.
And wrap your changelog lines at 80 columns at least.
sound/usb/mixer.c line 894
Quoted 10 lines
sound/usb/mixer.c +1
-0@@ -888,6 +888,7 @@case USB_ID (0x046d ,0x081b ):/* HD Webcam c310 */ case USB_ID (0x046d ,0x081d ):/* HD Webcam c510 */ case USB_ID (0x046d ,0x0825 ):/* HD Webcam c270 */ +case USB_ID (0x046d ,0x0826 ):/* HD Webcam c525 */ case USB_ID (0x046d ,0x0991 ):/* Most audio usb devices lie about volume resolution. * Most Logitech webcams have res = 384.
Hm, the file has bad indentation (your added line is fine unless it's out
of sync with the surrounding ones).
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
At Wed, 07 Aug 2013 23:24:46 +0400,
Quoted 5 lines · Бойко Максим
From: Maksim Boyko <[email protected]>
Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
The similar patch was previously reported for Logitech HD Webcam C310 (see36691e1be6ec551eef4a5225f126a281f8c051c2).
Your sign-off is missing. And the patch can't be applied cleanly as is, likely because your MUA broke the spaces/tabs.
Could you resubmit with the fixes?
thanks,
Takashi
Quoted 16 lines
sound/usb/mixer.c +1
-0@@ -888,6 +888,7 @@case USB_ID (0x046d ,0x081b ):/* HD Webcam c310 */ case USB_ID (0x046d ,0x081d ):/* HD Webcam c510 */ case USB_ID (0x046d ,0x0825 ):/* HD Webcam c270 */ +case USB_ID (0x046d ,0x0826 ):/* HD Webcam c525 */ case USB_ID (0x046d ,0x0991 ):/* Most audio usb devices lie about volume resolution. * Most Logitech webcams have res = 384. _______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel