kernel_thread() usage found in staging
Quoted 1 line
From
Documentation/feature_removal_schedule.txt, it is well-known that
kernel_thread() API usage is discouraged, but in staging we still
routinely see its use. Perhaps the original driver owner have
overlooked this?
Thanks.
./rt2870/common/2870_rtmp_init.c:
pid_number = kernel_thread(MlmeThread, pAd, CLONE_VM); pid_number = kernel_thread(RTUSBCmdThread, pAd, CLONE_VM); pid_number = kernel_thread(TimerQThread, pAd, CLONE_VM);
./usbip/usbip_common.c:
retval = kernel_thread(usbip_thread, (void *)&ud->tcp_rx, 0); retval = kernel_thread(usbip_thread, (void *)&ud->tcp_tx, 0);
./usbip/usbip_event.c:
kernel_thread(usbip_thread, (void *)eh, 0);
./epl/ShbIpc-LinuxKernel.c:
kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p, kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
./epl/EplSdoUdpu.c:
kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g, CLONE_KERNEL);
Signature · 2 lines
Regards, Peter Teoh
Quoted 4 lines · Peter Teoh
Quoted 1 line
From
Documentation/feature_removal_schedule.txt, it is well-known that
kernel_thread()API usage is discouraged, but in staging we still
routinely see its use. Perhaps the original driver owner have
overlooked this?
Yes, they probably didn't realize this and some of this code predates the kthread code.
Quoted 10 lines
./rt2870/common/2870_rtmp_init.c:pid_number = kernel_thread(MlmeThread, pAd, CLONE_VM); pid_number = kernel_thread(RTUSBCmdThread, pAd, CLONE_VM); pid_number = kernel_thread(TimerQThread, pAd, CLONE_VM);
./usbip/usbip_common.c:retval = kernel_thread(usbip_thread, (void *)&ud->tcp_rx, 0); retval = kernel_thread(usbip_thread, (void *)&ud->tcp_tx, 0);
./usbip/usbip_event.c:
Quoted 8 lines
kernel_thread(usbip_thread, (void *)eh, 0);
./epl/ShbIpc-LinuxKernel.c:
kernel_thread(ShbIpcThreadSignalNewData,pShbInstance_p, kernel_thread(ShbIpcThreadSignalJobReady,pShbInstance_p,
./epl/EplSdoUdpu.c:kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g, CLONE_KERNEL);
Patches are gladly accepted to clean this up.
thanks,
greg k-h