compilation error in linus git tree
just git pulled and compiled with the following errors:
CC [M] arch/x86/kernel/cpu/cpufreq/speedstep-lib.o
CC [M] arch/x86/kernel/cpu/cpufreq/p4-clockmod.oarch/x86/kernel/cpu/cpufreq/p4-clockmod.c: In function ‘cpufreq_p4_cpu_init’:arch/x86/kernel/cpu/cpufreq/p4-clockmod.c:232: error: implicit declaration of function ‘recalibrate_cpu_khz’
make[3]: *** [arch/x86/kernel/cpu/cpufreq/p4-clockmod.o] Error 1 make[2]: *** [arch/x86/kernel/cpu/cpufreq] Error 2
make[1]: *** [arch/x86/kernel/cpu] Error 2
make: *** [arch/x86/kernel] Error 2
not sure where is the best place to put this, but the error is resolved via
extern int recalibrate_cpu_khz(void);
inside the file:
arch/x86/kernel/cpu/cpufreq/p4-clockmod.c
thanks.
Signature · 2 lines
Regards, Peter Teoh
Hi,
Quoted 12 lines · Peter Teoh
just git pulled and compiled with the following errors:
CC [M]
arch/x86/kernel/cpu/cpufreq/speedstep-lib.o
CC [M]arch/x86/kernel/cpu/cpufreq/p4-clockmod.oarch/x86/kernel/cpu/cpufreq/p4-clockmod.c: In function ‘cpufreq_p4_cpu_init’:arch/x86/kernel/cpu/cpufreq/p4-clockmod.c:232: error: implicit declaration of function ‘recalibrate_cpu_khz’
make[3]: *** [arch/x86/kernel/cpu/cpufreq/p4-clockmod.o] Error 1 make[2]: *** [arch/x86/kernel/cpu/cpufreq] Error 2
make[1]: *** [arch/x86/kernel/cpu] Error 2
make: *** [arch/x86/kernel] Error 2
Quoted 7 lines
not sure where is the best place to put this, but the error is resolved via
extern int
recalibrate_cpu_khz(void);inside the file:
arch/x86/kernel/cpu/cpufreq/p4-clockmod.c
Indeed but its prototype is already defined in asm/timer.h This is a missing include, can you tell me if the patch below fixes your problem?
Thanks,
Frederic.
--
Quoted 1 line
From
c4a2eec69fa98b6cdb060c593a720099878bf854Mon Sep 17 00:00:00 2001
From: Frederic Weisbecker <[email protected]>
Date: Mon, 30 Mar 2009 18:08:37 +0200
Subject: [PATCH] x86: fix missing include asm/timer.h in p4-clockmod.c
Impact: fix build error
arch/x86/kernel/cpu/cpufreq/p4-clockmod.c lacks the prototype of recalibrate_cpu_khz(), we need to include asm/timer.h
--- arch/x86/kernel/cpu/cpufreq/p4-clockmod.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/x86/kernel/cpu/cpufreq/p4-clockmod.c +1 -0
@@ -31,6 +31,7 @@#include <asm/processor.h> #include <asm/msr.h> #include <asm/timex.h> +#include <asm/timer.h> #include "speedstep-lib.h"
Signature · 1 line
1.6.1
Yes it worked, although the line number is slightly different for linus git tree.
The modified version is as follows. Thanks!!!!
Quoted 64 lines · Frederic Weisbecker
Hi,
Quoted 12 lines · Peter Teoh
just git pulled and compiled with the following errors:
CC [M] arch/x86/kernel/cpu/cpufreq/speedstep-lib.o
CC [M] arch/x86/kernel/cpu/cpufreq/p4-clockmod.oarch/x86/kernel/cpu/cpufreq/p4-clockmod.c: In function ‘cpufreq_p4_cpu_init’:arch/x86/kernel/cpu/cpufreq/p4-clockmod.c:232: error: implicit declaration of function ‘recalibrate_cpu_khz’
make[3]: *** [arch/x86/kernel/cpu/cpufreq/p4-clockmod.o] Error 1 make[2]: *** [arch/x86/kernel/cpu/cpufreq] Error 2
make[1]: *** [arch/x86/kernel/cpu] Error 2
make: *** [arch/x86/kernel] Error 2Quoted 7 lines
not sure where is the best place to put this, but the error is resolved via
extern int
recalibrate_cpu_khz(void);inside the file:
arch/x86/kernel/cpu/cpufreq/p4-clockmod.cIndeed but its prototype is already defined in
asm/timer.hThis is a missing include, can you tell me if the patch below fixes your problem?Thanks,
Frederic.--
From
c4a2eec69fa98b6cdb060c593a720099878bf854Mon Sep 17 00:00:00 2001
From: Frederic Weisbecker <[email protected]>
Date: Mon, 30 Mar 2009 18:08:37 +0200
Subject: [PATCH] x86: fix missing includeasm/timer.hinp4-clockmod.cImpact: fix build error
arch/x86/kernel/cpu/cpufreq/p4-clockmod.clacks the prototype ofrecalibrate_cpu_khz(), we need to includeasm/timer.hReported-by Peter Teoh <[email protected]>Signed-off-by Frederic Weisbecker <[email protected]>---
arch/x86/kernel/cpu/cpufreq/p4-clockmod.c | 1 +1 files changed, 1 insertions(+), 0 deletions(-)arch/x86/kernel/cpu/cpufreq/p4-clockmod.c +1
-1@@ -31,6 +31,7 @@ #include <asm/processor.h> #include <asm/msr.h> #include <asm/timex.h> +#include <asm/timer.h> #include "speedstep-lib.h" --
Quoted 4 lines
1.6.1
arch/x86/kernel/cpu/cpufreq/p4-clockmod.c +1 -0
@@ -28,6 +28,7 @@#include <linux/slab.h> #include <linux/cpumask.h> #include <linux/timex.h> +#include <linux/timer.h> #include <asm/processor.h> #include <asm/msr.h>
Signature · 2 lines
Regards, Peter Teoh