drm/nouveau: Remove surplus struct member
Subsystems (3)
PATCH 1/1 drm/nouveau: Remove surplus struct member
struct nouveau_channel contains the member 'accel_done' and a forgotten TODO which hints at that mechanism being removed in the "near future". Since that variable is read nowhere anymore, this "near future" is now.
Remove the variable and the TODO.
--- drivers/gpu/drm/nouveau/nouveau_chan.h | 2 -- drivers/gpu/drm/nouveau/nouveau_dma.h | 1 - 2 files changed, 3 deletions(-)
drivers/gpu/drm/nouveau/nouveau_chan.h +0 -2
@@ -31,8 +31,6 @@ struct nouveau_channel {u64 addr; } push; -/* TODO: this will be reworked in the near future */ -bool accel_done;void *fence;struct {int max;
drivers/gpu/drm/nouveau/nouveau_dma.h +0 -1
@@ -90,7 +90,6 @@ FIRE_RING(struct nouveau_channel *chan) {if (chan->dma.cur == chan->dma.put)return ; - chan->accel_done = true;WRITE_PUT (chan->dma.cur);
Signature · 1 line
2.49.0
Does mean that the TODO has been done, or that someone completely forgot and now your patch is remove all reminders?
If it's the format, maybe add a fixes: tag for the commit that resolved the TODO?
Quoted 37 lines · Philipp Stanner
struct
nouveau_channelcontains the member 'accel_done' and a forgotten TODO which hints at that mechanism being removed in the "near future". Since that variable is read nowhere anymore, this "near future" is now.Remove the variable and the TODO.
Signed-off-by Philipp Stanner <[email protected]>---
drivers/gpu/drm/nouveau/nouveau_chan.h | 2 --
drivers/gpu/drm/nouveau/nouveau_dma.h | 1 -2 files changed, 3 deletions(-)drivers/gpu/drm/nouveau/nouveau_chan.h +0
-0@@ -31,8 +31,6 @@ struct nouveau_channel { u64 addr; } push;drivers/gpu/drm/nouveau/nouveau_chan.h +0
-2-/* TODO: this will be reworked in the near future */ -bool accel_done;void *fence;
struct {
int max;drivers/gpu/drm/nouveau/nouveau_dma.h +0
-1@@ -90,7 +90,6 @@ FIRE_RING(struct nouveau_channel *chan) { if (chan->dma.cur == chan->dma.put) return; - chan->accel_done = true;
WRITE_PUT(chan->dma.cur);
Danilo Krummrich
maintainerQuoted 4 lines · Timur Tabi
Does mean that the TODO has been done, or that someone completely forgot and now your patch is remove all reminders?
If it's the format, maybe add a fixes: tag for the commit that resolved the TODO?
The TODO was introduced by commit ebb945a94bba ("drm/nouveau: port all engines to new engine module format") from 2012.
It's a bit hard to know what exactly resolves "this will be reworked in the near future" for a commit with the following diffstat. :)
146 files changed, 14219 insertions(+), 11099 deletions(-)
The last remains of accel_done were removed with commit 4e2ec2500bfc ("drm/nouveau: Remove file nouveau_fbcon.c"), but I don't think we should mention this commit, given that apparently no one knows what was intended to be reworked here [1].
We could mention the above in the commit message, though it will also be available through the lore link in the commit message once the patch is applied.
NIT: Please don't top post, use interleaved style [2] instead.
[1] https://lore.kernel.org/all/[email protected]/
[2] https://docs.kernel.org/process/submitting-patches.html#use-trimmed-interleaved-replies-in-email-discussions
Quoted 15 lines · Danilo Krummrich
Quoted 5 lines · Timur Tabi
Does mean that the TODO has been done, or that someone completely forgot and now your patch is
remove all reminders?If it's the format, maybe add a fixes: tag for the commit that resolved the TODO?
The TODO was introduced by commit
ebb945a94bba("drm/nouveau: port all engines to new engine module format") from 2012.It's a bit hard to know what exactly resolves "this will be reworked in the near future" for a commit with the following diffstat. :)
146 files changed, 14219 insertions(+), 11099 deletions(-)
Quoted 7 lines
The last remains of
accel_donewere removed with commit4e2ec2500bfc("drm/nouveau: Remove filenouveau_fbcon.c"), but I don't think we should mention this commit, given that apparently no one knows what was intended to be reworked here [1].We could mention the above in the commit message, though it will also be available through the lore link in the commit message once the patch is applied.
It's your call, I'm just leery of removing a TODO without any mention of whether it's actually done.
Quoted 1 line
NIT: Please don't top post, use interleaved style [2] instead.
Sorry, coffee didn't kick in yet.
Quoted 21 lines · Timur Tabi
Quoted 20 lines · Danilo Krummrich
Quoted 5 lines · Timur Tabi
Does mean that the TODO has been done, or that someone completely forgot and now your patch is
remove all reminders?If it's the format, maybe add a fixes: tag for the commit that resolved the TODO?
The TODO was introduced by commit
ebb945a94bba("drm/nouveau: port all engines to new engine module format") from 2012.It's a bit hard to know what exactly resolves "this will be reworked in the near future" for a commit with the following diffstat. :)
146 files changed, 14219 insertions(+), 11099 deletions(-)The last remains of
accel_donewere removed with commit4e2ec2500bfc("drm/nouveau: Remove filenouveau_fbcon.c"), but I don't think we should mention this commit, given that apparently no one knows what was intended to be reworked here [1].
Quoted 5 lines
Quoted 2 lines
We could mention the above in the commit message, though it will also be available through the lore link in the commit message once the patch is applied.
It's your call, I'm just leery of removing a TODO without any mention of whether it's actually done.
We can't really tell whether "it" is done or not, because the original author didn't write down *what* exactly needs to be done, which makes the TODO kind of useless.
Since that information is lost forever, removing it arguably is alright.
P.
Quoted 4 lines
Quoted 2 lines
NIT: Please don't top post, use interleaved style [2] instead.
Sorry, coffee didn't kick in yet.
Quoted 7 lines · Philipp Stanner
struct
nouveau_channelcontains the member 'accel_done' and a forgotten TODO which hints at that mechanism being removed in the "near future". Since that variable is read nowhere anymore, this "near future" is now.Remove the variable and the TODO.
Signed-off-by Philipp Stanner <[email protected]>
Applied to drm-misc-next, thanks!