io-wq: fix 'task->pi_lock' spin lock protect
PATCH 1/1 io-wq: fix 'task->pi_lock' spin lock protect
From: Zqiang <[email protected]>
The set CPU affinity func 'do_set_cpus_allowed' may be operate 'task_rq', need add rq lock protect, replace 'pi_lock' spinlock protect with task_rq_lock func.
Signed-off-by Zqiang <[email protected]>
--- fs/io-wq.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
fs/io-wq.c +4 -2
@@ -1209,11 +1209,13 @@ static bool io_wq_worker_affinity(struct io_worker *worker, void *data) {struct task_struct *task = worker->task;unsigned long flags; +struct rq_flags rf; +struct rq *rq; -raw_spin_lock_irqsave (&task->pi_lock, flags); + rq =task_rq_lock (task, &rf);do_set_cpus_allowed (task,cpumask_of_node (worker->wqe->node)); task->flags |=PF_NO_SETAFFINITY ; -raw_spin_unlock_irqrestore (&task->pi_lock, flags); +task_rq_unlock (rq, task, &rf);return false; }
Signature · 1 line
2.17.1
Jens Axboe
maintainerQuoted 5 lines · On 10/23/20 12:20 AM, [email protected] wrote:
From: Zqiang <[email protected]>
The set CPU affinity func '
do_set_cpus_allowed' may be operate 'task_rq', need add rq lock protect, replace 'pi_lock' spinlock protect withtask_rq_lockfunc.
Thanks, I'm going to fold this one.
Signature · 1 line
Jens Axboe