arm: dts: mt7623: increase passive cooling trip
Subsystems (2)
PATCH 1/1 arm: dts: mt7623: increase passive cooling trip
From: Frank Wunderlich <[email protected]>
MT7623/BPI-R2 has idle temperature after bootup from 48 degrees celsius increase the passive trip temp threshold to not trottle CPU frequency at this temperature
--- arch/arm/boot/dts/mt7623.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/mt7623.dtsi +1 -1
@@ -160,7 +160,7 @@ cpu_thermal: cpu-thermal { trips { cpu_passive: cpu-passive { - temperature = <47000>; + temperature = <57000>; hysteresis = <2000>; type = "passive"; };
Signature · 1 line
2.25.1
Quoted 7 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
MT7623/BPI-R2 has idle temperature after bootup from 48 degrees celsius increase the passive trip temp threshold to not trottle CPU frequency at this temperature
Signed-off-by Frank Wunderlich <[email protected]>
pushed to v5.14-next/dts32
Thanks!
Quoted 18 lines
--- arch/arm/boot/dts/mt7623.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/mt7623.dtsi +1
-1@@ -160,7 +160,7 @@ cpu_thermal: cpu-thermal { trips { cpu_passive: cpu-passive { - temperature = <47000>; + temperature = <57000>; hysteresis = <2000>; type = "passive"; };
This issue and patch just came to my attention, my apologies for late comments.
The solution provided in this patch is, I believe, not optimal.
Quoted 5 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
MT7623/BPI-R2 has idle temperature after bootup from 48 degrees celsius increase the passive trip temp threshold to not trottle CPU frequency at this temperature
The dts file for the mt7623 has four trip points:
- Trip point 0, Type=Passive @ 47°C (originally, now 57°C)
- Trip point 1, Type=Active @ 67°C
- Trip point 2, Type=Hot @ 87°C
- Trip point 3, Type=Critical @ 107°C
It makes little sense to have passive CPU throttling employed *before* engaging a fan. Generally users want a fan (if present) to be engaged before intentional performance degradation is employed.
Review
Quoted 3 lines
cpu_passive: cpu-passive {(quoted diff) +1
-1- temperature = <47000>; + temperature = <57000>;
The old temperature of 47°C appears, in practice, to be a good temperature for an active cooling trip point. It is just above the temperature that a generally idle mt7623 sits at in enclosures where this SoC is employed, but also a temperature that a CPU under load will quickly reach.
Therefore I propose the types of trip points 0 and 1 be reversed and the temperatures left as they were.
arch/arm/boot/dts/mt7623.dtsi +3 -3
@@ -158,19 +158,19 @@ thermal-sensors = <&thermal 0>; trips { cpu_passive: cpu-passive { - temperature = <57000>; + temperature = <47000>; hysteresis = <2000>; - type = "passive"; + type = "active"; }; cpu_active: cpu-active { temperature = <67000>; hysteresis = <2000>; - type = "active"; + type = "passive"; }; cpu_hot: cpu-hot { temperature = <87000>; hysteresis = <2000>;
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi Kurt,
Quoted 7 lines
Gesendet: Samstag, 05. März 2022 um 16:54 Uhr
Von: "Kurt Fitzner" <[email protected]>This issue and patch just came to my attention, my apologies for late comments.
The solution provided in this patch is, I believe, not optimal.
does your Patch fixes the issue? if yes you can send a Patch based on current mainline dts.
it looks a bit weired to me having active before passive...but i'm no expert in the cooling trips. i just increased the temps :)
please see notes below
Quoted 35 lines · Frank Wunderlich
Quoted 5 lines
From: Frank Wunderlich <[email protected]>
MT7623/BPI-R2 has idle temperature after bootup from 48 degrees celsius increase the passive trip temp threshold to not trottle CPU frequency at this temperature
The dts file for the mt7623 has four trip points:
- Trip point 0, Type=Passive @ 47°C (originally, now 57°C)
- Trip point 1, Type=Active @ 67°C
- Trip point 2, Type=Hot @ 87°C
- Trip point 3, Type=Critical @ 107°CIt makes little sense to have passive CPU throttling employed *before* engaging a fan. Generally users want a fan (if present) to be engaged before intentional performance degradation is employed.
Review
Quoted 3 lines
cpu_passive: cpu-passive {(quoted diff) +1
-1- temperature = <47000>; + temperature = <57000>;The old temperature of 47°C appears, in practice, to be a good temperature for an active cooling trip point. It is just above the temperature that a generally idle mt7623 sits at in enclosures where this SoC is employed, but also a temperature that a CPU under load will quickly reach.
Therefore I propose the types of trip points 0 and 1 be reversed and the temperatures left as they were.
arch/arm/boot/dts/mt7623.dtsi +0
-0@@ -158,19 +158,19 @@
arch/arm/boot/dts/mt7623.dtsi line 166
Quoted 10 lines
arch/arm/boot/dts/mt7623.dtsi +2
-2thermal-sensors = <&thermal 0>; trips { cpu_passive: cpu-passive { - temperature = <57000>; + temperature = <47000>; hysteresis = <2000>; - type = "passive"; + type = "active"; };
if type is different, imho the name+label should be changed too
arch/arm/boot/dts/mt7623.dtsi line 172
Quoted 6 lines
arch/arm/boot/dts/mt7623.dtsi +1
-1cpu_active: cpu-active { temperature = <67000>; hysteresis = <2000>; - type = "active"; + type = "passive"; };
dito
arch/arm/boot/dts/mt7623.dtsi line 176
Quoted 3 lines
arch/arm/boot/dts/mt7623.dtsi +0
-0cpu_hot: cpu-hot { temperature = <87000>; hysteresis = <2000>;
regards Frank
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek