PM: Fix signed/unsigned warning
Subsystems (4)
PATCH 1/1 PM: Fix signed/unsigned warning
Seen on MIPS32, gcc 4.4.3, 2.6.36-rc4:
drivers/base/power/main.c: In function 'dpm_show_time':drivers/base/power/main.c:415: warning: comparison of distinct pointer types lacks a cast
do_div() takes unsigned parameters:
uint32_t do_div(uint64_t *n, uint32_t base);
Using an unsigned variable for usecs64 should not cause any problems, because calltime >= starttime .
--- drivers/base/power/main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/base/power/main.c +1 -1
@@ -407,7 +407,7 @@ static void pm_dev_err(struct device *dev, pm_message_t state, char *info,static void dpm_show_time (ktime_t starttime,pm_message_t state,char *info) {ktime_t calltime; -s64 usecs64; +u64 usecs64;int usecs; calltime =ktime_get ();
Signature · 1 line
1.7.0.4
Quoted 5 lines · Kevin Cernekee
Seen on MIPS32, gcc 4.4.3, 2.6.36-rc4:
drivers/base/power/main.c: In function 'dpm_show_time':drivers/base/power/main.c:415: warning: comparison of distinct pointer types lacks a cast
Quoted 8 lines
do_div()takes unsigned parameters:
uint32_tdo_div(uint64_t *n, uint32_t base);Using an unsigned variable for usecs64 should not cause any problems, because calltime >= starttime .
Signed-off-by Kevin Cernekee <[email protected]>
OK, I'm going to apply it.
Thanks,
Rafael
Quoted 18 lines
--- drivers/base/power/main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/base/power/main.c +1
-1@@ -407,7 +407,7 @@ static void pm_dev_err(struct device *dev, pm_message_t state, char *info,static void dpm_show_time (ktime_t starttime,pm_message_t state,char *info) {ktime_t calltime; -s64 usecs64; +u64 usecs64;int usecs; calltime =ktime_get ();
Quoted 5 lines · Kevin Cernekee
Seen on MIPS32, gcc 4.4.3, 2.6.36-rc4:
drivers/base/power/main.c: In function 'dpm_show_time':drivers/base/power/main.c:415: warning: comparison of distinct pointer types lacks a cast
Quoted 8 lines
do_div()takes unsigned parameters:
uint32_tdo_div(uint64_t *n, uint32_t base);Using an unsigned variable for usecs64 should not cause any problems, because calltime >= starttime .
Signed-off-by Kevin Cernekee <[email protected]>
OK, I'm going to apply it.
Thanks,
Rafael
Quoted 18 lines
--- drivers/base/power/main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)drivers/base/power/main.c +1
-1@@ -407,7 +407,7 @@ static void pm_dev_err(struct device *dev, pm_message_t state, char *info,static void dpm_show_time (ktime_t starttime,pm_message_t state,char *info) {ktime_t calltime; -s64 usecs64; +u64 usecs64;int usecs; calltime =ktime_get ();