ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200
PATCH RESEND 1/1 ALSA: ASoC: fix unmet dependency for SND_SOC_DB1200
SND_SOC_DB1200 selects SND_SOC_WM8731_I2C without ensuring its dependency, I2C is enabled. This causes an unmet dependency when SND_SOC_DB1200 is enabled without I2C.
Let's add a dependency on I2C, as similar options in this subsystem do.
This unmet dependency was found by kconfirm, a static analysis tool for Kconfig.
--- sound/soc/au1x/Kconfig | 1 + 1 file changed, 1 insertion(+)
sound/soc/au1x/Kconfig +1 -0
@@ -55,6 +55,7 @@ config SND_SOC_DB1000 config SND_SOC_DB1200 tristate "DB1200/DB1300/DB1550 Audio support" + depends on I2C depends on SND_SOC_AU1XPSC select SND_SOC_AU1XPSC_AC97 select SND_SOC_AC97_CODEC
Signature · 1 line
2.55.0
Quoted 6 lines · julianbraha
SND_SOC_DB1200selectsSND_SOC_WM8731_I2Cwithout ensuring its dependency, I2C is enabled. This causes an unmet dependency whenSND_SOC_DB1200is enabled without I2C.Let's add a dependency on I2C, as similar options in this subsystem do.
Quoted 7 lines
This unmet dependency was found by kconfirm, a static analysis tool for
Kconfig.Fixes 9dc15f81baf2 ("ASoC: wm8731: Factor out the I2C and SPI bus codeinto separate modules")
Signed-off-by julianbraha <[email protected]>
Mark Brown
maintainerQuoted 3 lines · julianbraha
SND_SOC_DB1200selectsSND_SOC_WM8731_I2Cwithout ensuring its dependency, I2C is enabled. This causes an unmet dependency whenSND_SOC_DB1200is enabled without I2C.
Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing.
Quoted 8 lines · Mark Brown
Quoted 3 lines · julianbraha
SND_SOC_DB1200selectsSND_SOC_WM8731_I2Cwithout ensuring its dependency, I2C is enabled. This causes an unmet dependency whenSND_SOC_DB1200is enabled without I2C.Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing.
Got it, will do better on this. Thanks for your feedback, Mark.
- Julian Braha