Skip to contentSkip to conversation

ACPI: APD: Add clock frequency for HJMC01 I2C controller

PATCH Superseded [email protected] 3 participants 5 messages Sep 19, 2024 1 message not in the archive

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/2 ACPI: APD: Add clock frequency for HJMC01 I2C controller

From: "hunter.yu" <[email protected]>

I2C clock frequency for HJMC01 is 200M, define a new ACPI HID for it.

---
 drivers/acpi/acpi_apd.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/acpi/acpi_apd.c +6 -0
index 800f97868448..bc271d1cb31b 100644
@@ -181,6 +181,11 @@ static const struct apd_device_desc hip08_spi_desc = {
 	.setup = acpi_apd_setup,
 	.fixed_clk_rate = 250000000,
 };
+
+static const struct apd_device_desc hjmc_i2c_desc = {
+	.setup = acpi_apd_setup,
+	.fixed_clk_rate = 200000000,
+};
 #endif /* CONFIG_ARM64 */
 
 #endif
@@ -252,6 +257,7 @@ static const struct acpi_device_id acpi_apd_device_ids[] = {
 	{ "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
 	{ "HISI0173", APD_ADDR(hip08_spi_desc) },
 	{ "NXP0001", APD_ADDR(nxp_i2c_desc) },
+	{ "HJMC3001", APD_ADDR(hjmc_i2c_desc) },
 #endif
 	{ }
 };
Signature · 1 line
2.27.0
#2 lore raw
Quoted 4 lines · On Thu, Sep 19, 2024 at 02:29:42PM +0800, [email protected] wrote:

From: "hunter.yu" <[email protected]>

I2C clock frequency for HJMC01 is 200M, define a new ACPI HID for it.

...

drivers/acpi/acpi_apd.c static const struct acpi_device_id acpi_apd_device_ids[] = { · line 260

Quoted 4 lines
drivers/acpi/acpi_apd.c +1 -0
 	{ "HISI02A3", APD_ADDR(hip08_lite_i2c_desc) },
 	{ "HISI0173", APD_ADDR(hip08_spi_desc) },
 	{ "NXP0001", APD_ADDR(nxp_i2c_desc) },
+	{ "HJMC3001", APD_ADDR(hjmc_i2c_desc) },

Please, keep it ordered.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

PATCH 2/2 i2c: designware: Add a new ACPI HID for HJMC01 I2C controller

In reply to a message not in the archive

From: "hunter.yu" <[email protected]>

Define a new ACPI HID for HJMC01

---
 drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-designware-platdrv.c +1 -0
index df3dc1e8093e..06dcefa3b103 100644
@@ -58,6 +58,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
 	{ "HISI02A2", 0 },
 	{ "HISI02A3", 0 },
 	{ "HYGO0010", ACCESS_INTR_MASK },
+	{ "HJMC3001", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
Signature · 1 line
2.27.0
Acked-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] i2c: designware: Add a new ACPI HID for HJMC01 I2C controller

Quoted 14 lines · On 9/19/24 9:29 AM, [email protected] wrote:

From: "hunter.yu" <[email protected]>

Define a new ACPI HID for HJMC01

---
  drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
  1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-designware-platdrv.c +0 -0
index df3dc1e8093e..06dcefa3b103 100644

drivers/i2c/busses/i2c-designware-platdrv.c static const struct acpi_device_id dw_i2c_acpi_match[] = { · line 64

Quoted 7 lines
drivers/i2c/busses/i2c-designware-platdrv.c +1 -0
@@ -58,6 +58,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
  	{ "HISI02A2", 0 },
  	{ "HISI02A3", 0 },
  	{ "HYGO0010", ACCESS_INTR_MASK },
+	{ "HJMC3001", 0 },
  	{ }
  };
  MODULE_DEVICE_TABLE(acpi, dw_i2c_acpi_match);
#5 lore raw

Re: [PATCH 2/2] i2c: designware: Add a new ACPI HID for HJMC01 I2C controller

In reply to [email protected]
Quoted 3 lines · On Thu, Sep 19, 2024 at 02:29:43PM +0800, [email protected] wrote:

From: "hunter.yu" <[email protected]>

Define a new ACPI HID for HJMC01

Missing period at the end.

...

drivers/i2c/busses/i2c-designware-platdrv.c static const struct acpi_device_id dw_i2c_acpi_match[] = { · line 61

Quoted 4 lines
drivers/i2c/busses/i2c-designware-platdrv.c +1 -0
 	{ "HISI02A2", 0 },
 	{ "HISI02A3", 0 },
 	{ "HYGO0010", ACCESS_INTR_MASK },
+	{ "HJMC3001", 0 },

Please, keep them ordered.

Signature · 2 lines
With Best Regards,
Andy Shevchenko