Skip to contentSkip to conversation

mmc: sdhci: Quirk for broken command queuing on Intel GLK-based Positivo models

PATCH In review Edson Juliano Drosdeck 3 participants 4 messages Jun 26, 2025 – Jul 3, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: sdhci: Quirk for broken command queuing on Intel GLK-based Positivo models

Disable command queuing on Intel GLK-based Positivo models.

Without this quirk, CQE (Command Queuing Engine) causes instability or I/O errors during operation. Disabling it ensures stable operation on affected devices.

---
 drivers/mmc/host/sdhci-pci-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-pci-core.c +2 -1
index 13a84b9309e0..e3877a1c72a9 100644
@@ -913,7 +913,8 @@ static bool glk_broken_cqhci(struct sdhci_pci_slot *slot)
 {
 	return slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_EMMC &&
 	       (dmi_match(DMI_BIOS_VENDOR, "LENOVO") ||
-		dmi_match(DMI_SYS_VENDOR, "IRBIS"));
+		dmi_match(DMI_SYS_VENDOR, "IRBIS") ||
+		dmi_match(DMI_SYS_VENDOR, "Positivo Tecnologia SA"));
 }
 
 static bool jsl_broken_hs400es(struct sdhci_pci_slot *slot)
Signature · 1 line
2.39.5
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Edson Juliano Drosdeck

Disable command queuing on Intel GLK-based Positivo models.

Without this quirk, CQE (Command Queuing Engine) causes instability or I/O errors during operation. Disabling it ensures stable operation on affected devices.

Subject would normally begin "mmc: sdhci-pci:" instead of "mmc: sdhci:"

Otherwise:

Also I guess:

Fixes bedf9fc01ff1 ("mmc: sdhci: Workaround broken command queuing on Intel GLK")
Quoted 18 lines
---
 drivers/mmc/host/sdhci-pci-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-pci-core.c +2 -1
index 13a84b9309e0..e3877a1c72a9 100644
@@ -913,7 +913,8 @@ static bool glk_broken_cqhci(struct sdhci_pci_slot *slot)
 {
 	return slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_EMMC &&
 	       (dmi_match(DMI_BIOS_VENDOR, "LENOVO") ||
-		dmi_match(DMI_SYS_VENDOR, "IRBIS"));
+		dmi_match(DMI_SYS_VENDOR, "IRBIS") ||
+		dmi_match(DMI_SYS_VENDOR, "Positivo Tecnologia SA"));
 }
 
 static bool jsl_broken_hs400es(struct sdhci_pci_slot *slot)
#2 lore raw

Thanks for the feedback!

Just to confirm: should I resend this as v2 with the corrected subject line?

Best regards,
Edson Juliano Drosdeck

Em qui., 26 de jun. de 2025 às 11:05, Adrian Hunter <[email protected]> escreveu:

Quoted 40 lines · Edson Juliano Drosdeck
Quoted 7 lines

Disable command queuing on Intel GLK-based Positivo models.

Without this quirk, CQE (Command Queuing Engine) causes instability or I/O errors during operation. Disabling it ensures stable operation on affected devices.

Subject would normally begin "mmc: sdhci-pci:" instead of "mmc: sdhci:"

Otherwise:

Also I guess:

Fixes bedf9fc01ff1 ("mmc: sdhci: Workaround broken command queuing on Intel GLK")
Quoted 18 lines
---
 drivers/mmc/host/sdhci-pci-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-pci-core.c +2 -1
index 13a84b9309e0..e3877a1c72a9 100644
@@ -913,7 +913,8 @@ static bool glk_broken_cqhci(struct sdhci_pci_slot *slot)
 {
      return slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_EMMC &&
             (dmi_match(DMI_BIOS_VENDOR, "LENOVO") ||
-             dmi_match(DMI_SYS_VENDOR, "IRBIS"));
+             dmi_match(DMI_SYS_VENDOR, "IRBIS") ||
+             dmi_match(DMI_SYS_VENDOR, "Positivo Tecnologia SA"));
 }
 
 static bool jsl_broken_hs400es(struct sdhci_pci_slot *slot)
#3 lore raw
Quoted 4 lines · edson drosdeck

Thanks for the feedback!

Just to confirm: should I resend this as v2 with the corrected subject line?

No need for that this time.

I have applied it for fixes and amended the patch according to Adrian's suggestions, thanks!

Kind regards
Uffe

Quoted 47 lines

Best regards,
Edson Juliano Drosdeck

Em qui., 26 de jun. de 2025 às 11:05, Adrian Hunter <[email protected]> escreveu:

Quoted 40 lines · Edson Juliano Drosdeck
Quoted 7 lines

Disable command queuing on Intel GLK-based Positivo models.

Without this quirk, CQE (Command Queuing Engine) causes instability or I/O errors during operation. Disabling it ensures stable operation on affected devices.

Subject would normally begin "mmc: sdhci-pci:" instead of "mmc: sdhci:"

Otherwise:

Also I guess:

Fixes bedf9fc01ff1 ("mmc: sdhci: Workaround broken command queuing on Intel GLK")
Quoted 18 lines
---
 drivers/mmc/host/sdhci-pci-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-pci-core.c +2 -1
index 13a84b9309e0..e3877a1c72a9 100644
@@ -913,7 +913,8 @@ static bool glk_broken_cqhci(struct sdhci_pci_slot *slot)
 {
      return slot->chip->pdev->device == PCI_DEVICE_ID_INTEL_GLK_EMMC &&
             (dmi_match(DMI_BIOS_VENDOR, "LENOVO") ||
-             dmi_match(DMI_SYS_VENDOR, "IRBIS"));
+             dmi_match(DMI_SYS_VENDOR, "IRBIS") ||
+             dmi_match(DMI_SYS_VENDOR, "Positivo Tecnologia SA"));
 }
 
 static bool jsl_broken_hs400es(struct sdhci_pci_slot *slot)