package/minisign: bump to version 0.12
PATCH 1/1 package/minisign: bump to version 0.12
From: Patrick Oppenlander <[email protected]>
--- package/minisign/minisign.hash | 2 +- package/minisign/minisign.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/minisign/minisign.hash +1 -1
@@ -1,3 +1,3 @@ # Locally calculated -sha256 74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55 minisign-0.11.tar.gz +sha256 796dce1376f9bcb1a19ece729c075c47054364355fe0c0c1ebe5104d508c7db0 minisign-0.12.tar.gz sha256 d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b LICENSE
package/minisign/minisign.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -MINISIGN_VERSION = 0.11 +MINISIGN_VERSION = 0.12 MINISIGN_SITE = $(call github,jedisct1,minisign,$(MINISIGN_VERSION)) MINISIGN_LICENSE = ISC MINISIGN_LICENSE_FILES = LICENSE
Signature · 6 lines
2.48.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Patrick,
Thanks for the patch.
Quoted 1 line · On 21/01/2025 04:14, [email protected] wrote:
From: Patrick Oppenlander <[email protected]>
Could you add a link to the change log in the commit log, please? Something like:
Changelog: https://github.com/jedisct1/minisign/releases/tag/0.12
Also, reading it, I see that the libsodium is now an optional dependency. Do you think it is worth reflecting this change in the Buildroot recipe?
Quoted 13 lines
Signed-off-by Patrick Oppenlander <[email protected]>--- package/minisign/minisign.hash | 2 +- package/minisign/minisign.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)package/minisign/minisign.hash +0
-1@@ -1,3 +1,3 @@ # Locally calculated -sha256
Quoted 5 lines
74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55minisign-0.11.tar.gz +sha256796dce1376f9bcb1a19ece729c075c47054364355fe0c0c1ebe5104d508c7db0minisign-0.12.tar.gz
sha256d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706bLICENSE
Running "make minisign-legal-info" fails with output:
Quoted 1 line
Quoted 1 line
Quoted 1 line
minisign 0.12 Collecting legal info
ERROR: while checking hashes from package/minisign/minisign.hash
ERROR: LICENSE has wrong sha256 hash:
ERROR: expected:d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b
ERROR: got :01aa50818d6609e85a9610b7d04da037e8b28bcf3bb5b5b4963c0c3f7abdabbd
ERROR: Incomplete download, or man-in-the-middle (MITM) attack
Could you check what has changed in the license (you can provide a link to the upstream commit change, or describe the change) and send an updated version of this patch?
Best reagrds,
Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Hi Julien,
Quoted 4 lines · Julien Olivain
Hi Patrick,
Thanks for the patch.
Thanks for the review!
Quoted 8 lines · On 21/01/2025 04:14, [email protected] wrote:
Quoted 1 line
From: Patrick Oppenlander <[email protected]>
Could you add a link to the change log in the commit log, please? Something like:
Changelog: https://github.com/jedisct1/minisign/releases/tag/0.12
Will do.
Quoted 3 lines
Also, reading it, I see that the libsodium is now an optional dependency.
Do you think it is worth reflecting this change in the Buildroot recipe?
It's only optional if minisign is built with a zig toolchain. Unfortunately it's not optional if using cmake.
Quoted 34 lines
Quoted 14 lines
Signed-off-by Patrick Oppenlander <[email protected]>--- package/minisign/minisign.hash | 2 +- package/minisign/minisign.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)package/minisign/minisign.hash +0
-1@@ -1,3 +1,3 @@ # Locally calculated -sha256Quoted 8 lines
74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55minisign-0.11.tar.gz
+sha256796dce1376f9bcb1a19ece729c075c47054364355fe0c0c1ebe5104d508c7db0minisign-0.12.tar.gz
sha256d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706bLICENSERunning "make minisign-legal-info" fails with output:
>>> minisign 0.12 Collecting legal info
ERROR: while checking hashes from package/minisign/minisign.hash
ERROR: LICENSE has wrong sha256 hash:
ERROR: expected:d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b
ERROR: got :01aa50818d6609e85a9610b7d04da037e8b28bcf3bb5b5b4963c0c3f7abdabbd
ERROR: Incomplete download, or man-in-the-middle (MITM) attack
Quoted 5 lines
Could you check what has changed in the license (you can provide a link to the
upstream commit change, or describe the change) and send an updated version of
this patch?
It's just a date change:
https://github.com/jedisct1/minisign/commit/12333fd7d11180e90a473331fcd628452af061ed
Sorry, I forgot about the make xxx-legal-info step.
Quoted 4 lines
Best reagrds,
Julien.
Patrick
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v2 1/1 package/minisign: bump to version 0.12
From: Patrick Oppenlander <[email protected]>
Upstream license changed to include 2025 in copyright years.
Changelog: https://github.com/jedisct1/minisign/releases/tag/0.12
--- package/minisign/minisign.hash | 4 ++-- package/minisign/minisign.mk | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
package/minisign/minisign.hash +2 -2
@@ -1,3 +1,3 @@ # Locally calculated -sha256 74c2c78a1cd51a43a6c98f46a4eabefbc8668074ca9aa14115544276b663fc55 minisign-0.11.tar.gz -sha256 d775d155cbf31638714c31c6f990f9fdc5f07998d91e42d1bf15483bd2d1706b LICENSE +sha256 796dce1376f9bcb1a19ece729c075c47054364355fe0c0c1ebe5104d508c7db0 minisign-0.12.tar.gz +sha256 01aa50818d6609e85a9610b7d04da037e8b28bcf3bb5b5b4963c0c3f7abdabbd LICENSE
package/minisign/minisign.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -MINISIGN_VERSION = 0.11 +MINISIGN_VERSION = 0.12 MINISIGN_SITE = $(call github,jedisct1,minisign,$(MINISIGN_VERSION)) MINISIGN_LICENSE = ISC MINISIGN_LICENSE_FILES = LICENSE
Signature · 6 lines
2.48.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 6 lines · On 27/01/2025 23:15, [email protected] wrote:
From: Patrick Oppenlander <[email protected]>
Upstream license changed to include 2025 in copyright years.
Changelog: https://github.com/jedisct1/minisign/releases/tag/0.12
Signed-off-by Patrick Oppenlander <[email protected]>
Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot