LSM testing suite
cover LSM testing suite
Testing the following syscalls which are providing support for the LSM communication added in kernel 6.8:
- lsm_get_self_attr
- lsm_set_self_attr
- lsm_list_modules
Please consider the following documentation as reference:
https://docs.kernel.org/userspace-api/lsm.html
---
Andrea Cervesato (7):
Add fallback definitions of LSM syscalls
Add lsm_get_self_attr01 test
Add lsm_get_self_attr02 test
Add lsm_get_self_attr03 test
Add lsm_list_modules01 test
Add lsm_list_modules02 test
Add lsm_set_self_attr01 test
configure.ac | 3 +- include/lapi/lsm.h | 172 +++++++++++++++++++++ runtest/syscalls | 7 + testcases/kernel/syscalls/lsm/.gitignore | 6 + testcases/kernel/syscalls/lsm/Makefile | 7 + testcases/kernel/syscalls/lsm/lsm_common.h | 57 +++++++ .../kernel/syscalls/lsm/lsm_get_self_attr01.c | 81 ++++++++++ .../kernel/syscalls/lsm/lsm_get_self_attr02.c | 55 +++++++ .../kernel/syscalls/lsm/lsm_get_self_attr03.c | 82 ++++++++++ testcases/kernel/syscalls/lsm/lsm_list_modules01.c | 77 +++++++++ testcases/kernel/syscalls/lsm/lsm_list_modules02.c | 134 ++++++++++++++++ .../kernel/syscalls/lsm/lsm_set_self_attr01.c | 123 +++++++++++++++ 12 files changed, 803 insertions(+), 1 deletion(-)
---
base-commit: c998b285e4d3c75e072be833b4fb9e1b4263f7bf
change-id: 20241105-lsm-5da2f6c2a1e9
Best regards,
Signature · 5 lines
Andrea Cervesato <[email protected]> -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH 1/7 Add fallback definitions of LSM syscalls
From: Andrea Cervesato <[email protected]>
Fallback definition for the following syscalls:
- lsm_get_self_attr
- lsm_set_self_attr
- lsm_list_modules
--- configure.ac | 3 +- include/lapi/lsm.h | 172 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 174 insertions(+), 1 deletion(-)
configure.ac +2 -1
@@ -62,6 +62,7 @@ AC_CHECK_HEADERS_ONCE([ \ linux/ioprio.h \ linux/keyctl.h \ linux/landlock.h \ + linux/lsm.h \ linux/mempolicy.h \ linux/module.h \ linux/mount.h \
@@ -196,7 +197,7 @@ AC_CHECK_TYPES([struct ipc64_perm],,,[#include <sys/ipcbuf.h>]) AC_CHECK_TYPES([struct loop_config],,,[#include <linux/loop.h>]) AC_CHECK_TYPES([struct landlock_path_beneath_attr],,,[#include <linux/landlock.h>]) AC_CHECK_TYPES([struct landlock_net_port_attr],,,[#include <linux/landlock.h>]) - +AC_CHECK_TYPES([struct lsm_ctx],,,[#include <linux/lsm.h>]) AC_CHECK_TYPES([struct mmsghdr],,,[ #define _GNU_SOURCE #include <sys/types.h>
include/lapi/lsm.h new file +172 -0
172 lines not on this page · raw message
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 1/7] Add fallback definitions of LSM syscalls
Quoted 44 lines · Andrea Cervesato
From: Andrea Cervesato <[email protected]>
Fallback definition for the following syscalls:
-
lsm_get_self_attr
-lsm_set_self_attr
-lsm_list_modulesSigned-off-by Andrea Cervesato <[email protected]>--- configure.ac | 3 +- include/lapi/lsm.h | 172 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 174 insertions(+), 1 deletion(-)configure.ac +2
-1@@ -62,6 +62,7 @@ AC_CHECK_HEADERS_ONCE([ \ linux/ioprio.h \ linux/keyctl.h \ linux/landlock.h \ + linux/lsm.h \ linux/mempolicy.h \ linux/module.h \ linux/mount.h \@@ -196,7 +197,7 @@ AC_CHECK_TYPES([struct ipc64_perm],,,[#include <sys/ipcbuf.h>]) AC_CHECK_TYPES([struct loop_config],,,[#include <linux/loop.h>]) AC_CHECK_TYPES([struct landlock_path_beneath_attr],,,[#include <linux/landlock.h>]) AC_CHECK_TYPES([struct landlock_net_port_attr],,,[#include <linux/landlock.h>]) - +AC_CHECK_TYPES([struct lsm_ctx],,,[#include <linux/lsm.h>]) AC_CHECK_TYPES([struct mmsghdr],,,[ #define _GNU_SOURCE #include <sys/types.h>include/lapi/lsm.h new file +3
-0@@ -0,0 +1,172 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]>
include/lapi/lsm.h line 13
Quoted 10 lines
include/lapi/lsm.h new file +10
-0+*/ + +#ifndef LAPI_LSM_H__ +#define LAPI_LSM_H__ + +#include "config.h" + +#ifdef HAVE_LINUX_LSM_H +#include <linux/lsm.h> +#endif
I guess s/#endif/#else ?
Quoted 166 lines
include/lapi/lsm.h new file +159
-0+ +#include <stdint.h> +#include "lapi/syscalls.h" + +#ifndef HAVE_STRUCT_LSM_CTX + +/** +* struct lsm_ctx - LSM context information +* @id: the LSM id number, see LSM_ID_XXX +* @flags: LSM specific flags +* @len: length of the lsm_ctx struct, @ctx and any other data or padding +* @ctx_len: the size of @ctx +* @ctx: the LSM context value +* +* The @len field MUST be equal to the size of the lsm_ctx struct +* plus any additional padding and/or data placed after @ctx. +* +* In all cases @ctx_len MUST be equal to the length of @ctx. +* If @ctx is a string value it should be nul terminated with +* @ctx_len equal to `strlen(@ctx) + 1`. Binary values are +* supported. +* +* The @flags and @ctx fields SHOULD only be interpreted by the +* LSM specified by @id; they MUST be set to zero/0 when not used. +*/ +struct lsm_ctx { +uint64_t id; +uint64_t flags; +uint64_t len; +uint64_t ctx_len; +uint8_t ctx[4096 ]; +}; +#endif + +/* +* ID tokens to identify Linux Security Modules (LSMs) +* +* These token values are used to uniquely identify specific LSMs +* in the kernel as well as in the kernel's LSM userspace API. +*/ +#ifndef LSM_ID_UNDEF +# define LSM_ID_UNDEF 0 +#endif + +#ifndef LSM_ID_CAPABILITY +# define LSM_ID_CAPABILITY 100 +#endif + +#ifndef LSM_ID_SELINUX +# define LSM_ID_SELINUX 101 +#endif + +#ifndef LSM_ID_SMACK +# define LSM_ID_SMACK 102 +#endif + +#ifndef LSM_ID_TOMOYO +# define LSM_ID_TOMOYO 103 +#endif + +#ifndef LSM_ID_APPARMOR +# define LSM_ID_APPARMOR 104 +#endif + +#ifndef LSM_ID_YAMA +# define LSM_ID_YAMA 105 +#endif + +#ifndef LSM_ID_LOADPIN +# define LSM_ID_LOADPIN 106 +#endif + +#ifndef LSM_ID_SAFESETID +# define LSM_ID_SAFESETID 107 +#endif + +#ifndef LSM_ID_LOCKDOWN +# define LSM_ID_LOCKDOWN 108 +#endif + +#ifndef LSM_ID_BPF +# define LSM_ID_BPF 109 +#endif + +#ifndef LSM_ID_LANDLOCK +# define LSM_ID_LANDLOCK 110 +#endif + +#ifndef LSM_ID_IMA +# define LSM_ID_IMA 111 +#endif + +#ifndef LSM_ID_EVM +# define LSM_ID_EVM 112 +#endif + +#ifndef LSM_ID_IPE +# define LSM_ID_IPE 113 +#endif + +/* +* LSM_ATTR_XXX definitions identify different LSM attributes +* which are used in the kernel's LSM userspace API. Support +* for these attributes vary across the different LSMs. None +* are required. +*/ +#ifndef LSM_ATTR_UNDEF +# define LSM_ATTR_UNDEF 0 +#endif + +#ifndef LSM_ATTR_CURRENT +# define LSM_ATTR_CURRENT 100 +#endif + +#ifndef LSM_ATTR_EXEC +# define LSM_ATTR_EXEC 101 +#endif + +#ifndef LSM_ATTR_FSCREATE +# define LSM_ATTR_FSCREATE 102 +#endif + +#ifndef LSM_ATTR_KEYCREATE +# define LSM_ATTR_KEYCREATE 103 +#endif + +#ifndef LSM_ATTR_PREV +# define LSM_ATTR_PREV 104 +#endif + +#ifndef LSM_ATTR_SOCKCREATE +# define LSM_ATTR_SOCKCREATE 105 +#endif + +/* +* LSM_FLAG_XXX definitions identify special handling instructions +* for the API. +*/ +#ifndef LSM_FLAG_SINGLE +# define LSM_FLAG_SINGLE 0x0001 +#endif + +static inline int lsm_get_self_attr (uint32_t attr,struct lsm_ctx *ctx, +uint32_t *size,uint32_t flags) +{ +return tst_syscall (__NR_lsm_get_self_attr, attr, ctx, size, flags); +} + +static inline int lsm_set_self_attr (uint32_t attr,struct lsm_ctx *ctx, +uint32_t size,uint32_t flags) +{ +return tst_syscall (__NR_lsm_set_self_attr, attr, ctx, size, flags); +} + +static inline int lsm_list_modules (uint64_t *ids,uint32_t *size,uint32_t flags) +{ +return tst_syscall (__NR_lsm_list_modules, ids, size, flags); +} +#endif Signature · 6 lines
-- 2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 1/7] Add fallback definitions of LSM syscalls
Hi all,
...
Quoted 4 lines
include/lapi/lsm.h line 13
Quoted 3 lines
include/lapi/lsm.h new file +3
-0+#ifdef HAVE_LINUX_LSM_H +#include <linux/lsm.h> +#endif I guess s/#endif/#else ?
IMHO this is correct. This guards just <linux/lsm.h> (added in 6.7). All other fallback definitions are guarded by other checks, because UAPI headers evolve over time, thus it would not help to guard all fallback definitions just by HAVE_LINUX_LSM_H. Check other lapi headers, vast majority of those who include header add fallback definitions will do it this way.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 1/7] Add fallback definitions of LSM syscalls
Quoted 8 lines · Petr Vorel
Hi all,
...
Quoted 4 lines
include/lapi/lsm.h line 13
Quoted 3 lines
include/lapi/lsm.h new file +3
-0+#ifdef HAVE_LINUX_LSM_H +#include <linux/lsm.h> +#endif I guess s/#endif/#else ?
Quoted 5 lines
IMHO this is correct. This guards just <
linux/lsm.h> (added in 6.7). All other fallback definitions are guarded by other checks, because UAPI headers evolve over time, thus it would not help to guard all fallback definitions just byHAVE_LINUX_LSM_H. Check other lapi headers, vast majority of those who include header add fallback definitions will do it this way.
Thanks for clarification!
Quoted 4 lines
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 1/7] Add fallback definitions of LSM syscalls
In reply to Andrea CervesatoHi Andrea,
Thanks!
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH 2/7 Add lsm_get_self_attr01 test
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Verify that lsm_get_self_attr syscall is raising errors when invalid data is provided.
--- runtest/syscalls | 2 + testcases/kernel/syscalls/lsm/Makefile | 7 ++ testcases/kernel/syscalls/lsm/lsm_common.h | 57 +++++++++++++++ .../kernel/syscalls/lsm/lsm_get_self_attr01.c | 81 ++++++++++++++++++++++ 4 files changed, 147 insertions(+)
runtest/syscalls +2 -0
@@ -756,6 +756,8 @@ lseek02 lseek02 lseek07 lseek07 lseek11 lseek11 +lsm_get_self_attr01 lsm_get_self_attr01 + lstat01 lstat01 lstat01_64 lstat01_64 lstat02 lstat02
testcases/kernel/syscalls/lsm/Makefile new file +7 -0
@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk +include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/syscalls/lsm/lsm_common.h new file +57 -0
57 lines not on this page · raw message
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +81 -0
81 lines not on this page · raw message
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 2/7] Add lsm_get_self_attr01 test
Hi Andrea,
[ Cc Casey, the author of the syscalls and kselftest tests ]
Quoted 9 lines
Verify that
lsm_get_self_attrsyscall is raising errors when invalid data is provided.Signed-off-by Andrea Cervesato <[email protected]>--- runtest/syscalls | 2 + testcases/kernel/syscalls/lsm/Makefile | 7 ++ testcases/kernel/syscalls/lsm/lsm_common.h | 57 +++++++++++++++ .../kernel/syscalls/lsm/lsm_get_self_attr01.c | 81 ++++++++++++++++++++++
You miss the change in .gitignore. You added it in the next commit. Could you please before merge rebase, so that it's added for lsm_get_self_attr01 in this commit? (in case of some revert).
Quoted 108 lines
4 files changed, 147 insertions(+)runtest/syscalls +2
-0@@ -756,6 +756,8 @@ lseek02 lseek02 lseek07 lseek07 lseek11 lseek11 +lsm_get_self_attr01 lsm_get_self_attr01 + lstat01 lstat01 lstat01_64 lstat01_64 lstat02 lstat02testcases/kernel/syscalls/lsm/Makefile new file +7
-0@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk +include $(top_srcdir)/include/mk/generic_leaf_target.mktestcases/kernel/syscalls/lsm/lsm_common.h new file +57
-0@@ -0,0 +1,57 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> +*/ + +#ifndef LSM_GET_SELF_ATTR_H +#define LSM_GET_SELF_ATTR_H + +#include "tst_test.h" +#include "lapi/lsm.h" + +static inline struct lsm_ctx *next_ctx (struct lsm_ctx *tctx) +{ +return (struct lsm_ctx *)((void *)tctx +sizeof (*tctx) + tctx->ctx_len); +} + +static inline void read_proc_attr (const char *attr,char *val,const size_t size) +{ +int fd; +char *ptr; +char path[BUFSIZ ]; + +memset (val,0 , size); +memset (path,0 ,BUFSIZ ); + +snprintf (path,BUFSIZ ,"/proc/self/attr/%s" , attr); + +tst_res (TINFO ,"Reading %s" , path); + + fd =SAFE_OPEN (path,O_RDONLY ); + +if (read (fd, val, size) >0 ) { + ptr =strchr (val,'\n' ); +if (ptr) + *ptr ='\0' ; + } + +SAFE_CLOSE (fd); +} + +static inline int verify_enabled_lsm (const char *name) +{ +int fd; +char data[BUFSIZ ]; + + fd =SAFE_OPEN ("/sys/kernel/security/lsm" ,O_RDONLY ); +SAFE_READ (0 , fd, data,BUFSIZ ); +SAFE_CLOSE (fd); + +if (!strstr (data, name)) { +tst_res (TINFO ,"%s is running" , name); +return 1 ; + } + +return 0 ; +} +#endif testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +11
-0@@ -0,0 +1,81 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> +*/ + +/*\ +* [Description] +* +* Verify that lsm_get_self_attr syscall is raising errors when invalid data is +* provided. +*/
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c line 21
Quoted 10 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +10
-0+ +#include "tst_test.h" +#include "lapi/lsm.h" + +static struct lsm_ctx *ctx; +static uint32_t ctx_size; +static uint32_t ctx_size_small; + +static struct tcase { + uint32_t attr;
.attr = LSM_ATTR_CURRENT is the same for all 4 testcases. Can you please remove it from the test struct and use it directly?
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c line 22
Quoted 1 line
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +1
-0+struct lsm_ctx **ctx;
The same applies to ctx.
Also, kselftest test tools/testing/selftests/lsm/lsm_get_self_attr_test.c is testing also for ctx being NULL. Then it would make sense to use it. You would then need to use verify_enabled_lsm(), which you added in this commit but not use it (e.g. lsm_get_self_attr_test.c in kselftest checks for values when no lsm is set). Obviously you would have to store also errno for the case when lsm is not stored.
On some Tumbleweed VM (6.10.0-rc7) I have the default:
$ cat /sys/kernel/security/lsm lockdown,capability,landlock,yama,apparmor,bpf,ima,evm
When I boot with lsm= kernel parameter, I get:
$ cat /sys/kernel/security/lsm lockdown,capability,ima,evm
And with that test fails:
# ./lsm_get_self_attr01 tst_buffers.c:57: TINFO: Test is using guarded buffers tst_test.c:1893: TINFO: LTP version: 20240930-146-gccd20cd77 tst_test.c:1897: TINFO: Tested kernel: 6.10.0-rc7-3.g92abc10-default #1 SMP PREEMPT_DYNAMIC Wed Jul 10 14:15:11 UTC 2024 (92abc10) x86_64 tst_test.c:1728: TINFO: Timeout per run is 0h 00m 30s lsm_get_self_attr01.c:67: TPASS: size is NULL : EINVAL (22) lsm_get_self_attr01.c:67: TPASS: flags is invalid : EINVAL (22) lsm_get_self_attr01.c:67: TFAIL: size is too smal expected E2BIG: EOPNOTSUPP (95) lsm_get_self_attr01.c:67: TPASS: flags force to use ctx attributes : EINVAL (22)
=> I would vote for having 2 variants to use EOPNOTSUPP or at least check with verify_enabled_lsm() and TCONF. Otherwise sooner or later somebody report a bug in the test.
Kind regards,
Petr
Quoted 59 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +59
-0+uint32_t *size; +uint32_t flags; +int exp_err; +char *msg; +} tcases[] = { + { + .attr = LSM_ATTR_CURRENT, + .ctx = &ctx, + .exp_err = EINVAL, + .msg = "size is NULL", + }, + { + .attr = LSM_ATTR_CURRENT, + .ctx = &ctx, + .size = &ctx_size, + .flags = LSM_FLAG_SINGLE | (LSM_FLAG_SINGLE << 1), + .exp_err = EINVAL, + .msg = "flags is invalid", + }, + { + .attr = LSM_ATTR_CURRENT, + .ctx = &ctx, + .size = &ctx_size_small, + .exp_err = E2BIG, + .msg = "size is too smal", + }, + { + .attr = LSM_ATTR_CURRENT, + .ctx = &ctx, + .size = &ctx_size, + .flags = LSM_FLAG_SINGLE, + .exp_err = EINVAL, + .msg = "flags force to use ctx attributes", + }, +}; + +static void run(unsigned int n) +{ + struct tcase *tc = &tcases[n]; + + memset(ctx, 0, sizeof(struct lsm_ctx)); + ctx_size = sizeof(struct lsm_ctx); + ctx_size_small = 1; + + TST_EXP_FAIL(lsm_get_self_attr( + LSM_ATTR_CURRENT, *tc->ctx, tc->size, tc->flags), + tc->exp_err, + "%s", tc->msg); +} + +static struct tst_test test = { + .test = run, + .tcnt = ARRAY_SIZE(tcases), + .min_kver = "6.8", + .bufs = (struct tst_buffers[]) { + {&ctx, .size = sizeof(struct lsm_ctx)}, + {} + }, +};
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 2/7] Add lsm_get_self_attr01 test
Hi Petr,
Quoted 2 lines · Petr Vorel
Also, kselftest test
tools/testing/selftests/lsm/lsm_get_self_attr_test.cis testing also for ctx being NULL. Then it would make sense to use it.
Now I remember why I skipped this part. The kselftest is checking in this way (that's how library works apparently):
TEST(ctx_null_lsm_get_self_attr)
{
const long page_size = sysconf(_SC_PAGESIZE);
__u32 size = page_size;
int rc;
rc = lsm_get_self_attr(LSM_ATTR_CURRENT, NULL, &size, 0);
if (attr_lsm_count()) {
ASSERT_NE(-1, rc);
ASSERT_NE(1, size);
} else {
ASSERT_EQ(-1, rc);
}
}
If there are LSM implementations in the system, "lsm_get_self_attr" won't return any error code but 0. If there are NOT implementations, the syscall will return -1.
Andrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 2/7] Add lsm_get_self_attr01 test
In reply to Petr VorelHi Petr,
Quoted 12 lines · Petr Vorel
Hi Andrea,
[ Cc Casey, the author of the syscalls and kselftest tests ]
Quoted 8 lines
Verify that
lsm_get_self_attrsyscall is raising errors when invalid data is provided.Signed-off-by Andrea Cervesato <[email protected]>--- runtest/syscalls | 2 + testcases/kernel/syscalls/lsm/Makefile | 7 ++ testcases/kernel/syscalls/lsm/lsm_common.h | 57 +++++++++++++++ .../kernel/syscalls/lsm/lsm_get_self_attr01.c | 81 ++++++++++++++++++++++
Quoted 3 lines
You miss the change in .gitignore. You added it in the next commit. Could you please before merge rebase, so that it's added for
lsm_get_self_attr01in this commit? (in case of some revert).
+1
Quoted 110 lines
Quoted 110 lines
4 files changed, 147 insertions(+)runtest/syscalls +2
-0@@ -756,6 +756,8 @@ lseek02 lseek02 lseek07 lseek07 lseek11 lseek11 +lsm_get_self_attr01 lsm_get_self_attr01 + lstat01 lstat01 lstat01_64 lstat01_64 lstat02 lstat02testcases/kernel/syscalls/lsm/Makefile new file +7
-0@@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> + +top_srcdir ?= ../../../.. + +include $(top_srcdir)/include/mk/testcases.mk +include $(top_srcdir)/include/mk/generic_leaf_target.mktestcases/kernel/syscalls/lsm/lsm_common.h new file +57
-0@@ -0,0 +1,57 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> +*/ + +#ifndef LSM_GET_SELF_ATTR_H +#define LSM_GET_SELF_ATTR_H + +#include "tst_test.h" +#include "lapi/lsm.h" + +static inline struct lsm_ctx *next_ctx (struct lsm_ctx *tctx) +{ +return (struct lsm_ctx *)((void *)tctx +sizeof (*tctx) + tctx->ctx_len); +} + +static inline void read_proc_attr (const char *attr,char *val,const size_t size) +{ +int fd; +char *ptr; +char path[BUFSIZ ]; + +memset (val,0 , size); +memset (path,0 ,BUFSIZ ); + +snprintf (path,BUFSIZ ,"/proc/self/attr/%s" , attr); + +tst_res (TINFO ,"Reading %s" , path); + + fd =SAFE_OPEN (path,O_RDONLY ); + +if (read (fd, val, size) >0 ) { + ptr =strchr (val,'\n' ); +if (ptr) + *ptr ='\0' ; + } + +SAFE_CLOSE (fd); +} + +static inline int verify_enabled_lsm (const char *name) +{ +int fd; +char data[BUFSIZ ]; + + fd =SAFE_OPEN ("/sys/kernel/security/lsm" ,O_RDONLY ); +SAFE_READ (0 , fd, data,BUFSIZ ); +SAFE_CLOSE (fd); + +if (!strstr (data, name)) { +tst_res (TINFO ,"%s is running" , name); +return 1 ; + } + +return 0 ; +} +#endif testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +15
-0@@ -0,0 +1,81 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> +*/ + +/*\ +* [Description] +* +* Verify that lsm_get_self_attr syscall is raising errors when invalid data is +* provided. +*/ + +#include "tst_test.h" +#include "lapi/lsm.h" +
Quoted 8 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c line 21
Quoted 6 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +6
-0+static struct lsm_ctx *ctx; +static uint32_t ctx_size; +static uint32_t ctx_size_small; + +static struct tcase { + uint32_t attr;.attr =
LSM_ATTR_CURRENTis the same for all 4 testcases. Can you please remove it from the test struct and use it directly?
I will keep it in order to test EOPNOTSUPP for overset attr flag, I will add this test case in the next version of the patchset.
Quoted 5 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c line 22
Quoted 2 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +1
-0+struct lsm_ctx **ctx;The same applies to ctx.
Also, kselftest test
tools/testing/selftests/lsm/lsm_get_self_attr_test.cis
This is tested by lsm_get_self_attr02.
Quoted 28 lines
testing also for ctx being NULL. Then it would make sense to use it. You would then need to use
verify_enabled_lsm(), which you added in this commit but not use it (e.g.lsm_get_self_attr_test.cin kselftest checks for values when no lsm is set). Obviously you would have to store also errno for the case when lsm is not stored.On some Tumbleweed VM (6.10.0-rc7) I have the default:
$ cat /sys/kernel/security/lsm lockdown,capability,landlock,yama,apparmor,bpf,ima,evmWhen I boot with lsm= kernel parameter, I get:
$ cat /sys/kernel/security/lsm lockdown,capability,ima,evmAnd with that test fails:
# ./lsm_get_self_attr01 tst_buffers.c:57: TINFO: Test is using guarded buffers tst_test.c:1893: TINFO: LTP version: 20240930-146-gccd20cd77 tst_test.c:1897: TINFO: Tested kernel: 6.10.0-rc7-3.g92abc10-default #1 SMP PREEMPT_DYNAMIC Wed Jul 10 14:15:11 UTC 2024 (92abc10) x86_64 tst_test.c:1728: TINFO: Timeout per run is 0h 00m 30s lsm_get_self_attr01.c:67: TPASS: size is NULL : EINVAL (22) lsm_get_self_attr01.c:67: TPASS: flags is invalid : EINVAL (22) lsm_get_self_attr01.c:67: TFAIL: size is too smal expected E2BIG: EOPNOTSUPP (95) lsm_get_self_attr01.c:67: TPASS: flags force to use ctx attributes : EINVAL (22)
Quoted 3 lines
=> I would vote for having 2 variants to use EOPNOTSUPP or at least check with
verify_enabled_lsm()and TCONF. Otherwise sooner or later somebody report a bug in the test.
Yeah, probably this is the best approach. I will add a helper checking for current LSM and eventually TCONF if they are not present in combination with LSM_ATTR_CURRENT.
Andrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 2/7] Add lsm_get_self_attr01 test
In reply to Andrea CervesatoHi!
Quoted 5 lines
testcases/kernel/syscalls/lsm/lsm_common.h new file +4
-0@@ -0,0 +1,57 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> +*/
testcases/kernel/syscalls/lsm/lsm_common.h line 14
Quoted 10 lines
testcases/kernel/syscalls/lsm/lsm_common.h new file +10
-0+ +#ifndef LSM_GET_SELF_ATTR_H +#define LSM_GET_SELF_ATTR_H + +#include "tst_test.h" +#include "lapi/lsm.h" + +static inline struct lsm_ctx *next_ctx (struct lsm_ctx *tctx) +{ +return (struct lsm_ctx *)((void *)tctx +sizeof (*tctx) + tctx->ctx_len);
The cast to (struct lsm_ctx *) here is useless, C will cast it automatically upon returning the value from the function.
Quoted 29 lines
testcases/kernel/syscalls/lsm/lsm_common.h new file +29
-0+} + +static inline void read_proc_attr (const char *attr,char *val,const size_t size) +{ +int fd; +char *ptr; +char path[BUFSIZ ]; + +memset (val,0 , size); +memset (path,0 ,BUFSIZ ); + +snprintf (path,BUFSIZ ,"/proc/self/attr/%s" , attr); + +tst_res (TINFO ,"Reading %s" , path); + + fd =SAFE_OPEN (path,O_RDONLY ); + +if (read (fd, val, size) >0 ) { + ptr =strchr (val,'\n' ); +if (ptr) + *ptr ='\0' ; + } + +SAFE_CLOSE (fd); +} + +static inline int verify_enabled_lsm (const char *name) +{ +int fd;
testcases/kernel/syscalls/lsm/lsm_common.h line 53
Quoted 10 lines
testcases/kernel/syscalls/lsm/lsm_common.h new file +10
-0+char data[BUFSIZ ]; + + fd =SAFE_OPEN ("/sys/kernel/security/lsm" ,O_RDONLY ); +SAFE_READ (0 , fd, data,BUFSIZ ); +SAFE_CLOSE (fd); + +if (!strstr (data, name)) { +tst_res (TINFO ,"%s is running" , name); +return 1 ; + }
The strstr() is not future proof here. If somebody adds a lsm with a name that is substring of current lsm name, the strstr() will produce false possitive.
It's better to iterate over the data with strtok() and compare exact names with strcmp().
Quoted 80 lines
testcases/kernel/syscalls/lsm/lsm_common.h new file +3
-0+ return 0; +} +#endif testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +71
-0@@ -0,0 +1,81 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> +*/ + +/*\ +* [Description] +* +* Verify that lsm_get_self_attr syscall is raising errors when invalid data is +* provided. +*/ + +#include "tst_test.h" +#include "lapi/lsm.h" + +static struct lsm_ctx *ctx; +static uint32_t ctx_size; +static uint32_t ctx_size_small; + +static struct tcase { +uint32_t attr; +struct lsm_ctx **ctx; +uint32_t *size; +uint32_t flags; +int exp_err; +char *msg; +} tcases[] = { + { + .attr =LSM_ATTR_CURRENT , + .ctx = &ctx, + .exp_err =EINVAL , + .msg ="size is NULL" , + }, + { + .attr =LSM_ATTR_CURRENT , + .ctx = &ctx, + .size = &ctx_size, + .flags =LSM_FLAG_SINGLE | (LSM_FLAG_SINGLE <<1 ), + .exp_err =EINVAL , + .msg ="flags is invalid" , + }, + { + .attr =LSM_ATTR_CURRENT , + .ctx = &ctx, + .size = &ctx_size_small, + .exp_err =E2BIG , + .msg ="size is too smal" , + }, + { + .attr =LSM_ATTR_CURRENT , + .ctx = &ctx, + .size = &ctx_size, + .flags =LSM_FLAG_SINGLE , + .exp_err =EINVAL , + .msg ="flags force to use ctx attributes" , + }, +}; + +static void run (unsigned int n) +{ +struct tcase *tc = &tcases[n]; + +memset (ctx,0 ,sizeof (struct lsm_ctx )); + ctx_size =sizeof (struct lsm_ctx ); + ctx_size_small =1 ; + +TST_EXP_FAIL (lsm_get_self_attr ( +LSM_ATTR_CURRENT , *tc->ctx, tc->size, tc->flags), + tc->exp_err, +"%s" , tc->msg); +}
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c line 81
Quoted 10 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr01.c new file +10
-0+ +static struct tst_test test = { + .test = run, + .tcnt =ARRAY_SIZE (tcases), + .min_kver ="6.8" , + .bufs = (struct tst_buffers []) { + {&ctx, .size =sizeof (struct lsm_ctx )}, + {} + }, +};
The test itself looks good.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH 3/7 Add lsm_get_self_attr02 test
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Verify that lsm_get_self_attr syscall is acting correctly when ctx is NULL. The syscall can behave in different ways according to the current system status:
- if any LSM is running inside the system, the syscall will pass and it will provide a size as big as the attribute
- if no LSM(s) are running inside the system, the syscall will fail with -1 return code
--- runtest/syscalls | 1 + testcases/kernel/syscalls/lsm/.gitignore | 2 + .../kernel/syscalls/lsm/lsm_get_self_attr02.c | 55 ++++++++++++++++++++++ 3 files changed, 58 insertions(+)
runtest/syscalls +1 -0
@@ -757,6 +757,7 @@ lseek07 lseek07 lseek11 lseek11 lsm_get_self_attr01 lsm_get_self_attr01 +lsm_get_self_attr02 lsm_get_self_attr02 lstat01 lstat01 lstat01_64 lstat01_64
testcases/kernel/syscalls/lsm/.gitignore new file +2 -0
@@ -0,0 +1,2 @@ +lsm_get_self_attr01 +lsm_get_self_attr02
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c new file +55 -0
55 lines not on this page · raw message
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 3/7] Add lsm_get_self_attr02 test
Quoted 63 lines · Andrea Cervesato
From: Andrea Cervesato <[email protected]>
Verify that
lsm_get_self_attrsyscall is acting correctly when ctx is NULL. The syscall can behave in different ways according to the current system status:- if any LSM is running inside the system, the syscall will pass and it will provide a size as big as the attribute
- if no LSM(s) are running inside the system, the syscall will fail with -1 return codeSigned-off-by Andrea Cervesato <[email protected]>--- runtest/syscalls | 1 + testcases/kernel/syscalls/lsm/.gitignore | 2 + .../kernel/syscalls/lsm/lsm_get_self_attr02.c | 55 ++++++++++++++++++++++ 3 files changed, 58 insertions(+)runtest/syscalls +1
-0@@ -757,6 +757,7 @@ lseek07 lseek07 lseek11 lseek11 lsm_get_self_attr01 lsm_get_self_attr01 +lsm_get_self_attr02 lsm_get_self_attr02 lstat01 lstat01 lstat01_64 lstat01_64testcases/kernel/syscalls/lsm/.gitignore new file +2
-0@@ -0,0 +1,2 @@ +lsm_get_self_attr01 +lsm_get_self_attr02testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c new file +19
-0@@ -0,0 +1,55 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* +* Copyright (C) 2024 SUSE LLC Andrea Cervesato <[email protected]> +*/ + +/*\ +* [Description] +* +* Verify that lsm_get_self_attr syscall is acting correctly when ctx is NULL. +* The syscall can behave in different ways according to the current system +* status: +* +* - if any LSM is running inside the system, the syscall will pass and it will +* provide a size as big as the attribute +* - if no LSM(s) are running inside the system, the syscall will fail with -1 +* return code +*/ +#include "lsm_common.h" +
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c line 29
Quoted 10 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c new file +10
-0+static uint32_t page_size; +static uint32_t lsm_count; + +static void run (void ) +{ +uint32_t size = page_size; + +if (lsm_count) { +TST_EXP_EXPR (lsm_get_self_attr ( +LSM_ATTR_CURRENT ,NULL , &size,0 ) >=1 );
TST_EXP_POSSITIVE()?
Also I'm a bit confused here, where is the size returned as the return value from the syscall() or is the size argument modified?
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c line 33
Quoted 4 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c new file +4
-0+TST_EXP_EXPR (size >1 ); + }else { +TST_EXP_EQ_LI (lsm_get_self_attr ( +LSM_ATTR_CURRENT ,NULL , &size,0 ),-1 );
TST_EXP_FAIL()?
Quoted 5 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c new file +5
-0+ } +} + +static void setup (void ) +{
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c line 48
Quoted 10 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c new file +10
-0+ page_size =SAFE_SYSCONF (_SC_PAGESIZE); + +if (verify_enabled_lsm ("selinux" )) + lsm_count++; + +if (verify_enabled_lsm ("apparmor" )) + lsm_count++; + +if (verify_enabled_lsm ("smack" )) + lsm_count++;
Shouldn't we just look at the /sys/kernel/security/lsm file and if it exists and it's not empty there is a lsm on the system and the syscall will not fail in that case?
Quoted 14 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c new file +7
-0+} + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .min_kver ="6.8" , +};Signature · 6 lines
-- 2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 3/7] Add lsm_get_self_attr02 test
Hi Cyril,
Quoted 3 lines · Cyril Hrubis
Shouldn't we just look at the
/sys/kernel/security/lsmfile and if it exists and it's not empty there is a lsm on the system and the syscall will not fail in that case?
Unfortunately not, selinux, apparmor and smack are the only ones which are supported by LSM_ATTR_CURRENT.
https://docs.kernel.org/userspace-api/lsm.html
Andrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 3/7] Add lsm_get_self_attr02 test
In reply to Cyril HrubisHi!
Quoted 8 lines
Quoted 8 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c new file +8
-0+static void setup (void ) +{ + page_size =SAFE_SYSCONF (_SC_PAGESIZE); + +if (verify_enabled_lsm ("selinux" )) + lsm_count++; + +if (verify_enabled_lsm ("apparmor" ))
Quoted 8 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c line 48
Quoted 4 lines
testcases/kernel/syscalls/lsm/lsm_get_self_attr02.c new file +4
-0+ lsm_count++; + +if (verify_enabled_lsm ("smack" )) + lsm_count++;Shouldn't we just look at the
/sys/kernel/security/lsmfile and if it exists and it's not empty there is a lsm on the system and the syscall will not fail in that case?
And looking into the documentation these attributes are currently supported only by these three lsms. So this is correct, however the pattern is repeated in other tests, so maybe put it into a inline function into a common header?
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH 4/7 Add lsm_get_self_attr03 test
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Verify that LSM_ATTR_CURRENT attribute is correctly recognizing the current, active security context of the process. This is done by checking that /proc/self/attr/current matches with the obtained value.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/lsm/.gitignore | 1 + .../kernel/syscalls/lsm/lsm_get_self_attr03.c | 82 ++++++++++++++++++++++ 3 files changed, 84 insertions(+)
runtest/syscalls +1 -0
@@ -758,6 +758,7 @@ lseek11 lseek11 lsm_get_self_attr01 lsm_get_self_attr01 lsm_get_self_attr02 lsm_get_self_attr02 +lsm_get_self_attr03 lsm_get_self_attr03 lstat01 lstat01 lstat01_64 lstat01_64
testcases/kernel/syscalls/lsm/.gitignore +1 -0
@@ -1,2 +1,3 @@ lsm_get_self_attr01 lsm_get_self_attr02 +lsm_get_self_attr03
testcases/kernel/syscalls/lsm/lsm_get_self_attr03.c new file +82 -0
82 lines not on this page · raw message
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH 5/7 Add lsm_list_modules01 test
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Verify that lsm_list_modules syscall is raising errors when invalid data is provided.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/lsm/.gitignore | 1 + testcases/kernel/syscalls/lsm/lsm_list_modules01.c | 77 ++++++++++++++++++++++ 3 files changed, 79 insertions(+)
runtest/syscalls +1 -0
@@ -759,6 +759,7 @@ lseek11 lseek11 lsm_get_self_attr01 lsm_get_self_attr01 lsm_get_self_attr02 lsm_get_self_attr02 lsm_get_self_attr03 lsm_get_self_attr03 +lsm_list_modules01 lsm_list_modules01 lstat01 lstat01 lstat01_64 lstat01_64
testcases/kernel/syscalls/lsm/.gitignore +1 -0
@@ -1,3 +1,4 @@ lsm_get_self_attr01 lsm_get_self_attr02 lsm_get_self_attr03 +lsm_list_modules01
testcases/kernel/syscalls/lsm/lsm_list_modules01.c new file +77 -0
77 lines not on this page · raw message
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 5/7] Add lsm_list_modules01 test
Hi!
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH 6/7 Add lsm_list_modules02 test
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Verify that lsm_list_modules syscall is correctly recognizing LSM(s) enabled inside the system.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/lsm/.gitignore | 1 + testcases/kernel/syscalls/lsm/lsm_list_modules02.c | 134 +++++++++++++++++++++ 3 files changed, 136 insertions(+)
runtest/syscalls +1 -0
@@ -760,6 +760,7 @@ lsm_get_self_attr01 lsm_get_self_attr01 lsm_get_self_attr02 lsm_get_self_attr02 lsm_get_self_attr03 lsm_get_self_attr03 lsm_list_modules01 lsm_list_modules01 +lsm_list_modules02 lsm_list_modules02 lstat01 lstat01 lstat01_64 lstat01_64
testcases/kernel/syscalls/lsm/.gitignore +1 -0
@@ -2,3 +2,4 @@ lsm_get_self_attr01 lsm_get_self_attr02 lsm_get_self_attr03 lsm_list_modules01 +lsm_list_modules02
testcases/kernel/syscalls/lsm/lsm_list_modules02.c new file +134 -0
134 lines not on this page · raw message
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 6/7] Add lsm_list_modules02 test
Hi!
testcases/kernel/syscalls/lsm/lsm_list_modules02.c line 105
Quoted 4 lines
testcases/kernel/syscalls/lsm/lsm_list_modules02.c new file +4
-0+if (!name) +tst_brk (TBROK ,"Unsupported LSM: %lu" , ids[i]); + +if (strstr (name, lsm_list))
Again here the strstr() is not future proof. There is no lsm with the name as a substring of a different lsm, but it's not entirely unlikely that a lsm with name that contains one of the three letter names as a substring in the future.
So I guess that we may as well break the lsm list into an array of strings with strtok() in the setup and add a function that loops on the array and does strcmp() for each entry in that array.
testcases/kernel/syscalls/lsm/lsm_list_modules02.c line 111
Quoted 6 lines
testcases/kernel/syscalls/lsm/lsm_list_modules02.c new file +6
-0+tst_res (TFAIL ,"'%s' has not been found" , name); + else + tst_res(TPASS, "'%s' is enabled", name); + } + +TST_EXP_EQ_LI (*size, counter *sizeof (uint64_t ));
So we get literal size in the size and number of elements as the return value. Sounds good.
testcases/kernel/syscalls/lsm/lsm_list_modules02.c line 112
Quoted 1 line
testcases/kernel/syscalls/lsm/lsm_list_modules02.c new file +1
-0+TST_EXP_EQ_LI (lsm_num, counter);
Isn't this true by definition? We do tst_brk(TBROK, "") on unknown lsm so if the counter is not increased on each lsm_num iteration we exit the test with tst_brk() and never reach this line.
And hat is actually missing here is to compare the number of lsm names in the /sys/kernel/security/lsm file with the lsm_num. But for that we have to break the file content into tokens and count them, which we need to do anyways.
Quoted 29 lines
testcases/kernel/syscalls/lsm/lsm_list_modules02.c new file +22
-0+} + +static void setup (void ) +{ +int fd; + + page_size =SAFE_SYSCONF (_SC_PAGESIZE); + fd =SAFE_OPEN ("/sys/kernel/security/lsm" ,O_RDONLY ); +SAFE_READ (0 , fd, lsm_list,BUFSIZ ); +SAFE_CLOSE (fd); +} + +static struct tst_test test = { + .test_all = run, + .setup = setup, + .min_kver ="6.8" , + .bufs = (struct tst_buffers []) { + {&ids, .size =sizeof (uint64_t ) *MAX_LSM_NUM }, + {&size, .size =sizeof (uint32_t )}, + {}, + }, +};Signature · 6 lines
-- 2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
PATCH 7/7 Add lsm_set_self_attr01 test
In reply to Andrea CervesatoFrom: Andrea Cervesato <[email protected]>
Verify that lsm_set_self_attr syscall is raising errors when invalid data is provided.
--- runtest/syscalls | 1 + testcases/kernel/syscalls/lsm/.gitignore | 1 + .../kernel/syscalls/lsm/lsm_set_self_attr01.c | 123 +++++++++++++++++++++ 3 files changed, 125 insertions(+)
runtest/syscalls +1 -0
@@ -761,6 +761,7 @@ lsm_get_self_attr02 lsm_get_self_attr02 lsm_get_self_attr03 lsm_get_self_attr03 lsm_list_modules01 lsm_list_modules01 lsm_list_modules02 lsm_list_modules02 +lsm_set_self_attr01 lsm_set_self_attr01 lstat01 lstat01 lstat01_64 lstat01_64
testcases/kernel/syscalls/lsm/.gitignore +1 -0
@@ -3,3 +3,4 @@ lsm_get_self_attr02 lsm_get_self_attr03 lsm_list_modules01 lsm_list_modules02 +lsm_set_self_attr01
testcases/kernel/syscalls/lsm/lsm_set_self_attr01.c new file +123 -0
123 lines not on this page · raw message
Signature · 5 lines
2.43.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 7/7] Add lsm_set_self_attr01 test
Hi Andrea,
Quoted 2 lines
Verify that
lsm_set_self_attrsyscall is raising errors when invalid data is provided.
As I wrote at 2nd patch [1], booting with lsm= breaks all but lsm_list_modules0[12].c. E.g. in this patch:
# ./lsm_set_self_attr01 tst_buffers.c:57: TINFO: Test is using guarded buffers tst_test.c:1893: TINFO: LTP version: 20240930-146-gccd20cd77 tst_test.c:1897: TINFO: Tested kernel: 6.10.0-rc7-3.g92abc10-default #1 SMP PREEMPT_DYNAMIC Wed Jul 10 14:15:11 UTC 2024 (92abc10) x86_64 tst_test.c:1728: TINFO: Timeout per run is 0h 00m 30s lsm_common.h:51: TINFO: selinux is running lsm_common.h:51: TINFO: apparmor is running lsm_common.h:51: TINFO: smack is running lsm_set_self_attr01.c:110: TBROK: Can't read LSM current attribute
FYI lsm= bot parameter causes setup (at least on Tumbleweed kernel config):
$ cat /sys/kernel/security/lsm lockdown,capability,ima,evm
Kind regards,
Petr
[2] https://lore.kernel.org/ltp/20241218185508.GA77804@pevik/
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Re: [LTP] [PATCH 7/7] Add lsm_set_self_attr01 test
Hi Petr,
Quoted 17 lines · Petr Vorel
Hi Andrea,
Quoted 2 lines
Verify that
lsm_set_self_attrsyscall is raising errors when invalid data is provided.As I wrote at 2nd patch [1], booting with lsm= breaks all but lsm_list_modules0[12].c. E.g. in this patch:
# ./lsm_set_self_attr01 tst_buffers.c:57: TINFO: Test is using guarded buffers tst_test.c:1893: TINFO: LTP version: 20240930-146-gccd20cd77 tst_test.c:1897: TINFO: Tested kernel: 6.10.0-rc7-3.g92abc10-default #1 SMP PREEMPT_DYNAMIC Wed Jul 10 14:15:11 UTC 2024 (92abc10) x86_64 tst_test.c:1728: TINFO: Timeout per run is 0h 00m 30s lsm_common.h:51: TINFO: selinux is running lsm_common.h:51: TINFO: apparmor is running lsm_common.h:51: TINFO: smack is running lsm_set_self_attr01.c:110: TBROK: Can't read LSM current attribute
Quoted 3 lines
FYI lsm= bot parameter causes setup (at least on Tumbleweed kernel config):
$ cat /sys/kernel/security/lsm lockdown,capability,ima,evm
Are you sure about it? In the logs I clearly see that selinux, apparmor and smack are running. The way this is checked is exactly by looking at the string coming from /sys/kernel/security/lsm
Quoted 5 lines
Kind regards,
Petr[2] https://lore.kernel.org/ltp/20241218185508.GA77804@pevik/
Andrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp