Handle OFD lock flags
PATCH v2 1/1 Handle OFD lock flags
Linux 3.15 and newer introduced new open file description locks. Currently pseudo prints a warning if fcntl is used with OFD locks:
unknown fcntl argument 37, assuming long argument.
However, calls to fcntl with a OFC lock set need a struct flock pointer. Treat F_OFD_GETLK (and friends) like F_GETLK (and friends).
This issue has been observed with ostree. Comparing strace output between two runs with/without this patch shows the same fcntl calls, hence it seems not to matter in practice.
--- ports/linux/guts/fcntl.c | 5 +++++ 1 file changed, 5 insertions(+)
ports/linux/guts/fcntl.c +5 -0
@@ -52,6 +52,11 @@case F_GETLK :case F_SETLK :case F_SETLKW : +#ifdef F_OFD_GETLK +case F_OFD_GETLK : +case F_OFD_SETLK : +case F_OFD_SETLKW : +#endif rc =real_fcntl (fd, cmd, lock);break ;#if defined(F_GETLK64 ) && (F_GETLK64 !=F_GETLK )
Signature · 1 line
2.27.0
✗ patchtest: failure for Handle OFD lock flags (rev2)
== Series Details ==
Series: Handle OFD lock flags (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/15665/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at 532ae127c5)
* Patch [v2] Handle OFD lock flags Issue Shortlog does not follow expected format [test_shortlog_format] Suggested fix Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"
If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
Re: ✗ patchtest: failure for Handle OFD lock flags (rev2)
I guess I should have prefixed that one with [pseudo].
--
Stefan
Quoted 41 lines · Patchwork
== Series Details ==
Series: Handle OFD lock flags (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/15665/
State : failure== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:
* Issue Series does not apply on top of target branch
[test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at532ae127c5)* Patch [v2] Handle OFD lock flags
Issue Shortlog does not follow expected format
[test_shortlog_format]
Suggested fix Commit shortlog (first line of commit message)
should follow the format "<target>: <summary>"If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).
---
Guidelines:
https://www.openembedded.org/wiki/Commit_Patch_Message_GuidelinesTest framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe