xen: Fix Kconfig indentation
PATCH 1/1 xen: Fix Kconfig indentation
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like:
$ sed -e 's/^ /\t/' -i */Kconfig
--- drivers/xen/Kconfig | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/xen/Kconfig +11 -11
@@ -110,12 +110,12 @@ config XEN_COMPAT_XENFS depends on XENFS default y help - The old xenstore userspace tools expect to find "xenbus" - under /proc/xen, but "xenbus" is now found at the root of the - xenfs filesystem. Selecting this causes the kernel to create - the compatibility mount point /proc/xen if it is running on - a xen platform. - If in doubt, say yes. + The old xenstore userspace tools expect to find "xenbus" + under /proc/xen, but "xenbus" is now found at the root of the + xenfs filesystem. Selecting this causes the kernel to create + the compatibility mount point /proc/xen if it is running on + a xen platform. + If in doubt, say yes. config XEN_SYS_HYPERVISOR bool "Create xen entries under /sys/hypervisor"
@@ -123,7 +123,7 @@ config XEN_SYS_HYPERVISOR select SYS_HYPERVISOR default y help - Create entries under /sys/hypervisor describing the Xen + Create entries under /sys/hypervisor describing the Xen hypervisor environment. When running native or in another virtual environment, /sys/hypervisor will still be present, but will have no xen contents.
@@ -271,7 +271,7 @@ config XEN_ACPI_PROCESSOR depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ default m help - This ACPI processor uploads Power Management information to the Xen + This ACPI processor uploads Power Management information to the Xen hypervisor. To do that the driver parses the Power Management data and uploads
@@ -280,7 +280,7 @@ config XEN_ACPI_PROCESSOR SMM so that other drivers (such as ACPI cpufreq scaling driver) will not load. - To compile this driver as a module, choose M here: the module will be + To compile this driver as a module, choose M here: the module will be called xen_acpi_processor If you do not know what to choose, select M here. If the CPUFREQ drivers are built in, select Y here.
@@ -313,8 +313,8 @@ config XEN_SYMS depends on X86 && XEN_DOM0 && XENFS default y if KALLSYMS help - Exports hypervisor symbols (along with their types and addresses) via - /proc/xen/xensyms file, similar to /proc/kallsyms + Exports hypervisor symbols (along with their types and addresses) via + /proc/xen/xensyms file, similar to /proc/kallsyms config XEN_HAVE_VPMU bool
Signature · 1 line
2.17.1
Quoted 19 lines · Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like:
$ sed -e 's/^ /\t/' -i */KconfigSigned-off-by Krzysztof Kozlowski <[email protected]>--- drivers/xen/Kconfig | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)drivers/xen/Kconfig +0
-2@@ -110,12 +110,12 @@ config XEN_COMPAT_XENFS depends on XENFS default y help - The old xenstore userspace tools expect to find "xenbus" - under /proc/xen, but "xenbus" is now found at the root of the
drivers/xen/Kconfig config XEN_COMPAT_XENFS · line 118
Quoted 10 lines
drivers/xen/Kconfig +6
-4- xenfs filesystem. Selecting this causes the kernel to create - the compatibility mount point /proc/xen if it is running on - a xen platform. - If in doubt, say yes. + The old xenstore userspace tools expect to find "xenbus" + under /proc/xen, but "xenbus" is now found at the root of the + xenfs filesystem. Selecting this causes the kernel to create + the compatibility mount point /proc/xen if it is running on + a xen platform. + If in doubt, say yes.
Here and ...
drivers/xen/Kconfig config XEN_SYS_HYPERVISOR · line 129
Quoted 9 lines
drivers/xen/Kconfig +1
-1@@ -123,7 +123,7 @@ config XEN_SYS_HYPERVISOR select SYS_HYPERVISOR default y help - Create entries under /sys/hypervisor describing the Xen + Create entries under /sys/hypervisor describing the Xen hypervisor environment. When running native or in another virtual environment, /sys/hypervisor will still be present, but will have no xen contents.
... here you end up with a tab and one space, whereas ...
Quoted 19 lines
drivers/xen/Kconfig +2
-2@@ -271,7 +271,7 @@ config XEN_ACPI_PROCESSOR depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ default m help - This ACPI processor uploads Power Management information to the Xen + This ACPI processor uploads Power Management information to the Xen hypervisor. To do that the driver parses the Power Management data and uploads@@ -280,7 +280,7 @@ config XEN_ACPI_PROCESSOR SMM so that other drivers (such as ACPI cpufreq scaling driver) will not load. - To compile this driver as a module, choose M here: the module will be + To compile this driver as a module, choose M here: the module will be called xen_acpi_processor If you do not know what to choose, select M here. If the CPUFREQ drivers are built in, select Y here.
drivers/xen/Kconfig config XEN_SYMS · line 317
Quoted 7 lines
drivers/xen/Kconfig +2
-2@@ -313,8 +313,8 @@ config XEN_SYMS depends on X86 && XEN_DOM0 && XENFS default y if KALLSYMS help - Exports hypervisor symbols (along with their types and addresses) via - /proc/xen/xensyms file, similar to /proc/kallsyms + Exports hypervisor symbols (along with their types and addresses) via + /proc/xen/xensyms file, similar to /proc/kallsyms
... everywhere else you have a tab and two spaces, as I would have expected.
Furthermore in various cases you leave space indented the directives other than "help". With a title like the one this patch has I'd expect all indentation issues to be taken care of.
Jan
Quoted 76 lines · Jan Beulich
Quoted 19 lines · Krzysztof Kozlowski
Adjust indentation from spaces to tab (+optional two spaces) as in coding style with command like:
$ sed -e 's/^ /\t/' -i */KconfigSigned-off-by Krzysztof Kozlowski <[email protected]>--- drivers/xen/Kconfig | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)drivers/xen/Kconfig +0
-2@@ -110,12 +110,12 @@ config XEN_COMPAT_XENFS depends on XENFS default y help - The old xenstore userspace tools expect to find "xenbus" - under /proc/xen, but "xenbus" is now found at the root of thedrivers/xen/Kconfig config XEN_COMPAT_XENFS · line 118
Quoted 10 lines
drivers/xen/Kconfig +6
-4- xenfs filesystem. Selecting this causes the kernel to create - the compatibility mount point /proc/xen if it is running on - a xen platform. - If in doubt, say yes. + The old xenstore userspace tools expect to find "xenbus" + under /proc/xen, but "xenbus" is now found at the root of the + xenfs filesystem. Selecting this causes the kernel to create + the compatibility mount point /proc/xen if it is running on + a xen platform. + If in doubt, say yes.Here and ...
drivers/xen/Kconfig config XEN_SYS_HYPERVISOR · line 129
Quoted 9 lines
drivers/xen/Kconfig +1
-1@@ -123,7 +123,7 @@ config XEN_SYS_HYPERVISOR select SYS_HYPERVISOR default y help - Create entries under /sys/hypervisor describing the Xen + Create entries under /sys/hypervisor describing the Xen hypervisor environment. When running native or in another virtual environment, /sys/hypervisor will still be present, but will have no xen contents.... here you end up with a tab and one space, whereas ...
Quoted 19 lines
drivers/xen/Kconfig +2
-2@@ -271,7 +271,7 @@ config XEN_ACPI_PROCESSOR depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ default m help - This ACPI processor uploads Power Management information to the Xen + This ACPI processor uploads Power Management information to the Xen hypervisor. To do that the driver parses the Power Management data and uploads@@ -280,7 +280,7 @@ config XEN_ACPI_PROCESSOR SMM so that other drivers (such as ACPI cpufreq scaling driver) will not load. - To compile this driver as a module, choose M here: the module will be + To compile this driver as a module, choose M here: the module will be called xen_acpi_processor If you do not know what to choose, select M here. If the CPUFREQ drivers are built in, select Y here.drivers/xen/Kconfig config XEN_SYMS · line 317
Quoted 7 lines
drivers/xen/Kconfig +2
-2@@ -313,8 +313,8 @@ config XEN_SYMS depends on X86 && XEN_DOM0 && XENFS default y if KALLSYMS help - Exports hypervisor symbols (along with their types and addresses) via - /proc/xen/xensyms file, similar to /proc/kallsyms + Exports hypervisor symbols (along with their types and addresses) via + /proc/xen/xensyms file, similar to /proc/kallsyms... everywhere else you have a tab and two spaces, as I would have expected.
Quoted 3 lines
Furthermore in various cases you leave space indented the directives other than "help". With a title like the one this patch has I'd expect all indentation issues to be taken care of.
Thanks for pointing it out. Indeed I did not fix all violations - sometimes there are also 7 spaces, or tab+{1,3} spaces. I'll send a follow up.
Best regards,
Krzysztof