Skip to contentSkip to conversation

Reconsidering redundant function calls (with SmPL)

cocci New Markus Elfring 1 participant 3 messages Apr 25, 2023

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

Hello,

Script variants for the semantic patch language can help also to take another look at the usage of various function calls.

Will development interests grow for the avoidance of undesirable data processing efforts?

Regards,
Markus

#1 lore raw

PATCH 1/1 scsi: bfa: Delete unnecessary memset() call before memcpy() in three functions

From: Markus Elfring <[email protected]>
Date: Tue, 25 Apr 2023 11:08:25 +0200

The function “memset” was called for a memory area which was immediately overwritten by a subsequent call of the function “memcpy”.
Thus remove such a redundant function call.

This issue was detected by using the Coccinelle software.

---
 drivers/scsi/bfa/bfa_ioc.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/scsi/bfa/bfa_ioc.c +0 -3
index 5740302d83ac..5275a4fcf1e2 100644
@@ -2748,7 +2748,6 @@ bfa_ioc_get_type(struct bfa_ioc_s *ioc)
 void
 bfa_ioc_get_adapter_serial_num(struct bfa_ioc_s *ioc, char *serial_num)
 {
-	memset((void *)serial_num, 0, BFA_ADAPTER_SERIAL_NUM_LEN);
 	memcpy((void *)serial_num,
 			(void *)ioc->attr->brcd_serialnum,
 			BFA_ADAPTER_SERIAL_NUM_LEN);
@@ -2757,7 +2756,6 @@ bfa_ioc_get_adapter_serial_num(struct bfa_ioc_s *ioc, char *serial_num)
 void
 bfa_ioc_get_adapter_fw_ver(struct bfa_ioc_s *ioc, char *fw_ver)
 {
-	memset((void *)fw_ver, 0, BFA_VERSION_LEN);
 	memcpy(fw_ver, ioc->attr->fw_version, BFA_VERSION_LEN);
 }
 
@@ -2779,7 +2777,6 @@ bfa_ioc_get_pci_chip_rev(struct bfa_ioc_s *ioc, char *chip_rev)
 void
 bfa_ioc_get_adapter_optrom_ver(struct bfa_ioc_s *ioc, char *optrom_ver)
 {
-	memset((void *)optrom_ver, 0, BFA_VERSION_LEN);
 	memcpy(optrom_ver, ioc->attr->optrom_version,
 		      BFA_VERSION_LEN);
 }

--
2.40.0

#2 lore raw

PATCH 1/1 HID: amd_sfh: Delete 10 unnecessary memset() calls before memcpy()

In reply to Markus Elfring

From: Markus Elfring <[email protected]>
Date: Tue, 25 Apr 2023 11:38:36 +0200

The function “memset” was called for memory areas which were immediately overwritten by a subsequent call of the function “memcpy”.
Thus remove such redundant function calls.

This issue was detected by using the Coccinelle software.

---
 drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.c | 5 -----
 drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c             | 5 -----
 2 files changed, 10 deletions(-)
drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.c +0 -5
index 8716a05950c8..d2587ca1ed63 100644
@@ -33,28 +33,23 @@ static int get_report_descriptor(int sensor_idx, u8 *rep_desc)
 {
 	switch (sensor_idx) {
 	case accel_idx: /* accel */
-		memset(rep_desc, 0, sizeof(accel3_report_descriptor));
 		memcpy(rep_desc, accel3_report_descriptor,
 		       sizeof(accel3_report_descriptor));
 		break;
 	case gyro_idx: /* gyro */
-		memset(rep_desc, 0, sizeof(gyro3_report_descriptor));
 		memcpy(rep_desc, gyro3_report_descriptor,
 		       sizeof(gyro3_report_descriptor));
 		break;
 	case mag_idx: /* Magnetometer */
-		memset(rep_desc, 0, sizeof(comp3_report_descriptor));
 		memcpy(rep_desc, comp3_report_descriptor,
 		       sizeof(comp3_report_descriptor));
 		break;
 	case als_idx: /* ambient light sensor */
 	case ACS_IDX: /* ambient color sensor */
-		memset(rep_desc, 0, sizeof(als_report_descriptor));
 		memcpy(rep_desc, als_report_descriptor,
 		       sizeof(als_report_descriptor));
 		break;
 	case HPD_IDX: /* HPD sensor */
-		memset(rep_desc, 0, sizeof(hpd_report_descriptor));
 		memcpy(rep_desc, hpd_report_descriptor,
 		       sizeof(hpd_report_descriptor));
 		break;
drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c +0 -5
index 6f0d332ccf51..d2cff0aa2ec7 100644
@@ -30,27 +30,22 @@ static int get_report_desc(int sensor_idx, u8 *rep_desc)
 {
 	switch (sensor_idx) {
 	case ACCEL_IDX: /* accelerometer */
-		memset(rep_desc, 0, sizeof(accel3_report_descriptor));
 		memcpy(rep_desc, accel3_report_descriptor,
 		       sizeof(accel3_report_descriptor));
 		break;
 	case GYRO_IDX: /* gyroscope */
-		memset(rep_desc, 0, sizeof(gyro3_report_descriptor));
 		memcpy(rep_desc, gyro3_report_descriptor,
 		       sizeof(gyro3_report_descriptor));
 		break;
 	case MAG_IDX: /* magnetometer */
-		memset(rep_desc, 0, sizeof(comp3_report_descriptor));
 		memcpy(rep_desc, comp3_report_descriptor,
 		       sizeof(comp3_report_descriptor));
 		break;
 	case ALS_IDX: /* ambient light sensor */
-		memset(rep_desc, 0, sizeof(als_report_descriptor));
 		memcpy(rep_desc, als_report_descriptor,
 		       sizeof(als_report_descriptor));
 		break;
 	case HPD_IDX: /* HPD sensor */
-		memset(rep_desc, 0, sizeof(hpd_report_descriptor));
 		memcpy(rep_desc, hpd_report_descriptor,
 		       sizeof(hpd_report_descriptor));
 		break;

--
2.40.0