Skip to contentSkip to conversation

tst_test: Fix exit value on tst_brk(TCONF, ...)

PATCH New Cyril Hrubis 2 participants 3 messages Jan 17, 2018 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tst_test: Fix exit value on tst_brk(TCONF, ...)

We decided not to propagate TCONF into the test exit value in a case that the test had at least one TPASS in:

commit 5390d6ea36578c1fac8adc416b6f91aa4a330a08

Author: Cyril Hrubis <[email protected]>
Date:   Thu Sep 7 15:47:22 2017 +0200

lib/tst_test: Report 0 if test has both TPASS and TCONF

However this commit missed a case when TCONF is passed directly to the do_exit() function. This may happen in two cases actually, one of the is tst_brk(TCONF, ...) called from a test and second one is more subtle and happens when the last result in the run_tcases_per_fs() produces TCONF which is then propagated to the do_exit() function.

This commit simply mask the TCONF from the exit value in this cases if we happen to have non-zero success counter.

---
 lib/tst_test.c | 3 +++
 1 file changed, 3 insertions(+)
lib/tst_test.c +3 -0
index e7b9cddf1..1df4b72df 100644
@@ -580,6 +580,9 @@ static void do_exit(int ret)
 		printf("skipped  %d\n", results->skipped);
 		printf("warnings %d\n", results->warnings);
 
+		if (results->passed && ret == TCONF)
+			ret = 0;
+
 		if (results->failed)
 			ret |= TFAIL;
 
Signature · 1 line
2.13.6
#1 lore raw

PATCH 1/1 tst_test: Fix exit value on tst_brk(TCONF, ...)

----- Original Message -----

Quoted 9 lines

We decided not to propagate TCONF into the test exit value in a case that the test had at least one TPASS in:

commit 5390d6ea36578c1fac8adc416b6f91aa4a330a08

Author: Cyril Hrubis <[email protected]>
Date:   Thu Sep 7 15:47:22 2017 +0200

lib/tst_test: Report 0 if test has both TPASS and TCONF

Quoted 8 lines

However this commit missed a case when TCONF is passed directly to the do_exit() function. This may happen in two cases actually, one of the is tst_brk(TCONF, ...) called from a test and second one is more subtle and happens when the last result in the run_tcases_per_fs() produces TCONF which is then propagated to the do_exit() function.

This commit simply mask the TCONF from the exit value in this cases if we happen to have non-zero success counter.

Makes sense to me, ACK.

Regards,
Jan

#2 lore raw

PATCH 1/1 tst_test: Fix exit value on tst_brk(TCONF, ...)

Hi!

Quoted 1 line

Makes sense to me, ACK.

Pushed.

Signature · 2 lines
Cyril Hrubis
[email protected]